[Bug 275487] x11-themes/xfce-icons-elementary (still) not prefix-safe

From: <bugzilla-noreply_at_freebsd.org>
Date: Sat, 02 Dec 2023 20:34:53 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275487

Guido Falsi <madpilot@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #246728|0                           |1
        is obsolete|                            |

--- Comment #2 from Guido Falsi <madpilot@FreeBSD.org> ---
Created attachment 246730
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=246730&action=edit
patch v2

Luckily poudriere took very little for a first test and I noticed one thing I
did notice in my first commit.

The PREFIX variable is already included by default in MAKE_ENV, so I don't see
the need to add it to MAKE_ARGS too.

Seems to work fine like that, so I'm proposing a simpler patch.

Could you also test this?

If the PREFIX value passed via MAKE_ENV is not enough we need to investigate
why, because it indicates something wrong in the upstream Makefile and the
correct fix is not passing the value twice, but fixing the Makefile.

I also made the REINPLACE command silent, since this is the common practice in
the ports tree, and also the way suggested in all the porter's handbook
examples.

-- 
You are receiving this mail because:
You are the assignee for the bug.