[Bug 275487] x11-themes/xfce-icons-elementary (still) not prefix-safe

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275487

Guido Falsi <madpilot@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|maintainer-feedback?(xfce@F |maintainer-feedback+
                   |reeBSD.org)                 |
                 CC|                            |madpilot@FreeBSD.org
             Status|New                         |In Progress

--- Comment #1 from Guido Falsi <madpilot@FreeBSD.org> ---
Hi,

Thanks for the patch! You make good points, Just to be pedantic I'll elaborate
a little:

I suspect the improper management of prefix could be a vestige of the past when
(I have not checked it is a mere hypothesis) elementary theme build system did
not allow it as an argument.

Also while I agree that it is anyway better to respect CFLAGS, there is not
strict rule on that about programs that are not actually installed on the
system. Upstream could in fact have special needs for cflags of internal tools
that could conflict with ports system CFLAGS. This is not the case though, so
your patch looks fine in this respect too.

BTW the += is not needed at that point of the Makefile, we have still to
include any other makefile, so there is no existing MAKE_ARGS variable to
append to.

I'm going to test this patch and commit it soon.

-- 
You are receiving this mail because:
You are the assignee for the bug.