[Bug 265379] x11/xfce4-goodies can depend on sysutils/xfce4-battery-plugin when battery-plugin is unbuildable

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265379

            Bug ID: 265379
           Summary: x11/xfce4-goodies can depend on
                    sysutils/xfce4-battery-plugin when battery-plugin is
                    unbuildable
           Product: Ports & Packages
           Version: Latest
          Hardware: arm64
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: xfce@FreeBSD.org
          Reporter: mike@urgle.com
          Assignee: xfce@FreeBSD.org
             Flags: maintainer-feedback?(xfce@FreeBSD.org)

Hi,

x11/xfce4-goodies can depend on sysutils/xfce4-battery-plugin, and does so by
default.

sysutils/xfce4-battery-plugin is 'ONLY_FOR_ARCHS= amd64 i386'.

This means that building x11/xfce4-goodies on aarch64 (and probably others)
fails without some fiddling.

I think you can be cunning with various OPTIONS_ settings to make it so that
the BATTERY option is only available on amd64 and i386, and only set by default
on those arches... but the following patch follows the powerpc example for the
arch I found the problem on (it misses out armv6, armv7, risc64, and risc64sf
and possibly more). 

index fb2e9437b7b5..840c34cb8510 100644
--- a/x11/xfce4-goodies/Makefile
+++ b/x11/xfce4-goodies/Makefile
@@ -23,6 +23,7 @@ OPTIONS_EXCLUDE_powerpc=      BATTERY
 OPTIONS_EXCLUDE_powerpc64=     BATTERY
 OPTIONS_EXCLUDE_powerpc64le=   BATTERY
 OPTIONS_EXCLUDE_powerpcspe=    BATTERY
+OPTIONS_EXCLUDE_aarch64=       BATTERY

 OPTIONS_GROUP= APPLICATIONS PANELPLUGINS THUNARPLUGINS UNOFFICIAL

-- 
You are receiving this mail because:
You are the assignee for the bug.