From nobody Fri Mar 18 15:24:17 2022 X-Original-To: freebsd-xen@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 9D0191A2D0F8 for ; Fri, 18 Mar 2022 15:26:08 +0000 (UTC) (envelope-from prvs=069af078f=roger.pau@citrix.com) Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.hc3370-68.iphmx.com", Issuer "HydrantID Server CA O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KKnsW2JTlz3s1w for ; Fri, 18 Mar 2022 15:26:07 +0000 (UTC) (envelope-from prvs=069af078f=roger.pau@citrix.com) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1647617167; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=3Y6LlHolQrMOoQRDnJ/m/AEcvG9o8xdx9gHCumvwup4=; b=ACFxs9x+UrWdliUxxJp/4v6+hM7cm2PIuaFn5L8y3C+VcXptrIssmUW9 nzRWrigFDu5uNDaiuFiFs1IWoApo7PntVZzP4DHtLooKf7XC48keB71eg y9KODYsyX7TW1TQuwGr54ZKQYWd9tKxiaQSXpr7f8LW/tmUkewDSHaZ3o 8=; X-SBRS: 5.1 X-MesageID: 66612315 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:v/S27a6sLUd3nA3TornD4wxRtCnHchMFZxGqfqrLsTDasY5as4F+v jMcXG2FbqqCMDP8co1xYNvlp0oAusCHm99mSlY6qS43Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YPgU1vX0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurTtYwluIKnwmt4UTiQGCDl8H6Rn6LPIdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsFvX5t13fBBOsOSpHfWaTao9Rf2V/cg+gQQ6iHP ZFANFKDajz6WyZtHlcuI6se39qahkb6XT1Dsl+88P9fD2/7k1UqjemF3MDuUtaXRd9SgW6eq GjN9mC/BQsVXPSR0zeI+Gmgw//Cmwv1Qo8fHqa0sPlwjzW71GEfFQUNRECTrvywi0r4UNVaQ 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfINOeN99gWxyJDd/jvHHXAGbDdgeNAp4ZpeqSMR6 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZO3ZaEFJtD83L5dhq00mRFooL/Lud1IWdJN3m/ 9ydQMHSbZ03hNVD6ai09Euvb9mE9smQFV5dCuk6swuYAuJFiGyNOtTABbvzt68owGOlor+p5 iBsdy+2trxmMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8iexo3a59fIWKxO Sc/XD+9ArcJYBNGioctPuqM5zkCl/C8RbwJqNiJBjaxXnSBXFDep3w/DaJh92vsjFItgckC1 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6DFPjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H hc2H5bi9iizp8WlO3iJq9FPdQ5WRZX5bLivw/Fqmie4ClMOMEkqCuPLwKNnfIpgnq9PkfzP8 G37UUhdoGcTT1WWdW1mtlgLhGvTYKtC IronPort-HdrOrdr: A9a23:pQAVhakivGLoMR6kDZeEuNd/gkHpDfPIimdD5ihNYBxZY6Wkfp +V8sjzhCWatN9OYh0dcLC7WJVpQRvnhPhICK0qTMqftW7dyReVxeBZnPHfKljbehEWmdQtsJ uIH5IObOEYSGIK8voSgzPIY+rIouP3iJxA7N22pxwGIHAIGsNdBkVCe32m+yVNNXh77PECZe OhD6R81l2dkSN9VLXEOpBJZZmJm/T70LbdJTIWDR8u7weDyRuu9b7BChCdmjMTSSlGz7sO+X XM11WR3NTvj9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhHhkByhaohNU6CL+Bo1vOaswlA3l8 SkmWZrA+1Dr1fqOk2lqxrk3AftlB4o9n/Z0FedxUDupMToLQhKffZptMZ8SF/0+kAgtNZz3O ZgxGSCradaChvGgWDU+8XIfwsCrDv7nVMS1cooy1BPW4oXb7Fc6aYF+llOLZsGFCXmrKg6De hVCt3G7vo+SyLUU5nghBgu/DWQZAVxIv/fKXJy+PB9kgIm0EyR9nFohfD2xRw7hdcAo5ot3Z WyDk0nrsALciYsV9MOOA4we7rFNoXze2O4DIuzGyWvKEhVAQOEl3bIiI9FkN1CPqZ4i6cPpA == X-IronPort-AV: E=Sophos;i="5.90,192,1643691600"; d="scan'208";a="66612315" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EbRpKpWkPWhFIkbA48zxO2V6Q+WTOg43OwCiog3MwqRGH5UnNp8VA3cS+SVEJ9YVJjN8xVmVgvG4RfFlQ2T4ATEOkWZTBr3jKdiOOKfIsgD2pbnwB9UtFomT+xRDeIX6zMpwMwG/G//ArdZ1wewM6ax7JqZ+JNHN8nvKgw7w9wEyf77ZNBa8sXd9RhGuJcWx1a13cPEYyE48gm/MVL9UKKbTYdtDOTs2gD+/sDhwxFIeFOKPsukUfsNg61kAYsVB9w/W2QxUxQJO6nfTEU9OfNhlKtacDq1RM/+EejaSj6eqffLAqqBYYoS0Tv6+LkFLenaKUuLNq7/vJ9aa2LoWzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/TxqRAZaqlJdLC4rO3xuSnDU23bR4XzJveAV8wYtAm4=; b=T+0RNPEXt3OGldVTSUbJ/FFBBJxir3zznLU6HPR6P0tNaQNFVKPOYv3vZ4+9juZlvMSv3g5ZXpvVc5wAQa50pT2Rfhd2k9ab23udB0Rjky3Jifxw+8FoLhSSuRnxclo++ljLD/5WboqoPzBs70MN4uZxjveFbLm4CR2bVe1kzBM/JFyqz3HVHtgqRqNeZWh8EVSS/gKwy4znvwfpgecebMectB6HoObPmJN8Oo3qd+VM/zad6dKS5bc8XNlP7DQSP9JoByar6DxACBtVNC1F7RxMC9aCFq2JJwq2rVluHTw/zSYUyfSSWmz6eB5o7KWLLFFZhVWwkLm3Cgub66sQAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/TxqRAZaqlJdLC4rO3xuSnDU23bR4XzJveAV8wYtAm4=; b=XexZpUVpiUtz0Sg7h/jTpX6H8z29qcbCUGo4100o99OWbD9ZOU42xw0RfJZzTFs9llrmMPxfpMaMjL4h5PMBuNRgwQusAabFlW5jv5KW8xcn/Ke1hL8jLmycxXAxAc308kjOSQ2GIovRsjfGNJ/aRMh78PI68JTgG0nFZjfhr/Q= Date: Fri, 18 Mar 2022 16:24:17 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Ze Dupsys CC: , Subject: Re: ZFS + FreeBSD XEN dom0 panic Message-ID: References: <3d4691a7-c4b3-1c91-9eaa-7af071561bb6@gmail.com> <5dfdecd5-f94d-29b4-791e-0adde5405cf5@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0492.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::17) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-xen List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-xen@freebsd.org X-BeenThere: freebsd-xen@freebsd.org MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a092eec2-0b86-4ffb-4d93-08da08f36169 X-MS-TrafficTypeDiagnostic: SN6PR03MB4368:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Pa7ir0nX9RP60Nbj786KI5yUb9UptW/ElFjgMLXVegIAcc8PlbpMq4w0nt4IskpqPNly3bUcZSYWCCdV63RNeOjjYmBIuzEWhUDtkfG6Mjgj/xJkEyM6TJJOiXqTc48fFnZ8xWOQv/Kp5z5ema5WzEnB3DAdxIX5ErNDaEB3CZQQQN3yU9lVbSWchhi9hgh65j7RlWjqRwHM14cNKp23EM6JgE8QRtOjkS107g6lkYzM1qmqr1rTrv4OXDy8G4MRQjDsmhYYRlix4fNhwaNpCHocjNKWZRQ4rQkzik0R6kngveio+FfIWpv3ZyIyCzJl1sKP7sW61HxZWmN29sfiRlP/tZp7+SSSFl7VNXJslxojBEr33RpPKII2jdYZm3hTiBX0144a42RWonqZZ/Fil94XvKtcYTV2GuYkEN61en1L+iT3qlVOsHqyVDVUCpuc2Yp8JbEERiXnaJ642ekht2Etk7IKTTdWyp18nCzDaVjf1bi9rBgKdhyG4QT+z89twTWjqE4rUwvjhRaTT2zq7Aolsq1PVNvBvjnghln+jznL2t35WpA+1y94JcLpC3e1NVL4gWoUzNPL7AXiK4vB936QKsO10j+m4kCFppEwBaULdrOyhyostrynu6W42YQ2ny6jjYCP+jGSmdg5Ucpr6w+SRdCUjEB0SxMY85XE7wpNNUv/Ggy4U4zQoMpTU3wnz5Lnds1GvMR2IsValn7ogg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(38100700002)(4326008)(66476007)(66946007)(66556008)(82960400001)(6916009)(8676002)(316002)(2906002)(33716001)(9686003)(8936002)(6512007)(83380400001)(5660300002)(26005)(186003)(86362001)(6666004)(6486002)(508600001)(85182001)(6506007)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?LzU2aTkrZXJycTNsMVlEVmJPbHZ5SFNRdW1HYWI4L1Jma1dHcmV6N1JPSEJl?= =?utf-8?B?MlIzUXZMTk4zdEJuUE51aGtrSDZoRk90eUFlbENLYzBNVFZ4T3dVbGxCOFl1?= =?utf-8?B?L0FFVWp4R3pUM3E0eXJzTk5TeitzN2ZIQkdmYjl1RDkwWGJiNXlzYnd0WDFJ?= =?utf-8?B?Q1A0L3FFK1paSDRVR2pSbEZaOHhpQWsxVjRoSjFOSWZBd01WOVRRNWlXcmh2?= =?utf-8?B?bmdiOU5nNVpHV2EzMVNobTg5YkpZOHVTcWFmb1ZxOGxvcDlFeW5BMG1iSEhW?= =?utf-8?B?WTJ3b0ZteWUzdHJYbW9sbEw1bVNBWEhMaXQ2OC9zS05sOHRwMHhTallGOWRk?= =?utf-8?B?SzIzTWhIY1h4LzFBQ21DTXFVTTJRSTUxSmdRWE9ObGNManB6MW5RWW9teU9Z?= =?utf-8?B?ODNrVmlKWUZKTjh4bHROcnkzUXpuRGpDZVFBV2czQWtwVHBYWUtNcGhsNXJh?= =?utf-8?B?aUdpR0tZdWU3dE1TZVQ5N2tWemVadHloWHlveTFPWW54VC96OTU3YVEveUF1?= =?utf-8?B?T2VWcVBSejVsRDkvTTZIZm4zSEJjK3pnSXVyS1Jqek4xalhGam5MaUpKS0Q3?= =?utf-8?B?UFRDVnBTVm1BdmNYei84M0JkNkdCVXFkb1BvWXBZYjFEQk5oZlUxUGpNcjlz?= =?utf-8?B?QzlxUkMydzNGbG0zMmZXOTVTWmRpeTJlQkNubUxnNjV3VnJTOGx6dEdqdDRm?= =?utf-8?B?SWpIUFhpUTJuTmt3eS9JcXFXZkMvZEc4Wjk4cktYWVZyN04rN1VCT01Fc1dW?= =?utf-8?B?YXg0NS9DV3RGY1dtcU8yNDJGOW8zVEw1OEZHVzFiWXVGR1kzZHgyeXFpa0ZK?= =?utf-8?B?eDhaWWVkZGhwSnZGMThWOTlPNC9ZUHZCdmRablNyRTQ2S2dQclFJcGVzSFpm?= =?utf-8?B?SkJoZXlBUzlOcmh6MytUZEF6MXJZK2xJOUFZc0wxdzhJV0F2cmxRd3FhWkp1?= =?utf-8?B?VCs1NGN6MUJGcmFvdkluZmNQY3JodUtBQXhsM0FrQklidE52LzJZTS9RT1BS?= =?utf-8?B?d01uU0dwTzBtdFhYcmsxU3JYNmFHb0NaZnhNaXRWR1kvbmlTU2I4dnV6aHp6?= =?utf-8?B?WkFXL3dxdWNBZkpPMU9PVlQ4dXd6VkVLZ1M1L3J6SWdCcXRPUVgvWmxKT2xX?= =?utf-8?B?QUNqdmhGOSt6aSsrQ3VGdFJaemxVYzN2eFJzbkNpTjlubTg2UWNhWTRtenpm?= =?utf-8?B?UnE0Q0RTVmJObUF2QU54MW5sRnMydWhwRDRZdXBqTHNaa0w2S1o5Z01vaHJJ?= =?utf-8?B?TTg5ZFcrSG5JWUxDejEzb1pDQU9DLzNuNmlpS3JhTW12emE1dkhTUURvbXFn?= =?utf-8?B?VXFUdzA4bGllYzUvVXBNTXZKdUtFTDJxeTBtKzhxTmFNUjhZZ3FCNUZTUGpi?= =?utf-8?B?M3JaMnhsNzdlMWYyUUMxcjNMSTNaN3FaTDlWZUxiRXRmNmZOZFZ0MnBFQkho?= =?utf-8?B?OFh2NnpCUXRPZGtaVEpzS3JSbDI4S1grV3pqalAwWGd6TWg4SE5VWG1LL2Fn?= =?utf-8?B?QjRaR1NpTlNUZktjYm1UMStFNDNCalB0Uk5XK1JCYU1iUEoycGN2aHRLSHhM?= =?utf-8?B?ZWFSU0cvbGhUNXFTeTNVMG1pR3RCQlgyK3VnbWVTRUhGcWtlMmRDSklaMTcz?= =?utf-8?B?THBuajNtNXdEMEE5Sm5JWXdCRU8yaUhtektwWWtGMTVJVWwrOEpQbmg4WXRY?= =?utf-8?B?M2pkL1BXYTRKQThOMSswV1JtcFhtM2RDejBuYjNBeWc0R1NRNzV4cFJNNW9p?= =?utf-8?B?RWNodzhUbFZXZjMyMVlzaWpPMWpaRWM0ZC9CUHY2RUVqazZDMzR6OWRzMFFX?= =?utf-8?B?N0I4cW50T1p1SFVCV1ZhYkhTdkNsZ1JCUytldzRaZnpNWWZkZldsMEdLdUJG?= =?utf-8?B?Vk1mY3dNL0JUb2xRYXJnOG5FTGo0NjkrZ2szTEVOUkF4SjhLNjFuWW9GUXJr?= =?utf-8?Q?X4Pk9vXQhIJLwbLU1BaXpWwZE2GdDPEl?= X-MS-Exchange-CrossTenant-Network-Message-Id: a092eec2-0b86-4ffb-4d93-08da08f36169 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2022 15:24:23.2755 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5QMaQk3fEj9YX2Noh4M3uGZvDe9oabaGiRWwkus7QtdxsPLBrzC28hmCwzPFUX9oEhwU7AOO1rDK/1uVtVnkRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4368 X-OriginatorOrg: citrix.com X-Rspamd-Queue-Id: 4KKnsW2JTlz3s1w X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=citrix.com header.s=securemail header.b=ACFxs9x+; dkim=pass header.d=citrix.onmicrosoft.com header.s=selector2-citrix-onmicrosoft-com header.b=XexZpUVp; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=citrix.com; spf=pass (mx1.freebsd.org: domain of "prvs=069af078f=roger.pau@citrix.com" designates 216.71.145.155 as permitted sender) smtp.mailfrom="prvs=069af078f=roger.pau@citrix.com" X-Spamd-Result: default: False [-5.62 / 15.00]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+exists:216.71.145.155.spf.hc3370-68.iphmx.com]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; DKIM_TRACE(0.00)[citrix.com:+,citrix.onmicrosoft.com:+]; DMARC_POLICY_ALLOW(-0.50)[citrix.com,reject]; RCVD_IN_DNSWL_MED(-0.20)[216.71.145.155:from]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_COUNT_ZERO(0.00)[0]; MIME_TRACE(0.00)[0:+]; R_MIXED_CHARSET(0.56)[subject]; ASN(0.00)[asn:16417, ipnet:216.71.145.0/24, country:US]; FROM_NEQ_ENVFROM(0.00)[roger.pau@citrix.com,prvs=069af078f=roger.pau@citrix.com]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[citrix.com:s=securemail,citrix.onmicrosoft.com:s=selector2-citrix-onmicrosoft-com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_SHORT(-0.98)[-0.980]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FORGED_SENDER_VERP_SRS(0.00)[]; DWL_DNSWL_LOW(-1.00)[citrix.com:dkim]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MLMMJ_DEST(0.00)[freebsd-xen]; MID_RHS_NOT_FQDN(0.50)[] X-ThisMailContainsUnwantedMimeParts: N On Tue, Mar 15, 2022 at 08:51:57AM +0200, Ze Dupsys wrote: > On 2022.03.14. 11:19, Roger Pau Monné wrote: > > On Mon, Mar 14, 2022 at 10:06:58AM +0200, Ze Dupsys wrote: > > > .. > > > > > > Why those lines starting "xnb(xnb_detach:1330):" do not have any message? > > > Could it be that there is a bad pointer to message buffer that can not be > > > printed? And then sometimes panic happens because access goes out of allowed > > > memory region? > > Some messages in netback are just "\n", likely leftovers from debug. > Okay, found the lines, it is as you say. So this will not be an easy one. > > > > Can you try to stress the system again but this time with guests not > > having any network interfaces? (so that netback doesn't get used in > > dom0). > I'll try to come up with something. At the moment all commands to VMs are > given through ssh. > > > > Then if you could rebuild the FreeBSD dom0 kernel with the above patch > > we might be able to get a bit more of info about blkback shutdown. > I rebuilt 13.1 STABLE, with commenting out #undef and adding #define, thus > line number will differ by single line. For this test i did not remove > network interfaces, and did add DPRINTF messages to xnb_detach function as > well, since i hoped to maybe catch something there, by printing pointers. I > somewhat did not like that xnb_detach does not check for NULL return from > device_get_softc, nor for device_t argument, so i though, maybe those > crashes are something related to that. But i guess this will not be so easy, > and maybe it is safe to assume that "device_t dev" is always valid in that > context. > > So i ran stress test, system did not crash as it happens often when more > debugging info is printed, characteristics change. But it did leak sysctl > xbbd variables. I'll attach all collected log files. sysctl and xl list > commands differ in timing a little bit. xl list _02 is when all VMs are > turned off. Sysctl only has keys without values, not to trigger xnb tests > while reading all values. So I've been staring at this for a while, and I'm not yet sure I figured out exactly what's going on, but can you give a try to the patch below? Thanks, Roger. ---8<--- diff --git a/sys/xen/xenbus/xenbusb.c b/sys/xen/xenbus/xenbusb.c index e026f8203ea1..a8b75f46b9cc 100644 --- a/sys/xen/xenbus/xenbusb.c +++ b/sys/xen/xenbus/xenbusb.c @@ -254,7 +254,7 @@ xenbusb_delete_child(device_t dev, device_t child) static void xenbusb_verify_device(device_t dev, device_t child) { - if (xs_exists(XST_NIL, xenbus_get_node(child), "") == 0) { + if (xs_exists(XST_NIL, xenbus_get_node(child), "state") == 0) { /* * Device tree has been removed from Xenbus. * Tear down the device.