From nobody Sun Jan 28 06:24:38 2024 X-Original-To: x11@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TN1cR2tt8z57tYT for ; Sun, 28 Jan 2024 06:24:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TN1cR1rpcz48st for ; Sun, 28 Jan 2024 06:24:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706423079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3lT7VqDLPp+kPe9xDg+z9VdT0q0obZSnsJYMJ4yxsFQ=; b=jPXFAf/BSdxyUjczbJpsRvcSUi0Z2ooxWHBrM03uc1bOf8WcpJ+u1OgXvrI/IiiK7pNnCk s2OrXistQCscQf3SrUEte5ZENKaGk4Bkd1yqwkurcV/nKySMwleHbRk+7eYdp23Ze0FXBA WxKhVNrlprrmZ17wljNANxuITG9BrMLRledb578txSSk/8sQrVcQE6d7YeCcHo6xUtoIT1 sOn42GwJe5NYmMDelyAicuTpLda5ZHmn0ZtJZydZue1snvnawgkrKoQQfxDT+MSCeglWSm vmeQdzvcyQ7FOE1C89AGo7H5z/YV263T0xk+4ld3wr0TP2lh0Vru6dBYT0qiNQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706423079; a=rsa-sha256; cv=none; b=gUSD+WfZ52ktHYmdJqJYL4kJK7aBf6mgiZHp18QmgJHqqE28V5WPcz3K3iaaFRXoKOUakl ZwGWNjf7Jm1C0b7sSpwhqky8MacYW2BOkWoeEdDn9PwXGXHLAaJTc23ONPj0iqUg8Y33yx UUIvdIijRjfl+x82i9myeJKddaX50rgwfTpXxTPITHOqKdi99E7XUzEGXGVtOG2bESj08u dO25Vk1qMa+8viOnVS55arlOIFGnngV0cqRHVqdkeRofAzE1Ei2FbeEgUNR7W4M1Greb1z 5Q+iGJzh+nG21W+UICqtOjBTEBh2If9hagerk6Pwm4YvxW6NHhMy60Qz8Qqqyg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TN1cR0x7pzwbR for ; Sun, 28 Jan 2024 06:24:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 40S6OdfX051591 for ; Sun, 28 Jan 2024 06:24:39 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 40S6Odan051590 for x11@FreeBSD.org; Sun, 28 Jan 2024 06:24:39 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: x11@FreeBSD.org Subject: [Bug 267606] x11-drivers/xf86-video-nv: Segmentation Fault post update from 1.20.14,1 to 21.1.4 Date: Sun, 28 Jan 2024 06:24:38 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: yusisamerican@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: x11@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: X11 List-Archive: https://lists.freebsd.org/archives/freebsd-x11 List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-x11@freebsd.org X-BeenThere: freebsd-x11@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D267606 --- Comment #44 from Yusuf Khan --- (In reply to Sergiy from comment #43) Hmm...I believe I am too dumb to adequetely solve this problem unless I use= gdb on this but... I believe `NVSetModesInfo(pScrn->monitor->Modes, pScrn->adjustFlags);` might need to be NVSetModesInfo(pScrn->modePool, pScrn->adjustFlags);. Also the call to xf86SetModeCrtc should probably be removed. I am half asleep right now so I=20 1. Cant tell why(or maybe if??!?!) xf86ValidateModes() isnt setting the mode names necessary for the modePool 2. Cant tell why we cant just pull a: @@ -1975,14 +1975,8 @@ NVPreInit(ScrnInfoPtr pScrn, int flags) if (i > 0) VBESetModeParameters(pScrn, pNv->pVbe); } else { - i =3D xf86ValidateModes(pScrn, pScrn->monitor->Modes, - pScrn->display->modes, clockRanges, - NULL, 256, max_width, - 512, 128, max_height, - pScrn->display->virtualX, - pScrn->display->virtualY, - pNv->ScratchBufferStart, - LOOKUP_BEST_REFRESH); + xf86ValidateModesSize(pScrn, pScrn->monitor->Modes, + max_width, max_height, 0); + i =3D 1; } if (i < 1 && pNv->FBDev) { (personal modePool confusion) --- If I was in front of an affected system , I would take my old patch, remove= the xf86SetModeCrtc bit to see if that fixes anything(probably wont), then reve= rt the changed to HEAD. After reverting to HEAD I would enable the FlatPanel a= nd DualHead flags separately to see if vesa stuff works(50/50 chance it does). After that I would test the xf86ValidateModesSize patch above but I have no idea if that will work at all. Maybe a bug should be added to the xserver b= ug tracker for this issue, this probably affects other drivers(particularly i8= 10). --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.=