From nobody Wed Jan 24 03:11:07 2024 X-Original-To: x11@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TKTVz6JGMz57Gqy for ; Wed, 24 Jan 2024 03:11:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TKTVz4RgVz4NVQ for ; Wed, 24 Jan 2024 03:11:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706065867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B00+LFg80lL+AZ2b3zJYJeUeC0FddnpjyXw+5k375qg=; b=O8MAXAp+dKBUjEYu1AnLaDhS74mMNEcJ/caZoJuL0zsMBHova3pa0z5tyE9BPWVbJfdhOJ /NlIyypfKld0jObw/v5yfNU5Z7lk1/fdrFuFpJST89AI6bmx/ALHY7VPwvtGbibrp5Z8/8 iv2VvQ2B+d9DZ6NKtm06Ykug9Lsg9+4r0PfDqKs+hVVt6intBloz8yDO5I/6J3pmF0XEYS jGORiQt0DV+Z2XXzBRncVyn0C8SgmnUR6rmgGTVoC3NdBNrVaNRBZCXX4jdCn7us/zR7Rq x0W40fyz/4Uu+LhiprLkd5o+yJPkA6a5N01BwElWmk04zBH2iR7mVbnEm4Bd1Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706065867; a=rsa-sha256; cv=none; b=BZVHvyGcq4OmdumhaqCh/DoZplUVm5NNon2KZ89EgFrdcLfwt7uF3iJ32vE784yIq/ab6v PIqE60f0c9vG2uIzk/pn/T1BlR9BalQtRmGaOKFrRw8z1MmxdNXAEDRav8igy4nNwaN1XZ Jn2ukIXaWX1B8npf5eYXUWVirGdh3cyurdwpm+8szFhiZzdPAMwjmrBsNv1U2u2c7Zx4wW k5tDqhegMhUkD3lDrr2LECO6XV9/DSPo8gjJ7/W0Io59cRrOU5cwhhhUcIN4E4fI1ygMVb 2ak6niL44yazZ+mZXAoNpem3gGHUYtLOtVZytKC3jqHVXT8i/7ZqcZ6+e/WAlQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TKTVz3WmlzxQR for ; Wed, 24 Jan 2024 03:11:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 40O3B7lx069206 for ; Wed, 24 Jan 2024 03:11:07 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 40O3B7eX069174 for x11@FreeBSD.org; Wed, 24 Jan 2024 03:11:07 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: x11@FreeBSD.org Subject: [Bug 267606] x11-drivers/xf86-video-nv: Segmentation Fault post update from 1.20.14,1 to 21.1.4 Date: Wed, 24 Jan 2024 03:11:07 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: yusisamerican@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: x11@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: attachments.ispatch attachments.isobsolete attachments.description Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: X11 List-Archive: https://lists.freebsd.org/archives/freebsd-x11 List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-x11@freebsd.org X-BeenThere: freebsd-x11@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D267606 Yusuf Khan changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #247909|0 |1 is patch| | Attachment #247909|1 |0 is obsolete| | Attachment #247909|Patch that would |Patch that would description|pressumably let the |pressumably let the |strcmp() pass |strcmp() pass, edited as | |previous patch was not | |correct. --- Comment #42 from Yusuf Khan --- Comment on attachment 247909 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D247909 Patch that would pressumably let the strcmp() pass, edited as previous patch was not correct. >From 9ac823cf803c842c4455714f8a7899dc6f59e7f6 Mon Sep 17 00:00:00 2001 >From: Yusuf Khan >Date: Tue, 23 Jan 2024 16:41:45 -0800 >Subject: [PATCH xf86-video-nv] nv/init: set default names and crt before > validation > >Presumably would fix https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D2= 67606, >a segfault probably resulting from the lack of a name on the modes. > >Signed-off-by: Yusuf Khan >--- > src/nv_driver.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > >diff --git a/src/nv_driver.c b/src/nv_driver.c >index d2634da..4f50aa4 100644 >--- a/src/nv_driver.c >+++ b/src/nv_driver.c >@@ -1339,6 +1339,27 @@ NVModesAdd(DisplayModePtr Modes, DisplayModePtr Add= itions) > return Modes; > } >=20 >+/* Sometimes we need info from here and we dont get it for whatever reaso= n */ >+static void >+NVSetModesInfo(DisplayModePtr Modes, int adjustFlags) >+{ >+ DisplayModePtr Mode; >+ >+ if (!Modes) { >+ return; >+ } >+ >+ Mode =3D Modes; >+ >+ while (Modes->next) { >+ Mode =3D Mode->next; >+ xf86SetModeDefaultName(Mode); >+ xf86SetModeCrtc(Mode, adjustFlags); >+ } >+ >+ return; >+} >+ > /* Mandatory */ > static Bool > NVPreInit(ScrnInfoPtr pScrn, int flags) >@@ -1975,6 +1996,7 @@ NVPreInit(ScrnInfoPtr pScrn, int flags) > if (i > 0) > VBESetModeParameters(pScrn, pNv->pVbe); > } else { >+ NVSetModesInfo(pScrn->monitor->Modes, pScrn->adjustFlags); > i =3D xf86ValidateModes(pScrn, pScrn->monitor->Modes, > pScrn->display->modes, clockRanges, > NULL, 256, max_width, >--=20 >2.43.0 > --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.=