[Bug 280957] lang/clover: Remove llvm:max=16 restriction

From: <bugzilla-noreply_at_freebsd.org>
Date: Wed, 21 Aug 2024 23:58:10 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280957

--- Comment #3 from Jan Beich <jbeich@FreeBSD.org> ---
Comment on attachment 252966
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=252966
Remove LLVM version restriction and fix LIB_DEPENDS syntax

> -		libLLVMSPIRVLib.so.${LLVM_VERSION}:devel/spirv-llvm-translator@${LLVM_PORT:T} \
> +		libLLVMSPIRVLib.so:devel/spirv-llvm-translator@${LLVM_PORT:T} \

When multiple ports provide the same library not specifying SOVERSION would
introduce build conflict if an undesired version is installed. However, this
port doesn't actually use spirv-llvm-translator because Intel GPU support is
disabled (unlike in mesa-devel, runtime-gated via IRIS_ENABLE_CLOVER=1).

> does not install libLLVMSPIRVLib.so.${LLVM_VERSION} in the first place.

From devel/spirv-llvm-translator/Makefile

  SOVERSION=    ${${FLAVOR:S/llvm//}<18:?${DISTVERSION:R:R}:${DISTVERSION:R}}

$ pkg info -xl spirv-llvm-translator | fgrep .so.
        /usr/local/llvm11/lib/libLLVMSPIRVLib.so.11
        /usr/local/llvm12/lib/libLLVMSPIRVLib.so.12
        /usr/local/llvm13/lib/libLLVMSPIRVLib.so.13
        /usr/local/llvm14/lib/libLLVMSPIRVLib.so.14
        /usr/local/llvm15/lib/libLLVMSPIRVLib.so.15
        /usr/local/llvm16/lib/libLLVMSPIRVLib.so.16
        /usr/local/llvm18/lib/libLLVMSPIRVLib.so.18.1

See also https://github.com/llvm/llvm-project/commit/91a384621e5b
(spirv-llvm-translator uses add_llvm_tool() from AddLLVM.cmake)

-- 
You are receiving this mail because:
You are the assignee for the bug.