From nobody Sat May 20 15:22:25 2023 X-Original-To: x11@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QNnWj6mytz4CB4R for ; Sat, 20 May 2023 15:22:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QNnWj4YVcz4MrK for ; Sat, 20 May 2023 15:22:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684596145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o9K5DV2IuBpf43ceG8eqjGrkPwrperQhR45mzftbmtY=; b=wtyk/ClDWil2xKd9WgAgsZoSUSJ+RzkdfAuKZYd3Moisa36AiuczRCHibSUMUIJZWahCFu 6UOr5YVPsurW0iFmQIYiiPLOZm/mRCv89RGT0ZqZ/GcDbKrHlhduX+fcVE6vhyFmFx9KR6 4hqImEk3aTEDzCXqQBk8mcHy34c5YEZQe/7UOjS2fTYUjxSg0nP2YI0bCj1CT4IjcA3bGv ZsUlidgmwqAXkHAN7SbJC7/RGmFyQll8qC5UYDvxskzc6qyUDY5kwGv2NgWXLUf95njDDI MlCe6PcB2UKD5Dyi7DzqT43b//MZFijc1ssGVnbQfFVRMN+uYIoyyGO+1BzrPA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1684596145; a=rsa-sha256; cv=none; b=sQQVnm2nul7ryxzFnvQM5m4hP0H7KYO/3ughFvbOiuo1tJBybfi0kmebtezWfxt6dycARe gFDeqF6Adfnc5Hx/DSgrZQUg15WOEyvJzLDlwv3Qge0TCxzjTFAWfoW09vfIJG8NgpFHl9 KJi7HkIM1d/norRO1w/2WiJJQ6eqQ3ydz6y+1mYN35hJ2O/HE3cznsbY9WYW52np1wdbXt JpdiEl2HKwgFUGON2159Ii8OcCu8HMAK2TcCvn9B6828PB2QiZi4qmXJc2mTbetvn0CdrA ugHBGG/M5ZVS9cPz3sUiHO38BLcF8iESWSaTmCdtLFpTONHa+x/7PQqyBC4mTg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QNnWj3cl6zFJW for ; Sat, 20 May 2023 15:22:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 34KFMPtN023001 for ; Sat, 20 May 2023 15:22:25 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 34KFMP9c023000 for x11@FreeBSD.org; Sat, 20 May 2023 15:22:25 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: x11@FreeBSD.org Subject: maintainer-feedback requested: [Bug 271533] x11/xorgproto: ensure Xos.h does not define index() as a macro Date: Sat, 20 May 2023 15:22:25 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: x11@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: X11 List-Archive: https://lists.freebsd.org/archives/freebsd-x11 List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-x11@freebsd.org X-BeenThere: freebsd-x11@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N Bugzilla Automation has asked freebsd-x11 (Nobody) for maintainer-feedback: Bug 271533: x11/xorgproto: ensure Xos.h does not define index() as a macro https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271533 --- Description --- During the exp-run for clang 16, it turned out that Xos.h defines index() and rindex() as preprocessor macros, and this causes many problems with libc++ headers [1]: /usr/include/c++/v1/variant:532:39: error: too few arguments provided to function-like macro invocation return __at(__fmatrix, __vs.index()...)( ^ /usr/local/include/X11/Xos.h:67:12: note: macro 'index' defined here # define index(s,c) (strchr((s),(c))) ^ /usr/include/c++/v1/variant:813:18: error: too few arguments provided to function-like macro invocation return index() =3D=3D variant_npos; ^ /usr/local/include/X11/Xos.h:67:12: note: macro 'index' defined here # define index(s,c) (strchr((s),(c))) ^ /usr/include/c++/v1/variant:817:25: error: expected ';' at end of declara= tion list constexpr size_t index() const noexcept { ^ /usr/include/c++/v1/variant:802:9: error: member initializer '__data' does not name a non-static data member or base class : __data(__tag), __index(__variant_npos<__index_t>) {} ^~~~~~~~~~~~~ /usr/include/c++/v1/variant:808:9: error: member initializer '__data' does not name a non-static data member or base class __data(in_place_index<_Ip>, _VSTD::forward<_Args>(__args)...), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/c++/v1/variant:920:23: error: too few arguments provided to function-like macro invocation __rhs.index(), ^ /usr/local/include/X11/Xos.h:67:12: note: macro 'index' defined here # define index(s,c) (strchr((s),(c))) ^ Add defined(__FreeBSD__) to Xos.h's #if block to include instead, so it will get our regular index() and rindex() declarations instead. This has also been sent upstream [2]. [1] [2]