From nobody Fri Jun 14 18:43:21 2024 X-Original-To: wireless@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4W17T70g6Dz5PK7s for ; Fri, 14 Jun 2024 18:43:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4W17T6649Hz4Grm for ; Fri, 14 Jun 2024 18:43:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1718390602; a=rsa-sha256; cv=none; b=SStAQ1l2loMd0HguUgtwmLwZeLu5LkAzjZiQxkzmOXblymac17L/L2QSSQmPG6ijja3vmA mrrFHMpzYHbO/H4xNYPTJSFP+zL7Xe0VeELfkvGRLU4EohQ1HKR9UGiNgxA+Qm7DLiJaws NOFA+/Ei/QT/1Ef/2oyLtKJaBFxZ6v0uXtePg0Ivc8rBslPj5pmexymATvFkqizIb0m02k z7Py9DZ1NwfKffD2/uxHy1/tYVdgYncnCdXyL91CqjTggRb2QmIjlEvF/R69DBZ8AimaO/ Dtf9rCjpy6pS1N++cn/Ck+eYto7xA76V8cRfpH0zQ+f1BiOwHSiYOr9Ev8ggkA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1718390602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IKxAJMlkX0DLuyQsiIVRNZ+xuSSRv3v4sM3bKOtEnIg=; b=gn5gt/jKSeXfBOJyS03kmVoyqIYv9zp4hIa0WRXIJijSCmwTjfkFfQ7fva3o3JI8XeVCLU CEPoHuTVAf5a39n+C5bKF9yzXeSWN9SnfWkA0kXLp6KRELdyuUBw+PvE178Hy8OxAkA1Ng spNbUC7QExVpAU3YmCjCQUafnDH/rBAJ2rCrhUAy7nnC+MwqPd1ech5dWeevRDICppkyie yO2FGSBNkRxYxI4R1kkImSH1WqeQqlt4mgGl8gysEwmDyTLLXZh8uZn0HC1srStaoEz4Od Ygh4PgxzuguDGjBSHHzthrTwwjEJjyrGNzI4H/KlnbLK2VJlhCK1n8wkvEmG2A== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4W17T65hMfzXqS for ; Fri, 14 Jun 2024 18:43:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 45EIhMG8042802 for ; Fri, 14 Jun 2024 18:43:22 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 45EIhMX1042801 for wireless@FreeBSD.org; Fri, 14 Jun 2024 18:43:22 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: wireless@FreeBSD.org Subject: [Bug 274382] iwlwifi Invalid TXQ id Date: Fri, 14 Jun 2024 18:43:21 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: wireless X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: tracking X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bz@FreeBSD.org X-Bugzilla-Flags: mfc-stable14? mfc-stable13? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-wireless List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-wireless@freebsd.org Sender: owner-freebsd-wireless@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274382 --- Comment #80 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D07da0ad63aa52999c0a381440104122a7= 70decb5 commit 07da0ad63aa52999c0a381440104122a770decb5 Author: Bjoern A. Zeeb AuthorDate: 2024-06-05 22:54:36 +0000 Commit: Bjoern A. Zeeb CommitDate: 2024-06-14 14:55:16 +0000 LinuxKPI: 802.11: make sure we can send DISASSOC or DEAUTH frames The "Invalid TXQ" error from iwlwifi seems to be triggered by a frame being sent for a sta which is no longer known to the driver/fw. While we make sure to trigger the sending of the frame in net80211 early enough (by calling (*iv_newstate)() early on rather than at the end), TX in LinuxKPI is run in a deferred task. When we drop the net80211 ic lock again and re-acquire the LHW lock the packet may not yet have made it to the driver. Work around this between the (ic and lhw) locks by making sure (a) no new packets get queued after we return from (*iv_newstate)(), and (b) the TX task has run or gets cancelled and we manually push any remaining packets out (or let lsta_free() clean them up). The disabled packet queuing now also needs to be re-enabled in scan_to_auth() in case an lsta is staying in service or gets re-used. Also make sure that any following lkpi_wake_tx_queues() calls no longer ignore queues which have not seen a prior dequeue. This former workaround "feature" (ltxq->seen_dequeue) should be fully garbage collected in a later change on its own. Sponsored by: The FreeBSD Foundation PR: 274382 Tested by: emaste, lwhsu, thj, rkoberman at gmail.com Accepted by: adrian Differential Revision: https://reviews.freebsd.org/D45508 (cherry picked from commit 886653492945f7e945eb9bdaf5bc2ae26df96236) sys/compat/linuxkpi/common/src/linux_80211.c | 95 ++++++++++++++++++++++++= +--- 1 file changed, 86 insertions(+), 9 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=