From nobody Mon Feb 19 16:10:48 2024 X-Original-To: wireless@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TdnZc4fblz5C54y for ; Mon, 19 Feb 2024 16:10:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TdnZc1Bdkz4Q7X for ; Mon, 19 Feb 2024 16:10:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708359048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hFiW8PrYbe0mAKBNKHgg87Klpukxa7rbAv5iX02ITaw=; b=nAHOviap+N7yHiWJ7f6hIW2K/bAKfYYuDFQcUD+SCESYFi904lT7UxYWw6y/Kyx+wnBwDh aTMPByttI9wwa70PcPVtJbYTFF4vp8PJh8RYzPIdGUJv2OKOITw7nxtMzT+UxWDT2TTuSO 64xYiDYLkYPAFSSa2c5Lan7DXQaDBzEXfxLn4LCi5LeFDD0BBISqJAdCRRMqFq4rqRbZmz U4I6mv5Zi6VY6KfJlmVM76dWtjmD2S6mX0RxHyCEW0bYwc8RGfNyMLSxA6bBSIDhPwqxQ/ ukvuCGMF48ypEyQEV94X12lI64p9OxjMgBPc0khKLwVUh0InTo5hPhxjhNFWyg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708359048; a=rsa-sha256; cv=none; b=KY+Ic4nf9TjDgaO+72FnSOzJ58LsaQRJRfMZ1gDsIp56bLqFsBjCau6uSSvwfNBfOjzkWZ yi1cqkG63ut3guH6Vo8mwgAHwrWrRGvli+1LgtqrimtTKSA7A/fz7U5hUqsnQ4exJsn/iy /daLW5NFoZltTtj0abSjrV6R26EfjDanzo5bJhqkX94Ihp9N7XeMv6hDx1IRFGoelS9sRL YZKKH2yPieyFXNyxN2IEjgAeLwuoeTD6k9rp7Ulj0OF4VL1uDeTEOe9g4KHAYOWfnOaM6L 4x2s1+QPw6EC+V7pnQwwh3TeKmZ/gmLWJYgFKw9nsJoDbtSPOJnGo/Ft6QvLfA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TdnZc0FmpzhdQ for ; Mon, 19 Feb 2024 16:10:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 41JGAlUd000095 for ; Mon, 19 Feb 2024 16:10:47 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 41JGAl3c000094 for wireless@FreeBSD.org; Mon, 19 Feb 2024 16:10:47 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: wireless@FreeBSD.org Subject: [Bug 263613] iwlwifi0 on framework laptop crashes (kernel panic) when setting IP Date: Mon, 19 Feb 2024 16:10:48 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bz@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-wireless List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-wireless@freebsd.org X-BeenThere: freebsd-wireless@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263613 --- Comment #43 from commit-hook@FreeBSD.org --- A commit in branch releng/13.3 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dd4b4efc6db6c6c3a9abf2f187ba1ccc0e= 40028cf commit d4b4efc6db6c6c3a9abf2f187ba1ccc0e40028cf Author: Bjoern A. Zeeb AuthorDate: 2024-02-03 16:33:56 +0000 Commit: Bjoern A. Zeeb CommitDate: 2024-02-19 16:09:22 +0000 LinuxKPI: 802.11: band-aid for invalid state changes after (*iv_update_= bss) With firmware based solutions we cannot just jump from an active session to a new iv_bss node without tearing down state for the old and bringing up the new node. This likely used to work on softmac based cards/drive= rs where one could essentially set the state and fire at will. We track (*iv_update_bss) calls from net80211 and set a local flag that we are out of synch and do not allow any further operations up the state machine until we hit INIT or SCAN. That means someone will take the st= ate down, clean up firmware state and then we can join again and build up state. Apparently this problem has been "known" for a while as native iwm(4) a= nd others have similar workarounds (though less strict) and can be equally pestered into bad states. For LinuxKPI all the KASSERTs just massively brought this problem out. The solution will be some rewrites in net802= 11. Until then, try to keep us more stable at least and not die on second join1() calls triggered by service netif start wlan0 and similar. Approved by: re (cperciva) PR: 271979, 271988, 275255, 263613, 274003 Sponsored by: The FreeBSD Foundation (2023, partial) Reviewed by: cc Differential Revision: https://reviews.freebsd.org/D43725 (cherry picked from commit 2ac8a2189ac6707f48f77ef2e36baf696a0d2f40) (cherry picked from commit 184ccc414686ea32c64f063c081c7cc1adeae7c3) sys/compat/linuxkpi/common/src/linux_80211.c | 309 +++++++++++++++++++----= ---- sys/compat/linuxkpi/common/src/linux_80211.h | 2 + 2 files changed, 216 insertions(+), 95 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=