From nobody Mon Feb 19 16:10:45 2024 X-Original-To: wireless@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TdnZb4K9qz5C58s for ; Mon, 19 Feb 2024 16:10:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TdnZb0py7z4QG9 for ; Mon, 19 Feb 2024 16:10:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708359047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xuE08ewJunBHsP9CM041VDiMR1y2vJF4MuJyxVbPgh8=; b=CGQ0vcYHRCiNKejC6+/BoQNh6JHflbhC2RZMjVNTTz/EB4rG5VzzNpnKExc+gEEaPQjjzn +OW/p2RUaB5na0cnMu+gestb10ElsxK5yeHFNxX9aon6C8vatVOYZOmQtz1NI383p2T0K5 Oc4aw6zet2hPPaIWNT2TcFjyyyua0+X2ZzI+fufZ2w1nkqmoJCXc6JEdVmOM+Wd47iWDrz FLiuKyNzkLfQlA0OtdHWu12IGx2hgPE/Gi7WNdkpBFEtqgfP4ViCpTTSwpbc8Jg+l7020i xlz+/6TvBpATU9oQTMrAGNx/A1H3ApNtOKnTqE0CqgItyKIwnzsDkt0UrvtFKg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708359047; a=rsa-sha256; cv=none; b=XmhB/pw+GXKoXKxX7LFrURdcFJWY1QUQMrZqVe+FPpXdwwtRBd4Vi2cVPfFoc+kAErMMTW 8N+1pzHQP6ESPToLn9dPGah9rp0vHkmTXZMvwVOZ0MFH5QXbrkvLjiM0dwWVFTi8D+iOEO jMCFfEVDpG2jOJOZrBhMv0kJI0IUOiQt1iJSOGNvGFdDK0nu43teUrsrXNvZmuTE94vrn2 ctqJFXxjoSPCH0OV/ROuRUsjbkjWmmD0S/fYI9cxCGbyQ6lDmKuaCWYYDHydq5A/jioHdE w8L237OR96ljiQaeS40q6hsMA1gIk/rEX4BrhJKd3OKGsIH+iJigPcGBLA6R7w== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TdnZZ72r8zhMC for ; Mon, 19 Feb 2024 16:10:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 41JGAkDu099681 for ; Mon, 19 Feb 2024 16:10:46 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 41JGAk7r099658 for wireless@FreeBSD.org; Mon, 19 Feb 2024 16:10:46 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: wireless@FreeBSD.org Subject: [Bug 274382] iwlwifi Invalid TXQ id Date: Mon, 19 Feb 2024 16:10:45 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: wireless X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: tracking X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bz@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-wireless List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-wireless@freebsd.org X-BeenThere: freebsd-wireless@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274382 --- Comment #46 from commit-hook@FreeBSD.org --- A commit in branch releng/13.3 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D401dbf9cfc0cfb2a02355d41bf73e146b= d3dfb74 commit 401dbf9cfc0cfb2a02355d41bf73e146bd3dfb74 Author: Bjoern A. Zeeb AuthorDate: 2024-02-14 21:56:48 +0000 Commit: Bjoern A. Zeeb CommitDate: 2024-02-19 16:09:22 +0000 LinuxKPI: 802.11: lsta txq locking cleanup Rename the LSTA lock to LSTA_TXQ lock as that is really what it is and put down the full set of macros. Replace the init and destroy with the macro invocation rather than direct code. Put locking around the txq_ready unset and check. Move the taskq_enqueue call under lock to be sure we do not call it anymore after txq_ready got unset. Leave a comment related to the node reference which is passed into the TX path on the recvif mbuf pointer. Approved by: re (cperciva) Fixes: 0936c648ad0ee PR: 274382 (possibly) Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D43909 (cherry picked from commit fa4e4257943650c0b5f58c01bb0bdfadea61dfb2) (cherry picked from commit 763b10806cd4ebdcbd2b6753d4f50ec088dc57fb) sys/compat/linuxkpi/common/src/linux_80211.c | 31 ++++++++++++++++++------= ---- sys/compat/linuxkpi/common/src/linux_80211.h | 14 +++++++++++-- 2 files changed, 32 insertions(+), 13 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=