From nobody Mon Feb 19 08:09:15 2024 X-Original-To: wireless@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TdZv02g1dz5B3Pp for ; Mon, 19 Feb 2024 08:09:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TdZtz3sDnz4Myt for ; Mon, 19 Feb 2024 08:09:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708330155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gmIiAQz1cZ/LEanfjum/pn7AT8qI7KBFCLdcrYirhbE=; b=fdzpKiuN+IZm+kgqCwQSFc1phdWXxIblqd9+qLdSVjZGgBE+CSNz8z4wXD9w8Z8XaDbrci 2ZNBQpyhMMavIFl8fXr1hT77J9VkwXkGw5uJrVzyxBCTcGy24eJ0Sgee48P+BURZyQFTlD Nuv+5rvztawBkTbAK8C7z2+CodQ6HJHVjH8s3Z3ONRn8Zdu8F/lNuPzcH8RjZFjJIB+/Mf 72wNuCE/lnSfqWcrmbmAdxhLsSjgO7yyYeQjuWLiE8rN0giL2MKzSaxoW6SqCqHVUaZxwh zLqrBfXK1CkxNuy6huFbCSVOgIWdx59lVwrBdEoy+cRjNr9OqTC5CAilGbKicw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708330155; a=rsa-sha256; cv=none; b=Vke/cCq33NRjooj5+KtI7Ajn579Mpk/to+XdkvJqVUI/z4ch1uHTBbZUlgVsjdOCT9zdm8 zjQC67TtWALDKCW+vtcfh/0L7W7xQRRfkxFebW3HNg+6bI1//Id1M98D21GcRXrIeCBXk+ woMcO9ZpV40L1PzgfaLox52lgWxzRiQ8XqzyVY6cRvhsfPZBC++7+vwauviWIV/GSvtB7c hWCeStXX8ryJ0Ebl7KoxsCqd7PlDrIbiC05rEagazAvTse0MKpnG4EJM/D0G1FF4Mxxtnv SXyOGB4JH9ZjgHGH/OA7K6FdmnVshF+W7DNUVuXsgg7s1jpkIFn2Em19DiqIcg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TdZtz2yxpzRWJ for ; Mon, 19 Feb 2024 08:09:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 41J89FcR062037 for ; Mon, 19 Feb 2024 08:09:15 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 41J89FbQ062031 for wireless@FreeBSD.org; Mon, 19 Feb 2024 08:09:15 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: wireless@FreeBSD.org Subject: [Bug 263613] iwlwifi0 on framework laptop crashes (kernel panic) when setting IP Date: Mon, 19 Feb 2024 08:09:15 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bz@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-wireless List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-wireless@freebsd.org X-BeenThere: freebsd-wireless@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263613 --- Comment #41 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D184ccc414686ea32c64f063c081c7cc1a= deae7c3 commit 184ccc414686ea32c64f063c081c7cc1adeae7c3 Author: Bjoern A. Zeeb AuthorDate: 2024-02-03 16:33:56 +0000 Commit: Bjoern A. Zeeb CommitDate: 2024-02-19 08:02:02 +0000 LinuxKPI: 802.11: band-aid for invalid state changes after (*iv_update_= bss) With firmware based solutions we cannot just jump from an active session to a new iv_bss node without tearing down state for the old and bringing up the new node. This likely used to work on softmac based cards/drive= rs where one could essentially set the state and fire at will. We track (*iv_update_bss) calls from net80211 and set a local flag that we are out of synch and do not allow any further operations up the state machine until we hit INIT or SCAN. That means someone will take the st= ate down, clean up firmware state and then we can join again and build up state. Apparently this problem has been "known" for a while as native iwm(4) a= nd others have similar workarounds (though less strict) and can be equally pestered into bad states. For LinuxKPI all the KASSERTs just massively brought this problem out. The solution will be some rewrites in net802= 11. Until then, try to keep us more stable at least and not die on second join1() calls triggered by service netif start wlan0 and similar. PR: 271979, 271988, 275255, 263613, 274003 Sponsored by: The FreeBSD Foundation (2023, partial) Reviewed by: cc Differential Revision: https://reviews.freebsd.org/D43725 (cherry picked from commit 2ac8a2189ac6707f48f77ef2e36baf696a0d2f40) sys/compat/linuxkpi/common/src/linux_80211.c | 309 +++++++++++++++++++----= ---- sys/compat/linuxkpi/common/src/linux_80211.h | 2 + 2 files changed, 216 insertions(+), 95 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=