From nobody Mon Apr 15 17:52:30 2024 X-Original-To: wireless@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VJFB827KMz5H2nW for ; Mon, 15 Apr 2024 17:52:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VJFB71RS0z4GP3 for ; Mon, 15 Apr 2024 17:52:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713203551; a=rsa-sha256; cv=none; b=wTZ3Yhhmp1dmavUXTMMwrgRYt57XwFxlUGWNeKGbyn+EAGgg+XdqK+F/CaApXvsmd2Tknl Kj8sJOJCvjgcfJZpPlRQCEM5Yzfd4S0TKclw71QKHzQ2cHDpjpCaULGnSjYCpCi207Ionj ZkZEj04mdlDz7uyt8f5blKQIIGmktmHuaf/96AmXfQINlBj9x2QZTgRW5ygssJS7og5T9q g9qPWciBhf0Uckr2R+6I74vXGeGYlGwSR/0T5slJA/d3iGLeFbAJbczaRr0oX0N2dUwNIZ 3kAPaX8LfyvSZGBNsOC92+uGgOEstnw0CjGJ+q+7PjNHfEX3y7cGDjFGCsWxgg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713203551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ab/07PMrg0ML/bBr0bRDQAdF2r5KdmCAtCsJgCYnmQU=; b=aodc3WozGbBwCZvIKPB5o+fSylA136KLTA98ZIb7wy23ACPoOcN/OauX63ehDn1UaaRSa2 3fInm6KhC+l+QSC7qipdb0CwyKhCEiLy9VVeh9T8eqsZZfoIwFyo6WJ3x7YpDPRVi9JEVx Glho9w0TiB1ym09p2sUtXbBkKqFivoJu88ewtr8JWiz/yMflQHCoeBt0JypEY2lCYFmYg0 AncowZPExs6QcOV/J641TYVAjqVH98M8NjAYPQVoHFVe1I+jV55pY4DvmhSQ5KY+P0vsn6 G7JbGqVxRCBkn+I7mxcv+0ftYtMgs8ZP+2Pf6wcv/rmOYGDoyCi7YfZEr8DVrw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VJFB712dlz18CR for ; Mon, 15 Apr 2024 17:52:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 43FHqVZw065451 for ; Mon, 15 Apr 2024 17:52:31 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 43FHqVt2065450 for wireless@FreeBSD.org; Mon, 15 Apr 2024 17:52:31 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: wireless@FreeBSD.org Subject: [Bug 274382] iwlwifi Invalid TXQ id Date: Mon, 15 Apr 2024 17:52:30 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: wireless X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: tracking X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bz@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-wireless List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-wireless@freebsd.org Sender: owner-freebsd-wireless@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274382 --- Comment #59 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D1665ef979d3adab05d178480077674ab5= 978e4f0 commit 1665ef979d3adab05d178480077674ab5978e4f0 Author: Bjoern A. Zeeb AuthorDate: 2024-02-16 21:14:02 +0000 Commit: Bjoern A. Zeeb CommitDate: 2024-04-15 17:44:00 +0000 LinuxKPI: 802.11: disable early queue wakeup workaround; better classify We used to call lkpi_wake_tx_queues() for all queues early on in order to make sure they are ready. Turns out whatever logic in iwlwifi startup is working correctly these days under LinuxKPI so this is no longer needed. As the comment indicated the "workaround" did not always work. Disable it for now. The second part of the improvement is to properly classify Non-QOS non-data frames (mgmt and ctl frames for now, unless we have to be even more careful in the future about certain sub-types) as TID 7/VO. Contrary to net80211 we must not promote PAE frames. PR: 274382 MFC after: 3 day Reviewed by: cc Differential Revision: https://reviews.freebsd.org/D43944 sys/compat/linuxkpi/common/src/linux_80211.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=