From nobody Thu Nov 30 06:12:08 2023 X-Original-To: freebsd-wireless@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Sgm7j4QP5z52ssd for ; Thu, 30 Nov 2023 06:12:33 +0000 (UTC) (envelope-from farhan@farhan.codes) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Sgm7h5HBbz4TQh for ; Thu, 30 Nov 2023 06:12:32 +0000 (UTC) (envelope-from farhan@farhan.codes) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=farhan.codes header.s=fm3 header.b=XfNUvN9Z; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=gJn94Qwn; spf=pass (mx1.freebsd.org: domain of farhan@farhan.codes designates 64.147.123.25 as permitted sender) smtp.mailfrom=farhan@farhan.codes; dmarc=none Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 32A133200B09 for ; Thu, 30 Nov 2023 01:12:30 -0500 (EST) Received: from imap45 ([10.202.2.95]) by compute5.internal (MEProxy); Thu, 30 Nov 2023 01:12:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=farhan.codes; h= cc:content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t=1701324749; x=1701411149; bh=g/GJ4tSdOaPgfYckFMDznFr1Q cboqykntTsSesiPnss=; b=XfNUvN9Z/2yUG513QQwkdlkve8EFc7PmGTtBC1/HZ gk6/Y+acoOQEAImasmEgmZ/0AcdDkV9C+mxIKJz1nKHJixPqeQ6OmCsDFkt7UXfd kuGm5UOjIHq5V4qXce4+iMjWOuqDP7DDCp64vmq8HX5AFFb4O6q7gm+WsMop0a2Y /L2rqv7pFRVT+9C4Y8XwYRdjLh9pokWCeJU1mrPKItOyBmYggHVMMze4FPQd0W7R mTVZXUX6wkfURcGyIzSiNaQeKrVsFOxGJ/jWHulal3wJiEOgOaUGsyTimvSqb3sN ExsKkFtPui1++M8zdmgimcccXGJl9OQM3rtU0hjn8FOhQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1701324749; x=1701411149; bh=g/GJ4tSdOaPgfYckFMDznFr1QcboqykntTs SesiPnss=; b=gJn94QwnYAxkbfAcbGaD6yYsblbfi1VotWxvn26M9oul6i2OB2T WMgk9L1HqpI7Hx+w1OQ0FORJ/IRpH7u0y+ofKJDDPZHMKZjlTfc3rFlOzdyMaWTU Nm2uchBHAHgtaKjR3IWsMW5su1GOKI9BjuX3Gyidg8Hg3JgGKh31ee0IsLSC1ire PU3hGyAsvUoxAh7lYre/kjaiWITG/zN4lhYUDyHgLC1smnHnszLtQHT0kWtntSV+ kw8xFbG9n1dkE5W+wQ40fgUpUuLWNe771KojNmzi2BLiDZCWCMjXTZaZ6K3P4Ltl XD5CX4ZqMgOuvw4j6qMvAcuQBaoYVJ25QMg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeiiedgledvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfffhffvufgtsehttdertd erredtnecuhfhrohhmpedfhfgrrhhhrghnucfmhhgrnhdfuceofhgrrhhhrghnsehfrghr hhgrnhdrtghouggvsheqnecuggftrfgrthhtvghrnhepieejtdegteevhfegvdefieeghe ethfduudffkeevffejueegudevfeffuddvheegnecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomhepfhgrrhhhrghnsehfrghrhhgrnhdrtghouggvsh X-ME-Proxy: Feedback-ID: i61914458:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 7949F272007B; Thu, 30 Nov 2023 01:12:29 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1238-g6cccb1fa34-fm-20231128.002-g6cccb1fa List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-wireless List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-wireless@freebsd.org X-BeenThere: freebsd-wireless@freebsd.org MIME-Version: 1.0 Message-Id: <629e3534-705a-4dcc-ad16-edba170da251@app.fastmail.com> Date: Thu, 30 Nov 2023 01:12:08 -0500 From: "Farhan Khan" To: freebsd-wireless Subject: Why newstate handler runs IEEE80211_LOCK/UNLOCK? Content-Type: text/plain X-Spamd-Result: default: False [-3.79 / 15.00]; DWL_DNSWL_LOW(-1.00)[messagingengine.com:dkim]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; SUBJECT_ENDS_QUESTION(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[farhan.codes:s=fm3,messagingengine.com:s=fm1]; RWL_MAILSPIKE_VERYGOOD(-0.20)[64.147.123.25:from]; R_SPF_ALLOW(-0.20)[+ip4:64.147.123.25]; RCVD_IN_DNSWL_LOW(-0.10)[64.147.123.25:from]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; DMARC_NA(0.00)[farhan.codes]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:29838, ipnet:64.147.123.0/24, country:US]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MLMMJ_DEST(0.00)[freebsd-wireless@freebsd.org]; FROM_HAS_DN(0.00)[]; DKIM_TRACE(0.00)[farhan.codes:+,messagingengine.com:+]; RCPT_COUNT_ONE(0.00)[1]; PREVIOUSLY_DELIVERED(0.00)[freebsd-wireless@freebsd.org]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_ALL(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; ARC_NA(0.00)[] X-Rspamd-Queue-Id: 4Sgm7h5HBbz4TQh X-Spamd-Bar: --- Hi all, I'm studying the implementations of net80211 and noticed that in all newstate handlers the code begins by running IEEE80211_UNLOCK(ic) and ends with IEEE80211_LOCK(ic). I was not clear on why this was, I would have expected the opposite order. Also, why not just use the softc device-wide mutex over one for ieee80211com. Overall, I do not seem to understand the intent of the unlock and am seeking clarification. Thank you, -- Farhan Khan PGP Fingerprint: 1312 89CE 663E 1EB2 179C 1C83 C41D 2281 F8DA C0DE