From nobody Tue Mar 21 14:51:57 2023 X-Original-To: freebsd-wireless@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PgvhY5777z40PSM for ; Tue, 21 Mar 2023 14:52:13 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PgvhY2FG0z3M3Z; Tue, 21 Mar 2023 14:52:13 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lj1-f176.google.com with SMTP id e21so3193334ljn.7; Tue, 21 Mar 2023 07:52:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679410331; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EHMHnQ7Ll0VZerfDciG6PYVBGGCT8ff0GWbGGr4NSUk=; b=cUPqtS/ZJV2/xj0PIYUwjKp+b2yURGRRgXW7FTMSB6NZNCBO9ivDHTBUJqWItvzqt/ hzWg7cDKfexCQ/QEkkFNpyJmQ4apwCQHYALvvjBLEwVuR4rH392UY+YxYRHSLlJKX7oR s2Nrn9jPBoivp3CjJDn8Dhtm1LKZc9N9wuA760LEQ6RqOtOxuEMo4cU9OoijB/TPXhmK Lnavx0G+pOnRVMrXnoFDkmeGIVGagMgaMQWJDgVOxhSry4XfRLqw65Nv0QR0j5KAcFTW Acn6bwaRzVLg+QcUQo8J9NvdOxZkNsU/5n48hVcxJFQ/XDts4E4WfUX5GCbo9dsMt5GP Op4w== X-Gm-Message-State: AO0yUKV3JNaRpAmJfuMoaN5h/ixqNK5kI7Z4THXUS0OZaRn4JdUfqEC+ E28EXK9x/fUdckU5cNg9mixhDyCYiljfxHYsf2Z6nLcH X-Google-Smtp-Source: AK7set8aEaUL5I6dWNKG7fKvZ6Y5gPBGgKjvuI5i7dFywG6TUiDK+OD6nxk1+MKO0Vxf/3mxuIVWQjKacYqs/1IE0Dk= X-Received: by 2002:a2e:9d44:0:b0:295:a82e:ec06 with SMTP id y4-20020a2e9d44000000b00295a82eec06mr946710ljj.3.1679410330678; Tue, 21 Mar 2023 07:52:10 -0700 (PDT) List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-wireless List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-wireless@freebsd.org X-BeenThere: freebsd-wireless@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Adrian Chadd Date: Tue, 21 Mar 2023 07:51:57 -0700 Message-ID: Subject: Re: 802.11n support for iwm(4): problem with separate BA task To: Mikhail Pchelin Cc: freebsd-wireless@freebsd.org Content-Type: multipart/alternative; boundary="00000000000031394905f76a30a0" X-Rspamd-Queue-Id: 4PgvhY2FG0z3M3Z X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --00000000000031394905f76a30a0 Content-Type: text/plain; charset="UTF-8" oooo nice! So yeah, you will need to figure out why you can't do a cancel call and have it properly cancel the task. you need to do that during vap delete / teardown because that path isn't async and thus you need them to block waiting for whatever is stopping your task cancel from succeeding. Do you have a diff available? I'd love to review it. Thanks! -adrian --00000000000031394905f76a30a0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


oooo nice!
So yeah, you will need to figure out why you can't do a ca= ncel call and have it properly cancel the task. you need to do that during = vap delete / teardown because that path isn't async and thus you need t= hem to block waiting for whatever is stopping your task cancel from succeed= ing.

Do you have a diff available? I'd love to= review it.

Thanks!


<= /div>
-adrian

--00000000000031394905f76a30a0--