From nobody Tue Jul 11 14:27:50 2023 X-Original-To: freebsd-wireless@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R0js45DYLz4gr2J for ; Tue, 11 Jul 2023 14:28:08 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4R0js40Xwlz4JRb for ; Tue, 11 Jul 2023 14:28:08 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20221208 header.b=BkvKpf0X; spf=pass (mx1.freebsd.org: domain of adrian.chadd@gmail.com designates 2a00:1450:4864:20::135 as permitted sender) smtp.mailfrom=adrian.chadd@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4fba74870abso8679324e87.0 for ; Tue, 11 Jul 2023 07:28:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689085685; x=1691677685; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Qrk+XJpj1r74uIeGuzBC/L1Zz38Dg2D47tVzlQ9CRr8=; b=BkvKpf0Xs14rG19qkeucFp08zDS5LHAzwICV7x4Eu6ab2ry2IX4MrLhmErZRI0Fi5d EPf51876zoV5m6e6GF4PJaJrshWGBEciAu9y4TUt3ii2mVRK4GeeLUIODzeLx+B8jt9o KeEKiy/fIsTBjQY9lXBRdTZYhzDJrJ1PTZ/kOWD6+jEfrq62k5p8BSMUB9EXh1/UUZu+ UHZ0SRYW4dpzdJcrzywZlI0YerMmo3g/dgF9Z9PINENKbu8Ye/IedmN7fuNpKJWjewx8 2MzW6AAmm0JQtcFA3PyZD0DOjnpbjFvdV8DIq5wJ7uFEEp3MC7hoOXADW12VSeVx1hSR JAMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689085685; x=1691677685; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qrk+XJpj1r74uIeGuzBC/L1Zz38Dg2D47tVzlQ9CRr8=; b=Vi3WUaFs1rNRJtKx4zFOM/bewWXYzke/zNwtgTcTPPGEr+Kg9m1CrtkgNlls9vOsxW TXmBuvpSH5Mi/vqdehIxT1uUd1uQIhJs4WEM7E0qm7u8EYmvLqup8fI8PlWWwmMB8ONv YLef4ZZrEELP+QsK0C4KZA6kPnYk8RENSV2OA4fZ97lDFaWZJjF7/JQJTPx/CanyGC4u EbmrbLm60VGXp6SqCz/zTxUHvU1hSsNwshYMeidtq7ZAiqR1X54MdWokc88oy9hY9aI0 ibBLq6+KyztiEkY2Oa+JXV2gREEzGjW+8YntFWssFi9Puy09xdsS02lwGvgZGgvi19Ey Nj5A== X-Gm-Message-State: ABy/qLaJ80VWMT237ncFJ1Noa4Ign4f9jirrf+9eUITtT2OADqSO/3YK VWIpGfaLbddj43PFW8M6Ap5KXiCnJKlh8MukFSx7NobA X-Google-Smtp-Source: APBJJlHBEg5dYvHdw8AYjqT6Wd+yuQKW5y/+qrjoCRG/mUpvGTb9pt+vwZgy1BrLWqo1QG+ChGOCVQXIuqlMETmUZ0M= X-Received: by 2002:a19:5f5d:0:b0:4f9:607a:6508 with SMTP id a29-20020a195f5d000000b004f9607a6508mr12687230lfj.50.1689085684432; Tue, 11 Jul 2023 07:28:04 -0700 (PDT) List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-wireless List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-wireless@freebsd.org X-BeenThere: freebsd-wireless@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Adrian Chadd Date: Tue, 11 Jul 2023 07:27:50 -0700 Message-ID: Subject: Re: 802.11n TX ADDBA request supported? To: =?UTF-8?B?5ZCz5oGp57ev?= Cc: freebsd-wireless@freebsd.org Content-Type: multipart/alternative; boundary="000000000000374620060036e8b4" X-Spamd-Result: default: False [-2.48 / 15.00]; SUBJECT_ENDS_QUESTION(1.00)[]; NEURAL_HAM_MEDIUM(-0.98)[-0.979]; NEURAL_HAM_LONG(-0.85)[-0.851]; NEURAL_HAM_SHORT(-0.65)[-0.654]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20221208]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-wireless@freebsd.org]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::135:from]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; MLMMJ_DEST(0.00)[freebsd-wireless@freebsd.org]; DKIM_TRACE(0.00)[gmail.com:+]; MID_RHS_MATCH_FROMTLD(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; TAGGED_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4R0js40Xwlz4JRb X-Spamd-Bar: -- X-ThisMailContainsUnwantedMimeParts: N --000000000000374620060036e8b4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable hi! So, ampdu_request doesn't send addba itself. It calls ic_send_action because some NICs want a firmware message to start AMPDU, not sending frames. Look at what ath(4) is doing. It registers for ic_send_action and that sends the actual frames. mwl(4) (an old 11n marvell chipset, the first with freebsd 11n support) instead uses a firmware message. -adrin On Tue, 4 Jul 2023 at 01:03, =E5=90=B3=E6=81=A9=E7=B7=AF wrote: > Hi, > > I'm working on 14.0-CURRENT, and I found that it seems net80211(4) lack o= f > supporting 802.11n/e TX ADDBA request: > When we call `ieee80211_ampdu_request()`, then the function ends up > calling `ic->ic_send_action` (`ieee80211_send_action()`) with category > `IEEE80211_ACTION_CAT_BA` and action `IEEE80211_ACTION_BA_ADDBA_REQUEST`. > But then `ieee80211_send_action()` call the dummy function `send_inval()` > which does nothing. So net80211(4) doesn't send ADDBA requests for us. > > The same thing happens when RX an ADDBA request, net80211(4) doesn't repl= y > an ADDBA response to the transmitter. The only thing I found is that > net80211(4) has the `ieee80211_send_bar()` which does send BA requests > (which is not ADDBA request) for us. I wonder if there is something I'm > missing or if the "TX/RX ADDBA request/response" is handling most in > driver/firmware? > > Additionally, if I would like to test the 802.11n part in net80211(4), > which driver/device is suggested to use? Thanks. > --000000000000374620060036e8b4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
hi!

So, ampdu_request doesn't send = addba itself. It calls ic_send_action because some NICs want a firmware mes= sage to start AMPDU, not sending frames.

Look at w= hat ath(4) is doing. It registers for ic_send_action and that sends the act= ual frames.

mwl(4) (an old 11n marvell chipset, th= e first with freebsd 11n support) instead uses a firmware message.


-adrin


On Tue, 4 Jul 20= 23 at 01:03, =E5=90=B3=E6=81=A9=E7=B7=AF <rickywu0421@gmail.com> wrote:
Hi,

I'm workin= g on 14.0-CURRENT, and I found that it seems net80211(4) lack of supporting= 802.11n/e TX ADDBA request:
When we call `ieee80211_ampdu_request()`, t= hen the function ends up calling `ic->ic_send_action` (`ieee80211_send_a= ction()`) with category `IEEE80211_ACTION_CAT_BA` and action `IEEE80211_ACT= ION_BA_ADDBA_REQUEST`. But then `ieee80211_send_action()` call the dummy fu= nction `send_inval()` which does nothing. So net80211(4) doesn't send A= DDBA requests for us.

The same thing happens when RX an ADDBA reques= t, net80211(4) doesn't reply an ADDBA response to the transmitter. The = only thing I found is that net80211(4) has the `ieee80211_send_bar()` which= does send BA requests (which is not ADDBA request) for us. I wonder if the= re is something I'm missing or if the "TX/RX ADDBA request/respons= e" is handling most in driver/firmware?

Additionally, if I woul= d like to test the 802.11n part in net80211(4), which driver/device is sugg= ested to use? Thanks.=C2=A0
--000000000000374620060036e8b4--