From nobody Tue Jan 10 09:31:18 2023 X-Original-To: wireless@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Nrltb0TTJz2rD6k for ; Tue, 10 Jan 2023 09:31:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NrltZ5StJz4Py3 for ; Tue, 10 Jan 2023 09:31:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1673343078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZwYM8ZBBNsjd+KuTyVgM/xlCZxyRP6ZUFkbsK/AuuDc=; b=cxAir4rSJmTlu9IGxIT38R+PBJWoWNLE5gLLfa7S4INncoILD+YMdGltWeyX1rJTPHPfjq oFz+6YrH8hWFzsBUyRPFmgmi1yC2cb2O+0AVuSmQhevK76Gk1bkvWvILvB8dY0MwLhcIqZ Eb+8bZGclKQ49cUNN0JIpBPycCtxmh63nR5dsKK9gDnSFsqwzUZNY3qK9un2AYfvcL0GTJ ebhqHs/xX5BtQU5hKvqWiy42CtwaKmTHeo4UrK6pDk64teEvMHRgTXxkvXOgEyGh0V3Jil C0rqacNjxI+x0inK2R0xeflYedrlzn90zazRSZEoPPnWwL7vu5QCmByETdEYtA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1673343078; a=rsa-sha256; cv=none; b=XbsQUa8M5tY/YbySu+7t7wHfJ+Bo5tfrwR/IaBTFSSgK4e02MHngDDqcnwKOLNJrkaRWjx yWIVVx1O7TlPiaPZj/CYzdaHhISgSoeCtiNGVU4GU9+2Zkmqew53s1eIFabYD5Ldi08ndY yqb0o0Z4icDavWHvcnhwwzMreaOR+pgSrUAc56+lq+A1z0qI1VRsNKG+lUtlC2o8tODCZN rT8G4Ln4nwZHI60fc6CAs4Hs4cw/6H3QsQZDxZQJo9FW6SPkf2AtCRQpeHw3KlMawnVClx qL7SJPIAJjBTesmDI0FEkMOZ0H8oouFFa8MzmvqcN2dWuKsyo0UzfzRvZPqIzQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NrltZ4X4lz13rg for ; Tue, 10 Jan 2023 09:31:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 30A9VIA2043604 for ; Tue, 10 Jan 2023 09:31:18 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 30A9VIQQ043603 for wireless@FreeBSD.org; Tue, 10 Jan 2023 09:31:18 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: wireless@FreeBSD.org Subject: [Bug 268565] panic after "killall wpa_supplicant" followed by "/etc/rc.d/netif start" with rtw880 Date: Tue, 10 Jan 2023 09:31:18 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: wireless X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: misha@freebsd.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: wireless@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-wireless List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-wireless@freebsd.org X-BeenThere: freebsd-wireless@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D268565 Mikhail Pchelin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #239027|0 |1 is obsolete| | --- Comment #5 from Mikhail Pchelin --- Created attachment 239374 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D239374&action= =3Dedit patch v3 Next attempt to fix the panic. Thinking about it more, I must agree that fixing lsta in xmit function is wrong. Panic occurs while transiting from INIT state to SCAN, currently this transition is not handled in a special way, the handler is lkpi_sta_state_do_nada(), which is a stub. I suggest to check for lsta existence in the new handler and allocating it, if it's not set. INIT->SCAN also happens on boot, but in that case we also create a VAP, so = lsta allocation is handled in that chain, so there is no crash. Opinions? --=20 You are receiving this mail because: You are the assignee for the bug.=