From nobody Sun Feb 05 19:59:18 2023 X-Original-To: wireless@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P90bB327zz3kmtM for ; Sun, 5 Feb 2023 19:59:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P90bB0X5dz4P5G for ; Sun, 5 Feb 2023 19:59:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675627158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1cpLk6YGUTimIifTxNb7XRyARDZFSxCEMBRirqppIFU=; b=CXbk6S31yzEkGoutSMuoyJzKgHQ5StqL0Ku2rCz74J6vBo519YvmaCkfW3MuNFSXwdb/ZH L3e1HRFptk0HnkaqzbfS9JgWys9S6uazaYSe/d1TpTRi1MYc8hPriR4Qa8NE2HlW3dps71 sn7kJ2d6/xeUuSEtmMGLq4IyCod4mql9BbQEkiVWUyL4tJoG7xUexrkgkwKH1T39R/ybEr 1TbcJC1Q6m/1VW1sNLQohfSm0osHaqwnf3sY37oVmopYffvxoTuUm44UaA+u/J3aygLaQk kPTNnD/Wnk+Eol4rur7wM6zIDA17EPP0OpTXhuYHUbCIsgD8EP0ZLgidxxiL3A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675627158; a=rsa-sha256; cv=none; b=FE2s5pzXTtwD/znTIXOmuWaiKMbACwldRnlFbljOzQdFxuCrXP6StcXsAfMopZ4KSNv8SJ BxqDTKU8u1WHZaBk/Vyzc8obewguLEwb8rEVFqLpBkfeg0TLin9rM7pTCd2VrFBRyDrYKb MkOZrQGNJxH6MBAn7qNLC07fZav/ecTdz5XF2Dc7zqPcICdKAVrBCxLQkZ7+IgB8XTVOoT cR2Ag9hfUU7jqGawSb4X5WAsPfYitUQKekUVankmsiupTxqBXCq/2HalSvZRvpd+MO5LNX BMqBm3OXxd6hC7QOMV8M5dpSWBXGHsfC50SBHSWnDWZ1U5RgVbrN2e2dc4m5eg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P90b96Pnqz16TY for ; Sun, 5 Feb 2023 19:59:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 315JxHeO029178 for ; Sun, 5 Feb 2023 19:59:17 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 315JxHjt029177 for wireless@FreeBSD.org; Sun, 5 Feb 2023 19:59:17 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: wireless@FreeBSD.org Subject: [Bug 269347] 802.11 mesh peer can overrun b[] in mesh_decap() Date: Sun, 05 Feb 2023 19:59:18 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: wireless X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rtm@lcs.mit.edu X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: wireless@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.mimetype attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-wireless List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-wireless@freebsd.org X-BeenThere: freebsd-wireless@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269347 Bug ID: 269347 Summary: 802.11 mesh peer can overrun b[] in mesh_decap() Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: wireless Assignee: wireless@FreeBSD.org Reporter: rtm@lcs.mit.edu Attachment #239928 text/plain mime type: Created attachment 239928 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D239928&action= =3Dedit generate an 802.11 mesh packet that causes an overrun of b[] in mesh_decap() mesh_decap(..., int hdrlen, ...) says: uint8_t b[sizeof(struct ieee80211_qosframe_addr4) + sizeof(struct ieee80211_meshcntl_ae10)]; ...; memcpy(b, mtod(m, caddr_t), hdrlen); sizeof(b) is 50. However, the hdrlen that mesh_input() passes to mesh_decap() can be as large as 56, so memcpy() overruns b[]. This happens if the packet's "ae" here in mesh_input() is 3: mc =3D (const struct ieee80211_meshcntl *) (mtod(m, const uint8_t *) + hdrspace); ae =3D mc->mc_flags & IEEE80211_MESH_AE_MASK; meshdrlen =3D sizeof(struct ieee80211_meshcntl) + ae * IEEE80211_ADDR_LEN; hdrspace +=3D meshdrlen; I've attached a demo: # cc wtap18a.c # ./a.out ... panic: stack overflow detected; backtrace may be corrupted panic() at panic+0x2a __stack_chk_fail() at __stack_chk_fail+0x14 mesh_decap() at mesh_decap+0x354 mesh_input() at mesh_input+0x770 .LBB2_17() at .LBB2_17+0x34 taskqueue_run_locked() at taskqueue_run_locked+0x96 taskqueue_thread_loop() at taskqueue_thread_loop+0x62 fork_exit() at fork_exit+0x80 fork_trampoline() at fork_trampoline+0xa --=20 You are receiving this mail because: You are the assignee for the bug.=