From nobody Sat Feb 04 14:08:36 2023 X-Original-To: wireless@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P8Ds11QC6z3nS2y for ; Sat, 4 Feb 2023 14:08:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P8Ds06Fm4z3rVS for ; Sat, 4 Feb 2023 14:08:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675519716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XYdohg5jULhsBDDeA8QeCjBfTiP4nnEbZgJH1t85rno=; b=LjbexKVYXxeiWQCH6cWpF3rbaUTlKvtilJtbTo774pHwiPgUkeozUf1nuHk2B9lHFvmySj NsHza4t2VsAPJqM+ZmkFkXTcV4RJ+EwFEO/4vhEnqFHHmtQx5SfoluMhAcWqYGRwLRRpDv 70YwBoVUOWgE/1izl9qXA4XtqpPdtnUrDNhX6lbHKsyMEJozpa/NOXOEkmWqUQtBv93eMD WK0M/9JL276RWs122qsF7EsIhI7FyFAFcOeeV18Zbh9oMPLSJgIg+aiXdNe3pjpiaWCbBh SYK3Uz6t9BfktFDDwp8B4MscSdhrItbXA1Njh3GVFmdF0M3tDBpwjhrW52Jfug== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675519716; a=rsa-sha256; cv=none; b=GaPJKJAIgeb1RZ7xcHP706gkBL/dHDJ81e5frm/z9ZvqwPpll13kz+7eDEAVKXAUeh3E3Z hECFVuhyJnXXpXCHq6ziVe9h2PFmmDbigBOhfkLu08uQiyi3n1r3mKTOBqpf3bOsEm7o2q IN1Z0OLMGHZvJmEP2W3QvBUQtE/MpGCChKudY+yMzppArQJc/Hp0WzGU28U9xirt1g1tGW 1R9QMh9pxGmGEmt8W2wKoemxw8DqmnXpE1E7q3xIvLh+8kzdf2KuwTUwpc+qy7zYmd8ccd 77cIZovSVlyHBLbRoFEAJMKI0Is5ZEswCgFyKhiUeS1Dsi7jG81c26Yq8Yw9hw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P8Ds05JrnzHgn for ; Sat, 4 Feb 2023 14:08:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 314E8aPE039490 for ; Sat, 4 Feb 2023 14:08:36 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 314E8a9h039489 for wireless@FreeBSD.org; Sat, 4 Feb 2023 14:08:36 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: wireless@FreeBSD.org Subject: [Bug 269321] kernel page fault in ieee80211_scan_copy_ssid() if sr_nssid = -1 Date: Sat, 04 Feb 2023 14:08:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: wireless X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rtm@lcs.mit.edu X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: wireless@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.mimetype attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-wireless List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-wireless@freebsd.org X-BeenThere: freebsd-wireless@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269321 Bug ID: 269321 Summary: kernel page fault in ieee80211_scan_copy_ssid() if sr_nssid =3D -1 Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: wireless Assignee: wireless@FreeBSD.org Reporter: rtm@lcs.mit.edu Attachment #239900 text/plain mime type: Created attachment 239900 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D239900&action= =3Dedit crash by passing sr_nssid=3D-1 to ioctl SIOCS80211 IEEE80211_IOC_SCAN_REQ If an SIOCS80211 / IEEE80211_IOC_SCAN_REQ ioctl sets sr_nssid to -1, eventually ieee80211_scan_copy_ssid() runs memcpy(ss->ss_ssid, ssids, nssid * sizeof(ssids[0])); which crashes. The code has sanity-checks like if (nssid > IEEE80211_SCAN_MAX_SSID) { // error but nssid is often declared to be int, and there's no check for < 0. I've attached a demo, which yields: # cc wlanctl2a.c # ./a.out panic: vm_fault_lookup: fault on nofault entry, addr: 0xffffffc073570000 panic() at panic+0x2a vm_fault_lookup() at vm_fault_lookup+0x1bc vm_fault() at vm_fault+0x9c vm_fault_trap() at vm_fault_trap+0x66 page_fault_handler() at page_fault_handler+0x17a do_trap_supervisor() at do_trap_supervisor+0x74 cpu_exception_handler_supervisor() at cpu_exception_handler_supervisor+0x70 --- exception 15, tval =3D 0xffffffc073570000 memcpy() at memcpy+0xf8 ieee80211_scan_copy_ssid() at ieee80211_scan_copy_ssid+0x4e ieee80211_swscan_check_scan() at ieee80211_swscan_check_scan+0x6e ieee80211_check_scan() at ieee80211_check_scan+0x168 ieee80211_scanreq() at ieee80211_scanreq+0x2b8 ieee80211_ioctl_scanreq() at ieee80211_ioctl_scanreq+0x6e ieee80211_ioctl_set80211() at ieee80211_ioctl_set80211+0x9b8 ieee80211_ioctl() at ieee80211_ioctl+0x30e ifioctl() at ifioctl+0x318 soo_ioctl() at soo_ioctl+0x2d8 fo_ioctl() at fo_ioctl+0xa kern_ioctl() at kern_ioctl+0x242 sys_ioctl() at sys_ioctl+0x120 syscallenter() at syscallenter+0xec ecall_handler() at ecall_handler+0x18 do_trap_user() at do_trap_user+0xf6 cpu_exception_handler_user() at cpu_exception_handler_user+0x72 --=20 You are receiving this mail because: You are the assignee for the bug.=