From nobody Mon Nov 28 18:20:21 2022 X-Original-To: freebsd-wireless@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NLYgB28pbz4jXb8 for ; Mon, 28 Nov 2022 18:20:38 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NLYgB00hZz4JqX; Mon, 28 Nov 2022 18:20:38 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lj1-f177.google.com with SMTP id r8so14115708ljn.8; Mon, 28 Nov 2022 10:20:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M81+mJQgNLwCL5RhlyBr0z6n+H23B5lO0eM3xHIKKFg=; b=nUC4puFKGOlGjJfvbzhyr/vicQ+T3Yw++AO3qvCPF/uztTzzJJK9yxCzLXHKb7wULx 30dbAy1Wk52+vFOc5pmQ2HISRz7dic5sXLkg22Umcq9vGoo6Pfn1ArP+YaslkHA6xbQH buksmW604D2+4yMn8HJGiO2z2xbJlI8ghHl2jpjo1TpDVG8jQ2a2pF7x5hSC6Xfb9wxX 0UnJ6oq3iFI40z/FujI1Trw4pJ8OayFNhdQHJ/7msvq8pYEY5/JpmqbFxOkopwROSKM1 hV7uoo1LBZmxguMM7V3V4jOZXyU/My4WAO7zkbi6mug5TIKTqAXNwdF6/S7WcxMbt8y+ MI2g== X-Gm-Message-State: ANoB5pm1UNhGGm1Mlon2sUqHpr1ivBALWE2rdvmKLZyEPeMr7hCfK3VS 487yiXI6DA4Xp9jN2/FMWOJJNMdss8ugj6vfkodINREX X-Google-Smtp-Source: AA0mqf5APJuHtko+0HqD4eUODPZSwnVSAo9Je6wctB7sM6C0yb+rCFChUQDdWUhs8GijJrpjY82aLNTTasHxiPb5MIs= X-Received: by 2002:a2e:968d:0:b0:279:7d19:73d3 with SMTP id q13-20020a2e968d000000b002797d1973d3mr8662452lji.211.1669659635325; Mon, 28 Nov 2022 10:20:35 -0800 (PST) List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-wireless List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-wireless@freebsd.org X-BeenThere: freebsd-wireless@freebsd.org MIME-Version: 1.0 References: <5oosrpn9-rpp-337-8439-sq562ns60s4@serrofq.bet> In-Reply-To: <5oosrpn9-rpp-337-8439-sq562ns60s4@serrofq.bet> From: Adrian Chadd Date: Mon, 28 Nov 2022 10:20:21 -0800 Message-ID: Subject: Re: IEEE80211_DEBUG_REFCNT breaks drivers To: "Bjoern A. Zeeb" Cc: freebsd-wireless@freebsd.org Content-Type: multipart/alternative; boundary="00000000000075a1a205ee8bed37" X-Rspamd-Queue-Id: 4NLYgB00hZz4JqX X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --00000000000075a1a205ee8bed37 Content-Type: text/plain; charset="UTF-8" On Mon, 28 Nov 2022 at 09:20, Bjoern A. Zeeb wrote: > On Mon, 28 Nov 2022, Adrian Chadd wrote: > > > On Mon, 28 Nov 2022 at 08:15, Bjoern A. Zeeb wrote: > > > >> Hi, > >> > >> adding IEEE80211_DEBUG_REFCNT to a kernel config breaks various wireless > >> driver builds as they do not include opt_wlan.h and thus get the other > >> incarnation of various functions (with different argument count) from > >> ieee80211_node.h . > >> > > > > Ugh. :-) Yeah, that whole binary ABI change thing sucks. > > > > Yeah, drivers should be including opt_wlan.h. I had a chat with warner > > about this years ago and IIRC the thought was that we shouldn't have > > /binary ABI/ changes because of opt_XXX.h flags that aren't global.. but > I > > don't know how many people care about things at that level now? > > The alternative would be to: > > (a) not rename the functions (I'd actually like that) > and > (b) to always pass __func__ and __LINE__ in as arguments but mark them > __unused in the non-IEEE80211_DEBUG_REFCNT case. > > That could also solve this particular problem. Any take on that road? > Yeah I like that. -adrian --00000000000075a1a205ee8bed37 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, 28 Nov 2022 at 09:20, Bjoern = A. Zeeb <bz@freebsd.org> wrote:=
On Mon, 28 Nov = 2022, Adrian Chadd wrote:

> On Mon, 28 Nov 2022 at 08:15, Bjoern A. Zeeb <bz@freebsd.org> wrote:
>
>> Hi,
>>
>> adding IEEE80211_DEBUG_REFCNT to a kernel config breaks various wi= reless
>> driver builds as they do not include opt_wlan.h and thus get the o= ther
>> incarnation of various functions (with different argument count) f= rom
>> ieee80211_node.h .
>>
>
> Ugh. :-) Yeah, that whole binary ABI change thing sucks.
>
> Yeah, drivers should be including opt_wlan.h. I had a chat with warner=
> about this years ago and IIRC the thought was that we shouldn't ha= ve
> /binary ABI/ changes because of opt_XXX.h flags that aren't global= .. but I
> don't know how many people care about things at that level now?
The alternative would be to:

(a) not rename the functions (I'd actually like that)
and
(b) to always pass __func__ and __LINE__ in as arguments but mark them
__unused in the non-IEEE80211_DEBUG_REFCNT case.

That could also solve this particular problem.=C2=A0 Any take on that road?=

Yeah I like that.

=


-adrian

--00000000000075a1a205ee8bed37--