From nobody Mon Nov 28 17:20:38 2022 X-Original-To: freebsd-wireless@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NLXL446sfz4jQCb for ; Mon, 28 Nov 2022 17:20:44 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NLXL43fNjz41vD; Mon, 28 Nov 2022 17:20:44 +0000 (UTC) (envelope-from bz@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1669656044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wJjD/Q7uyjS+jotQTvepEWVVtB8dAoVZm72ddxd0YRY=; b=m3aBRw6u+3Z3SjaCtB+Qqs5JYHJxtcoEXAL0k6f0z9iFjepaSW4+ltWhnrHzG8ZlE169t3 3QPkGUITmztIWTAEKMdO9QFqQD8Z9Lyr81gBBMOlQsLKN9//zg9iV59Q6n2zrGJW7LfoLj Fvo5vZdCP9niT5WI50cwnXIV2Ww4U19tjREShUCL9QzoLgcRsZ75nvwogMz/CokuzaGiOU HYQ19z1RTlQ+j01O4lA4Z36Fj2Om0mOG3P7Ub+38IsCO8ymPw1C6Pu1mwt7+bpRIWILJNh u0eisMoDY7ZZoA0xppuMQVU5WgSe/xpBDuwB0yJ8jGisq6be61gDYHX10oK/sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1669656044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wJjD/Q7uyjS+jotQTvepEWVVtB8dAoVZm72ddxd0YRY=; b=m29jYxSfKZZgILQkeW96aqVJ/z/K3UkISuwSgvtQZN4FwROI/ZKj1Uvgc2oFnDpaVBr6L2 g3yZcpLa9b/f86yHyJfLlkmwN2hh5oWolj87g/c+FzoVG3usHSkcC4WLqndMthS78L7esb /AzLw/HglMtN3OHW+9CsVeHD+0SNtTwizO9WGF2kUiM+rSoMzBe8yTAzJd5dDD/1AgEadx 79setvxRM7D0DPYIfK6D3MRHpm32hnhIv1T+cbtZRnYx1RTdl14yYw+MQteiRMc7SdLUdV 98DJkxqcZEEHlZtUqewq884eY1csqBuFZE2KbUP/LAMNneLSv5WMoEQsWBATtQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1669656044; a=rsa-sha256; cv=none; b=cKCfHve/MfxlbcLD8aaUn8igqU+hrsGMFPdKtThm2HT56mWzKZpVuBpPPiIiCG8YKvhW9o GB/4e46LlV/WQ4fg8QG+iE4dcjdfS1Aa8wmITkiulAJYAnm+634SHedg3AsKk0M0JT8u7u yKBTxa3HFSpi4u3g2XUvNoF1tXcpc7eNt+tZSgPplocHfEKVxIatuH5mBXqYkzaXd8JXPW mwQNIth3MVqaw2/99+R1maOjW38Cx4PJgZv2iUNKvNsq9lWlryWyoFlmNM8joDtjAf8NQG YpgT4xQakSPjoanPvwF4mSVBh0sh7W7aNqaunlygEuBdMfEbQSHbKv95kkTivw== Received: from mx1.sbone.de (cross.sbone.de [195.201.62.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4NLXL41sDvz19vp; Mon, 28 Nov 2022 17:20:44 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 823908D4A214; Mon, 28 Nov 2022 17:20:40 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id DF77F5C3A833; Mon, 28 Nov 2022 17:20:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id OTOI6G1suvsP; Mon, 28 Nov 2022 17:20:39 +0000 (UTC) Received: from strong-iwl0.sbone.de (strong-iwl0.sbone.de [IPv6:fde9:577b:c1a9:4902:b66b:fcff:fef3:e3d2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 064F35C3A830; Mon, 28 Nov 2022 17:20:38 +0000 (UTC) Date: Mon, 28 Nov 2022 17:20:38 +0000 (UTC) From: "Bjoern A. Zeeb" To: Adrian Chadd cc: freebsd-wireless@freebsd.org Subject: Re: IEEE80211_DEBUG_REFCNT breaks drivers In-Reply-To: Message-ID: <5oosrpn9-rpp-337-8439-sq562ns60s4@serrofq.bet> References: X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-wireless List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-wireless@freebsd.org X-BeenThere: freebsd-wireless@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-ThisMailContainsUnwantedMimeParts: N On Mon, 28 Nov 2022, Adrian Chadd wrote: > On Mon, 28 Nov 2022 at 08:15, Bjoern A. Zeeb wrote: > >> Hi, >> >> adding IEEE80211_DEBUG_REFCNT to a kernel config breaks various wireless >> driver builds as they do not include opt_wlan.h and thus get the other >> incarnation of various functions (with different argument count) from >> ieee80211_node.h . >> > > Ugh. :-) Yeah, that whole binary ABI change thing sucks. > > Yeah, drivers should be including opt_wlan.h. I had a chat with warner > about this years ago and IIRC the thought was that we shouldn't have > /binary ABI/ changes because of opt_XXX.h flags that aren't global.. but I > don't know how many people care about things at that level now? The alternative would be to: (a) not rename the functions (I'd actually like that) and (b) to always pass __func__ and __LINE__ in as arguments but mark them __unused in the non-IEEE80211_DEBUG_REFCNT case. That could also solve this particular problem. Any take on that road? -- Bjoern A. Zeeb r15:7