From nobody Mon Nov 28 17:17:05 2022 X-Original-To: freebsd-wireless@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NLXGB17qdz4jPgc for ; Mon, 28 Nov 2022 17:17:22 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NLXG963Ddz40vK; Mon, 28 Nov 2022 17:17:21 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lf1-f41.google.com with SMTP id f13so18441379lfa.6; Mon, 28 Nov 2022 09:17:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=h3lm+CUzwWU3eNAFm1QyQTRqyRWHeAWeDxG+439WtnI=; b=oo/Rz0Bv4wtfr5x2zH4j7DW0lyEJanrKs3/LjkXVBZ4ijA9CJ3JcL4y5INOr4caRuD mT7G60UnPm0+tYNeRX2Oyzu4usd+V9oPdRrWTtXkiQjSidYjiY97sZ3GX0vcIH5LL5ZP Lc3JxYihUTC7BlSdTttTx6RF2vNqoDcYzLwPSdKg2dPbJh6LAog7wTqu1wtAeBvFh/I3 sttpg/st62P5oI42tHP2wpIkYJIwDG6Qt8vA1gx+nCVTlBFW9RbqMYt+JJR1NomIw92z QNGsUx3g34ST9MdC+apCbjeLFJSWIX7fAs3Ah4C/N9Ei4QesHJa0UhkIAPgl0IgH3QGl QyCQ== X-Gm-Message-State: ANoB5plkMBZo8Y2xLGOxYy/ixxPNOa80+uVDQ1DA/zZZZVga0R/0hJ8y EViI4SbSHDAoToF94kBN1ouHhhB0hzsPwTEeSdZpa3q4 X-Google-Smtp-Source: AA0mqf7bcmg4M4Owk8/AXQjSMQZxbB3fHKQSErIorBPx9uS9o7zzonyFlBzFmeG84MDxMth0jJoFk4eaolKTG//B0GI= X-Received: by 2002:a05:6512:1508:b0:4a2:4b01:8466 with SMTP id bq8-20020a056512150800b004a24b018466mr19345982lfb.34.1669655837668; Mon, 28 Nov 2022 09:17:17 -0800 (PST) List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-wireless List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-wireless@freebsd.org X-BeenThere: freebsd-wireless@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Adrian Chadd Date: Mon, 28 Nov 2022 09:17:05 -0800 Message-ID: Subject: Re: IEEE80211_DEBUG_REFCNT breaks drivers To: "Bjoern A. Zeeb" Cc: freebsd-wireless@freebsd.org Content-Type: multipart/alternative; boundary="00000000000019fb5905ee8b0b8e" X-Rspamd-Queue-Id: 4NLXG963Ddz40vK X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --00000000000019fb5905ee8b0b8e Content-Type: text/plain; charset="UTF-8" On Mon, 28 Nov 2022 at 08:15, Bjoern A. Zeeb wrote: > Hi, > > adding IEEE80211_DEBUG_REFCNT to a kernel config breaks various wireless > driver builds as they do not include opt_wlan.h and thus get the other > incarnation of various functions (with different argument count) from > ieee80211_node.h . > Ugh. :-) Yeah, that whole binary ABI change thing sucks. Yeah, drivers should be including opt_wlan.h. I had a chat with warner about this years ago and IIRC the thought was that we shouldn't have /binary ABI/ changes because of opt_XXX.h flags that aren't global.. but I don't know how many people care about things at that level now? -adrian --00000000000019fb5905ee8b0b8e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, 28 Nov 2022 at 08:15, Bjoern = A. Zeeb <bz@freebsd.org> wrote:=
Hi,

adding IEEE80211_DEBUG_REFCNT to a kernel config breaks various wireless driver builds as they do not include opt_wlan.h and thus get the other
incarnation of various functions (with different argument count) from
ieee80211_node.h .

Ugh. :-) Yeah, that = whole binary ABI change thing sucks.

Yeah, drivers= should be including opt_wlan.h. I had a chat with warner about this years = ago and IIRC the thought was that we shouldn't have /binary ABI/ change= s because of opt_XXX.h flags that aren't global.. but I don't know = how many people care about things at that level now?



-adrian

--00000000000019fb5905ee8b0b8e--