From nobody Fri Sep 08 15:06:17 2023 X-Original-To: freebsd-virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rhzw52W7rz4sLvc; Fri, 8 Sep 2023 15:06:29 +0000 (UTC) (envelope-from freebsd@igalic.co) Received: from mail-4018.proton.ch (mail-4018.proton.ch [185.70.40.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "protonmail.com", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rhzw31KHDz3VNp; Fri, 8 Sep 2023 15:06:27 +0000 (UTC) (envelope-from freebsd@igalic.co) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=igalic.co header.s=protonmail2 header.b=AvtwKLFk; spf=pass (mx1.freebsd.org: domain of freebsd@igalic.co designates 185.70.40.18 as permitted sender) smtp.mailfrom=freebsd@igalic.co; dmarc=none Date: Fri, 08 Sep 2023 15:06:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igalic.co; s=protonmail2; t=1694185583; x=1694444783; bh=aq38UxGIxG6IEF9Ta/sqeVo3H6vFhg9u49aJCSUoYMo=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=AvtwKLFkOAs5Oa8lJlSXIwZI126eLpxpfzSqgmCfvO+g3E8xTwM2Zyl8m50cKaNJ5 4r8ARsKo4PcQnw/RleR3XwV8pgv3L3g2z5BhMLiyDpOmyu/nxm5qR1ImwMwDqEkh/Q EJ0QmPvlL2wvBX/eOVBxFbr8Icd1RJnHP2RM/Id0PdiQmelE+z/DzXunhfZeRGNH8g k1YOKL5u0cldU7LI4UDvKN+gEJ4/jmHNFtjyzrX4njEVUelTkpopTOwEFuGBEeahd8 2FzmZ12iFFbmSY1u3nAnigecv/0ibJ37p17wDxhSO0VgmmH3Mmbf4u7O0X6nM5hWrD 4zohl9RuOPc7A== To: freebsd-hackers , "freebsd-virtualization@FreeBSD.org" From: =?utf-8?Q?Mina_Gali=C4=87?= Subject: Question about virtio_alloc_virtqueues Message-ID: Feedback-ID: 66573723:user:proton List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.07 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; R_MIXED_CHARSET(0.83)[subject]; RWL_MAILSPIKE_EXCELLENT(-0.40)[185.70.40.18:from]; R_DKIM_ALLOW(-0.20)[igalic.co:s=protonmail2]; R_SPF_ALLOW(-0.20)[+ip4:185.70.40.0/24]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[freebsd-hackers@freebsd.org,freebsd-virtualization@FreeBSD.org]; RCVD_COUNT_ZERO(0.00)[0]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; TO_DN_EQ_ADDR_SOME(0.00)[]; ASN(0.00)[asn:62371, ipnet:185.70.40.0/24, country:CH]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[igalic.co:+]; TO_DN_SOME(0.00)[]; DMARC_NA(0.00)[igalic.co]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Queue-Id: 4Rhzw31KHDz3VNp Hi folks, for the past two or so weeks, I've been trying to document the virtio functions: You can see some of my progress here: https://codeberg.org/meena/freebsd-src/commits/branch/improve/virtio I'm currently trying to document virtio_alloc_virtqueues. The second argument, flags, is only ever called with 0, and never passed on to anything. So I thought I'd remove it. However, there *is* this comment in if_vtnet.c: =09/* =09 * TODO: Enable interrupt binding if this is multiqueue. This will =09 * only matter when per-virtqueue MSIX is available. =09 */ =09if (sc->vtnet_flags & VTNET_FLAG_MQ) =09=09flags |=3D 0; after which flags are still set to 0. for now?? What does this mean? Kind regards, Mina Gali=C4=87