From nobody Thu Sep 07 15:50:20 2023 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RhNx91WjFz4sD8b for ; Thu, 7 Sep 2023 15:50:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RhNx90PKnz3Kg6 for ; Thu, 7 Sep 2023 15:50:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1694101821; a=rsa-sha256; cv=none; b=aOHQwf4WPR+csIOuOwYvZDupJwtpuVtEKFFOKYonHtR83qp7BMyrcQiscFefo/Vzypcm6Z lVCi1TsMRTVnBLoKSP1Uujyvefjf0ygmza4ITSr1gF1uNOUpRX9cLmgWafPXxNL5pNi0Q8 oV2PaRt/JS5piZq69GZt5ClJxhgGrjdxFV+tpBryd54eJt0iPOEk/2/BydUVeWzKaUxCaz 4OGRRdyHRGK5lKXrse+hqH+1RSa8LhE2038Ie/JmHMM0be2EHWh5QBMtkpjKnkHpuauDno RAn043qm+k/x4NJ58LKXIpCuKI8zwWu8LZNPD2yJpO0DZqWtUcF/M7G2IXST/Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694101821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UsRQmNrFYh/70E5ga2rWPuIWQHCSxFDaNnedAoqD7b8=; b=eRT7/2IdvbqQ5S+2CHrSrze1ngdtynbq1Ml4skJ3oPUReWkxLDpVaCdGO7aMD2ZxXugO4i sAu4fVgeo78W6GNx6h5l0/eFzJ7Xwiw228BYMdSH9yip5TVsrBrXFcp1A0ZeC0+ydHBfX7 FKUmdc6D151bppWJW/kDawFbnZs4L3MtGlKDAWHAfHwWNhI6K7dNnHQFVmO98aTRTNzlVE HyVrYXLTIzR/mj0kAdw/cKAvXFNbT+lbWyqBzQM8ftYKWMb2WgZMS/viQGRhnVRMGdmsmK Wf9GSMNyxlCFKP4afEgk/PSvsnaudX+ddMjVzbZv9vQOHDictAgNOGRrg4KE4Q== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RhNx86VQyz15BT for ; Thu, 7 Sep 2023 15:50:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 387FoKUL061506 for ; Thu, 7 Sep 2023 15:50:20 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 387FoKLw061505 for virtualization@FreeBSD.org; Thu, 7 Sep 2023 15:50:20 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 273557] Regression preventing bhyve from running inside a jail without IP after f74147e26999838e03a522bf59ea33bef470d356) breaks support for jailing bhyve with IPv4 and IPv6 disabled. Patch included. Date: Thu, 07 Sep 2023 15:50:20 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bhyve X-Bugzilla-Version: 14.0-STABLE X-Bugzilla-Keywords: bhyve, easy, patch, regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: crest@rlwinm.de X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: virtualization@FreeBSD.org X-Bugzilla-Flags: mfc-stable14? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273557 --- Comment #5 from crest@rlwinm.de --- (In reply to Bjoern A. Zeeb from comment #3) I've seen that the ioctl() does implicitly bitwise-or in the IFF_UP flag, b= ut it felt cleaner to explicitly request this instead of relying on this undocumented implementation detail. I confirmed it even brings the interfac= e up if a NULL pointer is passed as argument to the ioctl(), but again that woul= d be an ugly workaround. I agree that it would've been better to make this optio= nal or even check the interface link state before overwriting it and only refus= ing to start the guest if the link can't be brought up, but I don't see any situation where the current implementation of the VMIO_SIOCSIFFLAGS ioctl() would fail on an opened tap device so the error handling code is unreachabl= e on FreeBSD releng/13.2 and stable/14. --=20 You are receiving this mail because: You are the assignee for the bug.=