From nobody Wed Apr 26 09:47:43 2023 X-Original-To: freebsd-virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q5vDp2Ppzz47lVK for ; Wed, 26 Apr 2023 09:47:54 +0000 (UTC) (envelope-from mad@madpilot.net) Received: from mail.madpilot.net (vogon.madpilot.net [159.69.1.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q5vDn2vR6z3NJq for ; Wed, 26 Apr 2023 09:47:53 +0000 (UTC) (envelope-from mad@madpilot.net) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=madpilot.net header.s=bjowvop61wgh header.b=OR2gp7HF; spf=pass (mx1.freebsd.org: domain of mad@madpilot.net designates 159.69.1.99 as permitted sender) smtp.mailfrom=mad@madpilot.net; dmarc=pass (policy=quarantine) header.from=madpilot.net Received: from mail (mail [192.168.254.3]) by mail.madpilot.net (Postfix) with ESMTP id 4Q5vDd5zD3z6fjq for ; Wed, 26 Apr 2023 11:47:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=madpilot.net; h= content-transfer-encoding:content-type:content-type:subject :subject:from:from:content-language:date:date:message-id :received; s=bjowvop61wgh; t=1682502463; x=1684316864; bh=HkXpIw fGPac05lk9EctLhHlyFZhkjUnnV6bwUFgSAN8=; b=OR2gp7HFbrVt/LGkM9qdb7 JC21wh6YHPymZtpUfSWZvtyMdcsQ+X9ZBASsMCcaV2hvcuDcPX3SSQSsnx2W7ygV lRBu4mDVFRuHHg9/PtO+ICaliiDoYux+SthfDyDtDA4kSnFI2fCc2qQavyNGyVpD wpdJ2LZVgmY5PByxciUQ3IC3VRUbYiis6zRThyBIFpDlO2yGbcOEiUa3alNheIn+ KXR+3CVOZlYDcH/WVBWgDcAPMg8tWLSG06+tnnuRHt+YbT63Xj4r5Rx4VpwbGnv5 Pag3b18fNkTyuzBs29E6Nm4jWl6GR8crrsRr/4gixjapMwPecRX+R7ubdpf9EPag == Received: from mail.madpilot.net ([192.168.254.3]) by mail (mail.madpilot.net [192.168.254.3]) (amavisd-new, port 10026) with ESMTP id fXUpJaO3kOWB for ; Wed, 26 Apr 2023 11:47:43 +0200 (CEST) Message-ID: Date: Wed, 26 Apr 2023 11:47:43 +0200 To: freebsd-virtualization@freebsd.org Content-Language: en-US From: Guido Falsi Subject: Proposed change for bhyve DEBUG_HDA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-2.00 / 15.00]; MISSING_MIME_VERSION(2.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[madpilot.net,quarantine]; R_SPF_ALLOW(-0.20)[+mx]; R_DKIM_ALLOW(-0.20)[madpilot.net:s=bjowvop61wgh]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MLMMJ_DEST(0.00)[freebsd-virtualization@freebsd.org]; DKIM_TRACE(0.00)[madpilot.net:+]; ARC_NA(0.00)[]; ASN(0.00)[asn:24940, ipnet:159.69.0.0/16, country:DE]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; PREVIOUSLY_DELIVERED(0.00)[freebsd-virtualization@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; TO_DN_NONE(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Queue-Id: 4Q5vDn2vR6z3NJq X-Spamd-Bar: - X-ThisMailContainsUnwantedMimeParts: N List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org Hi, I noticed we are unconditionally enabling DEBUG_HDA in bhyve. This can cause /tmp to fill up unexpectedly. I created a code review proposing to change the default: https://reviews.freebsd.org/D39826 I also discovered that the code actually fails to build if DEBUG_HDA is disabled. Review contains fix for this too. Not sure who should review it, but I thought to post a message here to make sure interested people know about this review. Thanks in advance! -- Guido Falsi