From nobody Thu Apr 13 13:32:15 2023 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Py0qk5RNtz4521V for ; Thu, 13 Apr 2023 13:32:18 +0000 (UTC) (envelope-from rebecca@bsdio.com) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Py0qj6J6Kz3CQK; Thu, 13 Apr 2023 13:32:17 +0000 (UTC) (envelope-from rebecca@bsdio.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdio.com header.s=fm1 header.b=MYZrBj5X; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=PG3wMPSX; spf=pass (mx1.freebsd.org: domain of rebecca@bsdio.com designates 66.111.4.27 as permitted sender) smtp.mailfrom=rebecca@bsdio.com; dmarc=none Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 228395C0068; Thu, 13 Apr 2023 09:32:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 13 Apr 2023 09:32:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681392737; x=1681479137; bh=B/ri7njMLwX9dHOwy3m664BS3ddPXntdxBk rNQPuYnQ=; b=MYZrBj5X0uu158lVWWn1t0pRcn58l+24tnPstdKn+zaLauGIEHc BPinW4w4h8btTdMiCJ0d1UfMOY8cnJz55LhWlL1kPlZfSvgDNJz7E1wQMoO14iMH u6JGFhqH42JyVCGCEI2PIr+FFAoZWMz38W5yHSauj4Lvy6SZJfgaE4sAGu51OTCt VMoW2HY215rHffRHcKhHIsQo5BatMq0R7dmwBJTEWqmOCfyfGhnyJkuBPxFl+VtQ crZ0Zul99Ue/y24SP3qQR748c+CP/nENJg1wBVB4gHtgAvPxqipykvVT8TpqJEZE BBu2ooFfCcGOEoPFH3KDPAxhBCg0UB/3ZjA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1681392737; x=1681479137; bh=B/ri7njMLwX9dHOwy3m664BS3ddPXntdxBk rNQPuYnQ=; b=PG3wMPSXApj1NwqmaHWkknRvyPkjaaDXOL6ruuVr/1o8Hw3rzx/ /p/BnO/R3oV95vMX6vktGoy+wDnplO0f6k//C419xLVCx5qex0WqtcF6SY3uFTUl avbKj8thbkEsmZdyro0D4AFRtBORE83kivphF56h8m7Rmz5juFFH3iAAezidHtP+ d6vxHA8IvkZKrN4pchJnjMt015uB0quy1ycQ0HRtAHLNOtxI83YTmMKqotFKCWS9 AWOG3IvApKkz0M8zTlN2SnkxkMWgZxCNLqPPJcumEdE8irQ9JbCdSfzH6KP5jkZp Ail+uxywGTds/Yh5Xb3C6Qc6PB/wO2F5sFw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekkedgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeegfeegveduheejgfduffefhfehleehiefghfetvdejvdelhfeukefhhfdv geehveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Apr 2023 09:32:16 -0400 (EDT) Message-ID: <9559fd1f-b1bb-6b8d-7874-b1fbce1edbe9@bsdio.com> Date: Thu, 13 Apr 2023 07:32:15 -0600 List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] OvmfPkg/BhyveBhf: install bhyve's ACPI tables Content-Language: en-US To: =?UTF-8?Q?Corvin_K=c3=b6hne?= , Peter Grehan Cc: virtualization@FreeBSD.org References: <20230331123936.540020-1-corvink@FreeBSD.org> <365212d5-75e4-1717-b69a-5e1ddf6e40ab@freebsd.org> From: Rebecca Cran In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.60 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; DWL_DNSWL_LOW(-1.00)[messagingengine.com:dkim]; NEURAL_HAM_SHORT(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[bsdio.com:s=fm1,messagingengine.com:s=fm3]; R_SPF_ALLOW(-0.20)[+ip4:66.111.4.27]; MIME_GOOD(-0.10)[text/plain]; RCVD_IN_DNSWL_LOW(-0.10)[66.111.4.27:from]; MIME_TRACE(0.00)[0:+]; DKIM_TRACE(0.00)[bsdio.com:+,messagingengine.com:+]; FROM_EQ_ENVFROM(0.00)[]; ASN(0.00)[asn:19151, ipnet:66.111.4.0/24, country:US]; RCVD_TLS_LAST(0.00)[]; MLMMJ_DEST(0.00)[virtualization@FreeBSD.org]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[66.111.4.27:from]; ARC_NA(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; DMARC_NA(0.00)[bsdio.com]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: 4Py0qj6J6Kz3CQK X-Spamd-Bar: ---- X-ThisMailContainsUnwantedMimeParts: N On 4/6/23 00:16, Corvin Köhne wrote: > I take this as confirmation. If no one else complains, I'm going to > send this patch to the EDKII project next week. I glanced over the patch and the only thing I noticed is related to a change I made a few days ago. You should use  __func__ instead of __FUNCTION__. That will be enforced in PatchCheck.py when I get my change committed. -- Rebecca Cran