From nobody Sun Jun 05 08:37:55 2022 X-Original-To: freebsd-virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id EFE821BD21A6 for ; Sun, 5 Jun 2022 08:38:17 +0000 (UTC) (envelope-from nyan@myuji.xyz) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4LG94S6yL2z4rlj for ; Sun, 5 Jun 2022 08:38:16 +0000 (UTC) (envelope-from nyan@myuji.xyz) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id C42545C00C5 for ; Sun, 5 Jun 2022 04:38:16 -0400 (EDT) Received: from imap45 ([10.202.2.95]) by compute4.internal (MEProxy); Sun, 05 Jun 2022 04:38:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=myuji.xyz; h=cc :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm1; t= 1654418296; x=1654504696; bh=WE9vSVZkezKilI1nxdeYzeOuBAl7B/m713s /uaILmjo=; b=ekFNugguPeA/4c6jwY7w1G2azI99M9xzZQtlovjD1z0PWwvN42C gURVRCK0AYzkwkbx8IefEpDWJO2OYa1HnqyC75gDHrAhDVXpKLBUyhNCxAMZx+OD wgCCNqdOuVVe7tglmnHccZ/yiLPcxKpHSlNwIUqOFJDd6vA9Ok6Jy95l0Qw5Wbft 7MPP0KSlpQzXYvoRSGiCNvTeFcNsqLFESSov2l1aAKEhrhWKPfpk/FGMfi4nQGrc HaeC9YUJLP3tpV4692pLkzU40IsdkdRY9aXnXFQZuMimcEVOfA2XnuMo6oZ1ujDw 8IRlpyUezk6pUEolhomqecp2jOStickUzuw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1654418296; x= 1654504696; bh=WE9vSVZkezKilI1nxdeYzeOuBAl7B/m713s/uaILmjo=; b=p zGct368TbNlut6VERlYoFaw7DvCaAktSP4LvaM1/EYUIloJBX/hU3ta5sSMzvdtv UbaTWPxp/GmTnAsoO2YzEUM2bo45pzQsQ2abWnHFy1AYmkBU7zIlO4BhZ82Iuo2Q BmalPwQxObi1D8ytWFFJwWRg0rpuZfQCZgpMIrJFkLLvpLIyRnnBqQl4b70IQ/2N H0FF63W2JEi/jchFsWj/69OtiVHVIQB/V6fE50tKBnxKn9HFfAK3pC2puy0UNyz0 zyD2JWOEnXLvpW54iO6Dd7us3ANCFFsPn98d5+ZQqHc2KAZ7DtPaDPVw40aLQ7Dy CJVfNSDwhOsh+P9zm1iNw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedruddttddgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdlvdefmdenucfjughrpefofg ggkfffhffvufgtsegrtderreerredtnecuhfhrohhmpedfofhitghhrggvlhcujggrnhcu mfgrucevhhhiuhdfuceonhihrghnsehmhihujhhirdighiiiqeenucggtffrrghtthgvrh hnpeetjeethefhjeevhfeitdeiveejheduheehgedukedugfduuedulefgffevgffgheen ucffohhmrghinhepfhhrvggvsghsugdrohhrghenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehnhigrnhesmhihuhhjihdrgiihii X-ME-Proxy: Feedback-ID: i9dd946d0:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 897592720072; Sun, 5 Jun 2022 04:38:16 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-591-gfe6c3a2700-fm-20220427.001-gfe6c3a27 List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org Mime-Version: 1.0 Message-Id: <7e0f38ce-3f94-41da-95ac-6407ec45d007@www.fastmail.com> Date: Sun, 05 Jun 2022 16:37:55 +0800 From: "Michael Yan Ka Chiu" To: freebsd-virtualization@freebsd.org Subject: Need help review a patch to enable network backend hint Content-Type: multipart/alternative; boundary=cdedf5898a92456da69f12e58e750152 X-Rspamd-Queue-Id: 4LG94S6yL2z4rlj X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=myuji.xyz header.s=fm1 header.b=ekFNuggu; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="p zGct36"; dmarc=none; spf=pass (mx1.freebsd.org: domain of nyan@myuji.xyz designates 66.111.4.27 as permitted sender) smtp.mailfrom=nyan@myuji.xyz X-Spamd-Result: default: False [-3.59 / 15.00]; XM_UA_NO_VERSION(0.01)[]; R_SPF_ALLOW(-0.20)[+ip4:66.111.4.27:c]; MV_CASE(0.50)[]; TO_DN_NONE(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; DKIM_TRACE(0.00)[myuji.xyz:+,messagingengine.com:+]; NEURAL_HAM_SHORT(-1.00)[-0.999]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:19151, ipnet:66.111.4.0/24, country:US]; RCVD_IN_DNSWL_LOW(-0.10)[66.111.4.27:from]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[myuji.xyz:s=fm1,messagingengine.com:s=fm1]; FREEFALL_USER(0.00)[nyan]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-virtualization@freebsd.org]; DMARC_NA(0.00)[myuji.xyz]; RCPT_COUNT_ONE(0.00)[1]; DWL_DNSWL_LOW(-1.00)[messagingengine.com:dkim]; MLMMJ_DEST(0.00)[freebsd-virtualization]; MID_RHS_WWW(0.50)[] X-ThisMailContainsUnwantedMimeParts: N --cdedf5898a92456da69f12e58e750152 Content-Type: text/plain Hi everyone, I have made a PR on https://reviews.freebsd.org/D35143, that adds an optional option to virtio-net frontend to allow users to explicitly choose the correct network backend. Currently, bhyve is determining which network backend to use by the prefix of the interface, which could cause some issues, for example when a user renamed a tap interface with a name that does not start with "tap". This PR allows the user to put "type=tap" to hint that it is a tap interface. It will be great if someone can help review it and determine if it is acceptable to land. Thanks, Michael --cdedf5898a92456da69f12e58e750152 Content-Type: text/html Content-Transfer-Encoding: quoted-printable
Hi everyone,

I have made a PR on https://reviews.freebsd.org/D35143, that adds an optional option
to virtio-net frontend to allow users to explicitly choose t= he correct network backend.

Currently, bhyv= e is determining which network backend to use by the prefix of the inter= face,
which could cause some issues, for example when a us= er renamed a tap interface with a
name that does not start= with "tap". This PR allows the user to put "type=3Dtap" to hint that it= is
a tap interface.

It will = be great if someone can help review it and determine if it is acceptable= to land.

Thanks,
Michael
=
--cdedf5898a92456da69f12e58e750152--