RE: bhyve NVMe 1.4 support

> -----Original Message-----
> From: Chuck Tuffli <chuck@tuffli.net>
> Sent: Tuesday, 11 January 2022 10:58 AM
> To: jason@tubnor.net
> Cc: FreeBSD virtualization <freebsd-virtualization@freebsd.org>
> Subject: Re: bhyve NVMe 1.4 support
> 
> On Wed, Jan 5, 2022 at 4:33 PM Chuck Tuffli <chuck@tuffli.net> wrote:
> >
> > On Mon, Jan 3, 2022 at 4:49 PM <jason@tubnor.net> wrote:
> > >
> > > Hi Chuck,
> > >
> > > Testing on 14.0-CURRENT shows the following:
> > >
> > > OpenBSD 6.9 - NVMe read/write OK
> > > Windows 10 - NVMe read OK, write FAIL Windows Server 2022 - NVMe
> > > read OK, write FAIL Alma Linux 8.5 - NVMe read OK, write FAIL.
> >
> > Thanks for the report, Jason. I have Alma 8.5 installed and am investigating.
> 
> OK, I found and fixed the regression. New version of the file in the same
> place is up for folks who are interested.
> 
> --chuck

This version looks good. No regression on the following guest platforms under 14.0-CURRENT:

OpenBSD 6.9 - NVMe read/write OK
Windows 10 - NVMe read/write OK
Windows Server 2022 - NVMe read/write OK
Alma Linux 8.5 - NVMe read/write OK
FreeBSD 13.0 - NVMe read/write OK

From a storage presentation layer in a production perspective, I can't find any issues with the proposed update to pci_nvme.c

Some of our tests included:

The removal and addition of partitions on the NVMe presentation layer
Installation of all the operating system listed above
Where supported by the guest operating system, the TRIM command executed on the presentation layer and guest rebooted to ensure no data corruption was caused by TRIM

Cheers,

Jason.