From nobody Mon Aug 29 22:38:26 2022 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MGlhg2GFQz4ZtpK for ; Mon, 29 Aug 2022 22:38:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MGlhg1GCFz3pZ9 for ; Mon, 29 Aug 2022 22:38:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MGlhg0CwBzZb4 for ; Mon, 29 Aug 2022 22:38:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 27TMcQBv087110 for ; Mon, 29 Aug 2022 22:38:26 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 27TMcQMc087109 for virtualization@FreeBSD.org; Mon, 29 Aug 2022 22:38:26 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 264521] bhyve: pci_vtscsi_request_handle() can read beyond allocated heap object Date: Mon, 29 Aug 2022 22:38:26 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bhyve X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: needs-patch, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: jhb@FreeBSD.org X-Bugzilla-Flags: mfc-stable13? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1661812707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ndFj3JPnXSibl+3GqcX2qxtP/cRNXs6rWu+FHJmU+/Q=; b=vyQyoXD58MbYoeWSt9+Gw4G1aKxKWMrPBw3nq3+p6F7H7+DdRzZpfMLj+CWaudGxbD0OhF 5EUG9V+J4VBfmJB7TBfUiR2r9z6YPcBR90e4xG3mz8J+8bRSd4I3OdXQrmx6XO4bH1SrUc mL4HqH+IamY3KaI8mQiKC1FhfYB/QIF10ygUAdUFW2jaSEQArwqeHfvNWwy+/ayTN6W1h4 9D4tU0wKrQGZUfWdW81K+sxkTfZGRJ6Md0icdum6FvdBwoonPw3VfNyKLmNglFA6eMJoi6 dZ5cX7AceoAFXxOiJXZwyGJlH5owjnpuJ45bFC6akVMQwqVrCDZzdT/imd8LVw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1661812707; a=rsa-sha256; cv=none; b=d9Pz15JVNattHT8IJJJ2bAKAwdtyUoHNzOA0H0F6Rq09ercz0vwKB9Paob9jFTJ+vav8c/ XNooTF7CUl5SUFzTZqN3bWBViedPsaUpSNClnFensCgrYpgPzD3wFl5a1JI5XERpQX0RvZ 3bGFQcDKnM9S5JAEbyPZOTE8qf/W8S4XwZd6/q2SfQ9IbH5ITZNIsV47KoUnPCSKvvOdjm Oj6dJ2vN5L9/Gz2w4spTA7K4IWvFwsFpFKRyxGkZzECxlccB1PV/Wch5SW5R4YAlRtw2Q4 driVAFLKkVAfrkEtBBug6Q7VcDn21LyUMiUTbvtsedVYR2/lt2Y81WuzngugkA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D264521 --- Comment #4 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dbb31aee26bd13307d97c5d5bf2b10bf05= bdc18fd commit bb31aee26bd13307d97c5d5bf2b10bf05bdc18fd Author: John Baldwin AuthorDate: 2022-08-29 22:36:11 +0000 Commit: John Baldwin CommitDate: 2022-08-29 22:37:27 +0000 bhyve virtio-scsi: Avoid out of bounds accesses to guest requests. - Ignore I/O requests with insufficiently sized input or output buffers (those not containing compete request headers). - Ignore control requests with improperly sized buffers. - While here, explicitly zero the output header of an I/O request to avoid leaking malloc garbage from the host if the header is not fully populated. PR: 264521 Reported by: Robert Morris Reviewed by: mav, emaste MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D36271 usr.sbin/bhyve/pci_virtio_scsi.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=