From nobody Thu Apr 07 16:56:48 2022 X-Original-To: freebsd-virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2502D1AA68F7 for ; Thu, 7 Apr 2022 16:57:07 +0000 (UTC) (envelope-from marietto2008@gmail.com) Received: from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com [IPv6:2607:f8b0:4864:20::1136]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KZ6xG2DXqz3qn4; Thu, 7 Apr 2022 16:57:06 +0000 (UTC) (envelope-from marietto2008@gmail.com) Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-2eb680211d9so68651977b3.9; Thu, 07 Apr 2022 09:57:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SlcipZXOo8Yh08uRoo3B90hKSNwRvCXNeFfgjTKh1yY=; b=M+nV6Q50346gKkbOFGLCkrI5zCQgw4UaXqKuBkbib27l7rZPu0ePNcM/POcGBmGICs UwI37o13QU7XR/tSDMF/Hk3lCXfIqBfCq8R8Bava9uJw/RfXgLAR2yABtq0h13lJban6 ZRNwhUgKMSjZ2m1AX/khjyQKrZv7BaXOxnS5qRENLC6glopIInx2995FBVwn16GpJrBt k5r2lTMK1qPaJb6bUWMpnpwRJmOtiSGwD7wGawfgwe/0w2eUDe4YAD0SvUE8ijNwK82M GH6gxzgdWvhL9uKrmaMwA33LBlnTsLhak1CzZ1BauZmQxsuSESa03eSxZGbGW/Ndx3dt 0tvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SlcipZXOo8Yh08uRoo3B90hKSNwRvCXNeFfgjTKh1yY=; b=VwfktSAL6LgNWnVl6UyTNSIpQ99c15qZFeIFsuepL4EjravpN07qPBx1FalHNX7aIr M2mhbykeS5PPYg0lX8Sz2BjEi+k8VRdnYLHV8SKFBPxPFKfofTvamr4m7ZDi0jLkZiOi fIgoKPTUd45iFveg6hqJ81B+NO5VG6nE5UVc8CoPRdUyZ4E7MuVxCtou9jkdreKBOQpy OipIJUmAO/A1q+bTWZo02A+r7Z8YE1L2p8w9mVS5iidB0MUTY5Ny1ldkNalnZRc9rY6u P+sY31grfNCFN4ty8ibbZ+C6h4PEoKQrgDfO/ipFPHW1f4Wt4SS+hRaLPyGs85ODy0FC OD/A== X-Gm-Message-State: AOAM533SbNkzvzKT7LB5vK9kXByORz94g/D7qG7mdacTrcFwbyfWtYZK 4QxaqktzvNVudqoVkPKQb2tacnm/fb54H4GeJlc= X-Google-Smtp-Source: ABdhPJyYcbGxe/NnpE9641zJy47e1HBATaL3B5FxZyAKJziOe2aY6qScc6DXr1ZA69qtPC9D7h4ROAqDoH5nAlZHSfY= X-Received: by 2002:a0d:e247:0:b0:2eb:303a:a4b9 with SMTP id l68-20020a0de247000000b002eb303aa4b9mr12701854ywe.124.1649350620195; Thu, 07 Apr 2022 09:57:00 -0700 (PDT) List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 References: <20220329101417.617-1-c.koehne@beckhoff.com> <7cdf6ac12fbc499fb846f85782d06e21@beckhoff.com> <8dc8c192-1bc6-71cc-d572-eda275724e99@bsdio.com> In-Reply-To: <8dc8c192-1bc6-71cc-d572-eda275724e99@bsdio.com> From: Mario Marietto Date: Thu, 7 Apr 2022 18:56:48 +0200 Message-ID: Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg To: Rebecca Cran Cc: =?UTF-8?Q?Corvin_K=C3=B6hne?= , Peter Grehan , devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Jordan Justen , FreeBSD Virtualization , Gerd Hoffmann Content-Type: multipart/alternative; boundary="000000000000d3b0b905dc135d30" X-Rspamd-Queue-Id: 4KZ6xG2DXqz3qn4 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=M+nV6Q50; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of marietto2008@gmail.com designates 2607:f8b0:4864:20::1136 as permitted sender) smtp.mailfrom=marietto2008@gmail.com X-Spamd-Result: default: False [-2.50 / 15.00]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MID_RHS_MATCH_FROMTLD(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCPT_COUNT_SEVEN(0.00)[9]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; TAGGED_RCPT(0.00)[tianocore]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::1136:from]; MLMMJ_DEST(0.00)[freebsd-virtualization]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; SUSPICIOUS_RECIPS(1.50)[] X-ThisMailContainsUnwantedMimeParts: N --000000000000d3b0b905dc135d30 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable im trying to test the patch on my pc,that has two graphic cards,the intel coffee lake and the nvidia. i tried to start the pc from the nvidia card and ive configured the xorg.conf file giving the proper bus id value. in addition ive loaded the kernel.ko file from the boot loader.conf i have removed the intel and the drm drivers used by the Intel graphic card. unfortunately my pc wont boot from the nvidia card. my mouse and keyboard freezes just before the desktop manager (xfce and kde5) starts. Il gio 7 apr 2022, 18:46 Rebecca Cran ha scritto: > I've just looked at the patch and it looks good, though I haven't tested > it. > > So yes, please add: > > > Acked-by: Rebecca Cran > > > On 4/6/22 23:24, Corvin K=C3=B6hne wrote: > > Hi Peter and Rebecca, > > > > thanks for your feedback. This patch is backward compatible. It checks > > if QemuFwCfg is available and if QemuFwCfg is missing it falls > > back to BhyveFwCtl. > > > > So, should I add Reviewed-by (or Acked-by?) Peter and Rebecca to the > > commit message? > > > > > > Thanks > > Corvin > > > > Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans > Beckhoff > > Registered office: Verl, Germany | Register court: Guetersloh HRA 7075 > > > > > > > > --000000000000d3b0b905dc135d30 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
im trying to test the patch on my pc,that has two graphic= cards,the intel coffee lake and the nvidia. i tried to start the pc from t= he nvidia card and ive configured the xorg.conf file giving the proper bus = id value. in addition ive loaded the kernel.ko file from the boot loader.co= nf i have removed the intel and the drm drivers used by the Intel graphic c= ard. unfortunately my pc wont boot from the nvidia card. my mouse and keybo= ard freezes just before the desktop manager (xfce and kde5) starts.
Il gio 7= apr 2022, 18:46 Rebecca Cran <rebe= cca@bsdio.com> ha scritto:
I= 've just looked at the patch and it looks good, though I haven't te= sted it.

So yes, please add:


Acked-by: Rebecca Cran <rebecca@bsdio.com>


On 4/6/22 23:24, Corvin K=C3=B6hne wrote:
> Hi Peter and Rebecca,
>
> thanks for your feedback. This patch is backward compatible. It checks=
> if QemuFwCfg is available and if QemuFwCfg is missing it falls
> back to BhyveFwCtl.
>
> So, should I add Reviewed-by (or Acked-by?) Peter and Rebecca to the > commit message?
>
>
> Thanks
> Corvin
>
> Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys.= Hans Beckhoff
> Registered office: Verl, Germany | Register court: Guetersloh HRA 7075=
>
>
>

--000000000000d3b0b905dc135d30--