From nobody Thu Apr 07 16:46:15 2022 X-Original-To: freebsd-virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 6B7541AA3932 for ; Thu, 7 Apr 2022 16:46:21 +0000 (UTC) (envelope-from rebecca@bsdio.com) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4KZ6hr01j6z3n6K; Thu, 7 Apr 2022 16:46:19 +0000 (UTC) (envelope-from rebecca@bsdio.com) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 807973201F49; Thu, 7 Apr 2022 12:46:18 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 07 Apr 2022 12:46:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; bh=KpH3pqqesPLy13 8k1yosXKY7PaJVVysIENN5xw4D7K4=; b=p+a59JePOaPxBuKIeEietso8ri0rE0 2bueFVtAF4eZFb4BXyAFRAVfZge55mB4G+P3UbnDe9uGa9SQb8UiMDhQYdYe0kVp plvclZzBrxSYnGCY3H+HRhU9NkgRVDk+3peXrdj5JS4mZEV7oHbiCZ5sm9TSFrI5 3paC2Lb3mn9F2W6mHPfPPwIHzWgpGVTZKMzf0dI19Zwg+wVQNBo+s7mru3VJukfp JXHpgbw6/gTQJd7PEDtCy01w7ymTAdLp/itrWLMfEYQ3CrNMFJ5LCOvIcunSR0BJ gqDvRzWDOlpEx9aCp1dB2Kwqf9pyb+FHx1dFOeQJ+V2g62y0dIjp3jAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=KpH3pqqesPLy138k1yosXKY7PaJVVysIENN5xw4D7 K4=; b=kV+il3BlUcjQ4Bg1w5hol1gnOS1B8TCKFgRlfvNr4AV8rp9UxbJ9LWhOu 3c+Mlvoe1SFixaJqz7FQUPgB5yrlHzoSogYGwony7vnqe4kEFftJkr2K/EfJwMCL DvFL1rkQl6VxaK9gXY6mygyohrmkibKOIA2bydbBqpXCs8j2W2x4A0GsF16hLEey uUTx0nC4x/1XIQK75wDEF1LbwF2TQkd1T9s5NdAcs4Vl/2N1Fxt9uR/PAKIvP2gd 9xyxKn60IMWvZ93WXqd3ct1J+KEbXsaGBYv5pYi+yvRDlAsVmBlr7i/E45P5B6nM WZXy/X7a6eHxvvX8+rHvWXWKjf4KA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudejkedguddtiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfhfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeeuheffgeefleeuudefffefjeeiueeggedvfefghfeuteehueehgeeifedt udefheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Apr 2022 12:46:16 -0400 (EDT) Message-ID: <8dc8c192-1bc6-71cc-d572-eda275724e99@bsdio.com> Date: Thu, 7 Apr 2022 10:46:15 -0600 List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg Content-Language: en-US To: =?UTF-8?Q?Corvin_K=c3=b6hne?= , Peter Grehan , "devel@edk2.groups.io" Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , FreeBSD Virtualization , Gerd Hoffmann References: <20220329101417.617-1-c.koehne@beckhoff.com> <7cdf6ac12fbc499fb846f85782d06e21@beckhoff.com> From: Rebecca Cran In-Reply-To: <7cdf6ac12fbc499fb846f85782d06e21@beckhoff.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4KZ6hr01j6z3n6K X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdio.com header.s=fm2 header.b=p+a59JeP; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=kV+il3Bl; dmarc=none; spf=pass (mx1.freebsd.org: domain of rebecca@bsdio.com designates 64.147.123.21 as permitted sender) smtp.mailfrom=rebecca@bsdio.com X-Spamd-Result: default: False [-2.64 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:64.147.123.21]; RCVD_COUNT_THREE(0.00)[4]; RWL_MAILSPIKE_EXCELLENT(0.00)[64.147.123.21:from]; DKIM_TRACE(0.00)[bsdio.com:+,messagingengine.com:+]; NEURAL_HAM_SHORT(-0.54)[-0.542]; RCPT_COUNT_SEVEN(0.00)[8]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:29838, ipnet:64.147.123.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[64.147.123.21:from]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.998]; R_DKIM_ALLOW(-0.20)[bsdio.com:s=fm2,messagingengine.com:s=fm3]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; TAGGED_RCPT(0.00)[tianocore]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[bsdio.com]; DWL_DNSWL_LOW(-1.00)[messagingengine.com:dkim]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MLMMJ_DEST(0.00)[freebsd-virtualization]; SUSPICIOUS_RECIPS(1.50)[] X-ThisMailContainsUnwantedMimeParts: N I've just looked at the patch and it looks good, though I haven't tested it. So yes, please add: Acked-by: Rebecca Cran On 4/6/22 23:24, Corvin Köhne wrote: > Hi Peter and Rebecca, > > thanks for your feedback. This patch is backward compatible. It checks > if QemuFwCfg is available and if QemuFwCfg is missing it falls > back to BhyveFwCtl. > > So, should I add Reviewed-by (or Acked-by?) Peter and Rebecca to the > commit message? > > > Thanks > Corvin > > Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff > Registered office: Verl, Germany | Register court: Guetersloh HRA 7075 > > >