From nobody Thu Apr 07 05:24:06 2022 X-Original-To: freebsd-virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E39C51A92C36 for ; Thu, 7 Apr 2022 05:24:17 +0000 (UTC) (envelope-from C.Koehne@beckhoff.com) Received: from Internet2.beckhoff.com (internet2.beckhoff.com [194.25.186.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "*.beckhoff.com", Issuer "Thawte TLS RSA CA G1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KYqYr5Nq0z4gjj; Thu, 7 Apr 2022 05:24:16 +0000 (UTC) (envelope-from C.Koehne@beckhoff.com) DKIM-Signature: v=1; c=relaxed/relaxed; d=beckhoff.com; s=mail2022e; t=1649309048; bh=YhEqVEk7Y4Ccda7NBJEDDY2SWcLxYsVAt9QBINLyR4o=; h= "Subject:Subject:From:From:Date:Date:ReplyTo:ReplyTo:Cc:Cc:Message-Id:Message-Id"; a=ed25519-sha256; b= yZlUujx9/B/8gns0ll+suHcJOXMQZgWOIsSFCV64W8Eklb7LJcVwwqhs+vSXnPtQ+5HLN7jNRymhfnXSx+X0Cg== DKIM-Signature: v=1; c=relaxed/relaxed; d=beckhoff.com; s=mail2022r; t=1649309048; bh=YhEqVEk7Y4Ccda7NBJEDDY2SWcLxYsVAt9QBINLyR4o=; h= "Subject:Subject:From:From:Date:Date:ReplyTo:ReplyTo:Cc:Cc:Message-Id:Message-Id"; a=rsa-sha256; b= ef1y7Wnu0bAsoc6YR0bJIf3HRfCljGdtmghIt4Qp0Z9U7FPEftY1BAzAq+SFoxcG1lwpMuNoN2NHYzTcPxvpN5IINGR2pBol+UclLj7AZPISlYLOh3cT5btm+89xostmWCw8ODZRivx45cSIAZTVJVRq8UuMNMXfbELPbfiBG/8h6eUih6nQnI3LlPLMSFIcuk8C4pgBJeApDUI1ErQ8aE5VkxN1iLU0Et4i0YGPN1N9Cs/KMlKkZ4Yhlti2hfSkpZTt2lva+YTiFesqMh31v2o2CBPX1Iyeb+Q+TM9rzs7t7wqvhTZ+w9a1zdnwl4z5qhjPJFQ/HB5UFPaefINJDA== Received: from 172.17.5.170 by Internet2.beckhoff.com (Tls12, Aes256, Sha384, DiffieHellmanEllipticKey256); Thu, 07 Apr 2022 05:24:07 GMT Received: from ex04.beckhoff.com (172.17.5.170) by ex04.beckhoff.com (172.17.5.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.24; Thu, 7 Apr 2022 07:24:06 +0200 Received: from ex04.beckhoff.com ([fe80::c545:54e6:8481:2958]) by ex04.beckhoff.com ([fe80::c545:54e6:8481:2958%6]) with mapi id 15.01.2375.024; Thu, 7 Apr 2022 07:24:06 +0200 From: =?iso-8859-1?Q?Corvin_K=F6hne?= To: Peter Grehan , Rebecca Cran , "devel@edk2.groups.io" CC: Ard Biesheuvel , Jiewen Yao , Jordan Justen , "FreeBSD Virtualization" , Gerd Hoffmann Subject: RE: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg Thread-Topic: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg Thread-Index: AQHYQ1XKFBPmowqPYken/pnSIt7nHazigQ9wgACTBQCAACN/AIAAv1NA Date: Thu, 7 Apr 2022 05:24:06 +0000 Message-ID: <7cdf6ac12fbc499fb846f85782d06e21@beckhoff.com> References: <20220329101417.617-1-c.koehne@beckhoff.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [94.134.181.251] x-olx-disclaimer: EX04.BECKHOFF.COM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 X-Rspamd-Queue-Id: 4KYqYr5Nq0z4gjj X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=beckhoff.com header.s=mail2022e header.b=yZlUujx9; dkim=pass header.d=beckhoff.com header.s=mail2022r header.b=ef1y7Wnu; dmarc=none; spf=pass (mx1.freebsd.org: domain of C.Koehne@beckhoff.com designates 194.25.186.210 as permitted sender) smtp.mailfrom=C.Koehne@beckhoff.com X-Spamd-Result: default: False [-2.00 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[beckhoff.com:s=mail2022e,beckhoff.com:s=mail2022r]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; NEURAL_HAM_LONG(-1.00)[-1.000]; TAGGED_RCPT(0.00)[tianocore]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[beckhoff.com]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[beckhoff.com:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_SEVEN(0.00)[8]; RCVD_IN_DNSWL_NONE(0.00)[194.25.186.210:from]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; MLMMJ_DEST(0.00)[freebsd-virtualization]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:3320, ipnet:194.25.0.0/16, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; SUSPICIOUS_RECIPS(1.50)[] X-ThisMailContainsUnwantedMimeParts: N Hi Peter and Rebecca, thanks for your feedback. This patch is backward compatible. It checks if QemuFwCfg is available and if QemuFwCfg is missing it falls back to BhyveFwCtl. So, should I add Reviewed-by (or Acked-by?) Peter and Rebecca to the commit message? Thanks Corvin Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Bec= khoff Registered office: Verl, Germany | Register court: Guetersloh HRA 7075