From nobody Sun Oct 20 14:54:52 2024 X-Original-To: usb@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XWhLQ3RrJz5ZPJY for ; Sun, 20 Oct 2024 14:54:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XWhLQ2Prwz41sS for ; Sun, 20 Oct 2024 14:54:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729436094; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2PPF5/104Q92sIeEeAkoFGYd2MD3B8L84ahnWj/BxWY=; b=bVIbjNqVG1/8GW9i8uGLh5spPzDCtNWYFtXaCZMOlEpqCnRyUbD995UifgCdKO6G9haRer JBSqN/z2UioPySykLfMFzzSXjdg1FzYzAYo+WvCck7Stywr/9eQfKnabj2+sp1rsSgP/ej eO/GI0HOSiO5hznf2NwUFBLzrpOo8GynCLKyZNHUn+p2b7yQc6/mUQjF3bXBC5kHF/QXS1 gWozxsAo42zeJueW+DZgdK46cmBpPWBCy/SYp6fYrEv2udewlXMbAf92483FFBmadjZVWt xa3YolgJYzQnOc7ZmFxHUZ+HsszAV3cEVnm4zRdMzH+wmyRd4QNX1/7GhuLcjg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1729436094; a=rsa-sha256; cv=none; b=cSJvxeI5grSV4s5G60fNTaGhu3T4iAxZVZpBoSIC2jER7g9GVZVT/tY3jNAxHP4CfMoAZX 8H1+wOBPG29oMD8ZnCcvkdb17GZzQ/Tczt7Z4Yg9/dWU+viQHiGvikAmnTM3DdpUvI+IB/ 7iOJDqUEvnvBCmKQfslPOlpvp7+f4fE+HQFZguvlSS193yxks/zMYJwsC42bnvoQ6uedpd y5c9jijcLyqmRCMM/bqWNGVOkt615BaxlFSZ8ZzPQx9wjoOBaSAtwgxqM9rjmwARQipf1L P+/qG93B/6bcMxehCuyAPOX/lNcY+7kLEbmGvn+bwMa6ALKweori/xDDmy9eiQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XWhLQ20K4z15V4 for ; Sun, 20 Oct 2024 14:54:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 49KEsspK079867 for ; Sun, 20 Oct 2024 14:54:54 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 49KEssKA079866 for usb@FreeBSD.org; Sun, 20 Oct 2024 14:54:54 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: usb@FreeBSD.org Subject: [Bug 263783] USB MBIM: Support for LTE/4G USB modems (MBIM) Date: Sun, 20 Oct 2024 14:54:52 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: feature, needs-qa, vendor X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: zlei@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: usb@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-usb List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-usb@freebsd.org Sender: owner-freebsd-usb@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263783 --- Comment #32 from Zhenlei Huang --- `if_alloc()` never fails. All supported branches ( main, stable/14, stable/= 13 ) now have the same behavior. So no need to do NULL check any more. ``` sc->sc_if =3D ifp =3D if_alloc(IFT_MBIM); - if (ifp =3D=3D NULL) { - device_printf(sc->sc_dev, "Could not allocate a network interface\n"); - goto fail; - } ``` FYI https://reviews.freebsd.org/D45740 . --=20 You are receiving this mail because: You are the assignee for the bug.=