[Bug 277799] libusb should be updated

From: <bugzilla-noreply_at_freebsd.org>
Date: Thu, 06 Jun 2024 13:42:50 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277799

Ed Maste <emaste@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|usb@FreeBSD.org             |emaste@freebsd.org

--- Comment #3 from Ed Maste <emaste@freebsd.org> ---
AFAICT OpenOCD's 1.0.16 requirement comes from libjaylink and was introduced
in:

https://gitlab.zapb.de/libjaylink/libjaylink/-/commit/4959f4e18a2bb0de21abe66bbfe403b56f599856

which introduced use of

libusb_get_port_numbers
libusb_get_bus_number
The second one has existed forever, and it is apparently the addition of
libusb_get_port_numbers that added the 1.0.16 dependency.

libusb_get_port_numbers was introduced in libusb in

commit 4d7789be7e317fb2e89557f959c1a1a69cc01b26
Author: Hans de Goede <hdegoede@redhat.com>
Date:   Fri May 17 10:36:32 2013 +0200

    core: Add a new public libusb_get_port_numbers function

    This new function replaces the now deprecated libusb_get_port_path
function,
    as that is the only function operating on a libusb_device which also takes
    a libusb_context, which is rather inconsistent.

    Note we will keep libusb_get_port_path around in the 1.0.x for the
forseeable
    future for ABI compatibility reasons, but it should not be used in any new
    code.

    Signed-off-by: Hans de Goede <hdegoede@redhat.com>

and in FreeBSD in

commit a9205626a7e2f89486e637d6187ff99c17efeb10
Author: Ed Maste <emaste@FreeBSD.org>
Date:   Fri Jun 7 13:45:58 2013 +0000

    Add libusb_get_port_numbers

    libusbx deprecated libusb_get_port_path and replaced it with
    libusb_get_port_numbers.  The latter omits an extra parameter which was
    unused in the FreeBSD implementation anyway.

(Huh, I don't remember this.)

That said, bumping what we report to 1.0.16 seems reasonable enough; we can
fault in any missing but required functionality. Change added to Phabricator
review and exp-run requested in see-also PR.

-- 
You are receiving this mail because:
You are the assignee for the bug.