From nobody Sat Sep 09 14:07:46 2023 X-Original-To: freebsd-usb@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RjZZL0gZcz4slKP for ; Sat, 9 Sep 2023 14:08:10 +0000 (UTC) (envelope-from archimedes.gaviola@gmail.com) Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RjZZK0JmWz3MQM for ; Sat, 9 Sep 2023 14:08:09 +0000 (UTC) (envelope-from archimedes.gaviola@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20221208 header.b=lWCEb3L9; spf=pass (mx1.freebsd.org: domain of archimedes.gaviola@gmail.com designates 2a00:1450:4864:20::533 as permitted sender) smtp.mailfrom=archimedes.gaviola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-52a23227567so3902637a12.0 for ; Sat, 09 Sep 2023 07:08:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694268488; x=1694873288; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=JJD1BdJVHyvkb1I5MErZWGkGv7ClUSinrx14S5c7QVY=; b=lWCEb3L984HUQJSOHvSmHsZfbVhSrvhu8Ge6vQtrGRmAVaNwv1YQNhi/YXS+GFNtKw AZs9p7oe77JhmUVMVqc44mnmT0SH3d8GgOCJ8HoAvKZsssC8TZ1KXLYQzCVqzTHf41ve wQj87NrNmoQ2bVZsi31xeFBnYHggUClx83It9R+7W1QHG3CiqVJYfuM0UCDA0c7Duneq laA7LCkgjj510W3WP5RB6v9+uoFDHg0GYbntmAJ2WeKKzlCa8P3gyVWEZ7EWk5HHsGIr yPXDfbMxTM7L9uqqubp4XZ/6uoxwQQx286reJUm+vxXXFIVfdcI4X+JNOpuXNZJnTDux DVCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694268488; x=1694873288; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JJD1BdJVHyvkb1I5MErZWGkGv7ClUSinrx14S5c7QVY=; b=A9yBboABVEat3Ub0c4830QtEvMKp1Vg1N2NtXJUo6IZja3zzVu1OI8smjyZwRwkUei jnUuRZyHmtghGvhxWUiFnaAjT0Euc6/bSfQONqSUiM35NRwwlHaBeL+1PLBpHyEmvIgu PtzBPm6krlxV0gRjze2lOPez14+jJynO511VaLSiEN+0gmB2sUKjZchh6Rnx44uADaiH kfRcfl57g4bASVcvsHeq00KLpDrWJe/FphH7vI3KwZyoMubTX3MXbxgTP+/y4pdtwGKl 6NuMesHKTT5oNzE4XnWhUtRofZ9nnZ5/Uy48ZY+TPq/EMGavslIsZohy6rs5Wb/qJUP7 wvWw== X-Gm-Message-State: AOJu0YyCGdJ1DO2/TG3E85WxJpXCT/AAFq4bG1uggppKbjcI0i5+BKqb T9xvKfcwM5i6OaLUG12vXgtp1KKZ1XMMyeZg8PZydrOMICs= X-Google-Smtp-Source: AGHT+IFlYMWyxAgFd4ty5HmfxIst2BJlp9pQqZaRPtBdZQ2S29EnA06yBlOhdf49Cna8MDgRrGvZ6ofukXC1JtWA1AY= X-Received: by 2002:a17:907:2cf8:b0:9a9:d5d8:a6f1 with SMTP id hz24-20020a1709072cf800b009a9d5d8a6f1mr3760923ejc.38.1694268487275; Sat, 09 Sep 2023 07:08:07 -0700 (PDT) List-Id: FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-usb List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-usb@freebsd.org X-BeenThere: freebsd-usb@freebsd.org MIME-Version: 1.0 References: <20230909104540.01f60614@ernst.home> In-Reply-To: From: Archimedes Gaviola Date: Sat, 9 Sep 2023 22:07:46 +0800 Message-ID: Subject: Re: udl(4) patch for SIIG USB 2.0 DVI/VGA Pro support To: garyj@gmx.de Cc: freebsd-usb@freebsd.org Content-Type: multipart/alternative; boundary="00000000000056985e0604ed9fc8" X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.92 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-0.998]; NEURAL_HAM_SHORT(-0.92)[-0.920]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20221208]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; PREVIOUSLY_DELIVERED(0.00)[freebsd-usb@freebsd.org]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::533:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; FREEMAIL_ENVFROM(0.00)[gmail.com]; DKIM_TRACE(0.00)[gmail.com:+]; MID_RHS_MATCH_FROMTLD(0.00)[]; TO_DN_NONE(0.00)[]; MLMMJ_DEST(0.00)[freebsd-usb@freebsd.org]; RCPT_COUNT_TWO(0.00)[2]; FREEMAIL_TO(0.00)[gmx.de]; RCVD_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[] X-Rspamd-Queue-Id: 4RjZZK0JmWz3MQM --00000000000056985e0604ed9fc8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Sep 9, 2023 at 6:23=E2=80=AFPM Archimedes Gaviola < archimedes.gaviola@gmail.com> wrote: > > > On Sat, Sep 9, 2023 at 4:45=E2=80=AFPM Gary Jennejohn wrot= e: > >> On Sat, 9 Sep 2023 13:25:02 +0800 >> Archimedes Gaviola wrote: >> >> > On Tue, Sep 5, 2023 at 11:12?PM Archimedes Gaviola < >> > archimedes.gaviola@gmail.com> wrote: >> > >> > > Hi, >> > > >> > > I would like to submit some patches below for the SIIG USB 2.0 >> DVI/VGA Pro >> > > device support for the udl(4) video driver. You can see actual devic= e >> here >> > > https://www.siig.com/usb-2-0-to-dvi-vga-pro.html. This has been >> tested on >> > > both 14.0-ALPHA4 and 15.0-CURRENT in a compiled kernel and in the >> loadable >> > > module. Either way both are working. There are two files being >> patched (1) >> > > /usr/src/sys/dev/usb/usbdevs and (2) /usr/src/sys/dev/usb/video/udl.= c. >> > > These changes apply for both 14.0-ALPHA4 and 15.0-CURRENT. >> > > >> > > root@fbsd14a4:~ # uname -a >> > > FreeBSD fbsd14a4 14.0-ALPHA4 FreeBSD 14.0-ALPHA4 amd64 1400097 #0 >> > > stable/14-n265026-4c3f144478d4: Fri Sep 1 05:47:56 UTC 2023 >> > > root@releng1.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERI= C >> > > amd64 >> > > >> > > root@fbsd15:~ # uname -a >> > > FreeBSD fbsd15 15.0-CURRENT FreeBSD 15.0-CURRENT i386 1500000 #0 >> > > main-n265091-e04c4b4a369d: Thu Aug 31 03:48:01 UTC 2023 >> > > root@releng3.nyi.freebsd.org:/usr/obj/usr/src/i386.i386/sys/GENERIC >> i386 >> > > >> > > root@fbsd14a4:~ # diff -Nur /usr/src/sys/dev/usb/usbdevs.orig >> > > /usr/src/sys/dev/usb/usbdevs >> > > --- /usr/src/sys/dev/usb/usbdevs.orig 2023-09-03 04:16:01.45367900= 0 >> +0800 >> > > +++ /usr/src/sys/dev/usb/usbdevs 2023-09-03 09:23:33.84889700= 0 >> +0800 >> > > @@ -1808,6 +1808,7 @@ >> > > product DISPLAYLINK M01061 0x01e2 Lenovo DVI >> > > product DISPLAYLINK SWDVI 0x024c SUNWEIT DVI >> > > product DISPLAYLINK NBDOCK 0x0215 VideoHome NBdock1920 >> > > +product DISPLAYLINK AN2440D3 0x028f SIIG USB 2.0 DVI/VGA Pro >> > > product DISPLAYLINK LUM70 0x02a9 Lilliput UM-70 >> > > product DISPLAYLINK DVI_19 0x0360 USB to DVI-19 >> > > product DISPLAYLINK UM7X0 0x401a nanovision MiMo >> > > >> > > root@fbsd14a4:~ # diff -Nur /usr/src/sys/dev/usb/video/udl.c.orig >> > > /usr/src/sys/dev/usb/video/udl.c >> > > --- /usr/src/sys/dev/usb/video/udl.c.orig 2023-09-03 >> > > 04:15:21.204875000 +0800 >> > > +++ /usr/src/sys/dev/usb/video/udl.c 2023-09-03 09:25:23.89322800= 0 >> +0800 >> > > @@ -179,6 +179,7 @@ >> > > {USB_VPI(USB_VENDOR_DISPLAYLINK, >> USB_PRODUCT_DISPLAYLINK_LT1421, >> > > DLUNK)}, >> > > {USB_VPI(USB_VENDOR_DISPLAYLINK, USB_PRODUCT_DISPLAYLINK_ITE= C, >> > > DL165)}, >> > > {USB_VPI(USB_VENDOR_DISPLAYLINK, >> USB_PRODUCT_DISPLAYLINK_DVI_19, >> > > DL165)}, >> > > + {USB_VPI(USB_VENDOR_DISPLAYLINK, >> USB_PRODUCT_DISPLAYLINK_AN2440D3, >> > > DL195)}, >> > > >> > > Some relevant info below upon detection of the device after patched >> (only >> > > 14.0-ALPHA4 is shown as 15.0-CURRENT is the same). Because the >> videomode >> > > driver is also a dependency to the udl(4) driver, it is also able to >> detect >> > > my Dell VGA monitor for available screen resolutions and video modes= . >> > > >> > > root@fbsd14a4:~ # kldload udl >> > > root@fbsd14a4:~ # kldstat >> > > Id Refs Address Size Name >> > > 1 10 0xffffffff80200000 1d339a8 kernel >> > > 2 1 0xffffffff8261f000 3690 udl.ko >> > > 3 1 0xffffffff82623000 5028 videomode.ko >> > > >> > > root@fbsd14a4:~ # kldstat -v -n kernel | grep udl >> > > 107 udl/fbd >> > > 282 uhub/udl >> > > >> > > root@fbsd14a4:~ # dmesg >> > > ugen0.2: at usbus0 >> > > udl0 on uhub0 >> > > udl0: on >> usbus0 >> > > Vendor: [DEL] Dell >> > > Product: [2004] D1918H >> > > Serial number: GC2RW07C8PHX >> > > Manufactured 2019 Week 28 >> > > EDID Version 1.3 >> > > EDID Comment: >> > > Video Input: 68 >> > > Analog >> > > -0.7, 0.0V >> > > Separate syncs >> > > Gamma: 2.20 >> > > Max Size: 41 cm x 23 cm >> > > Features: 2a >> > > DPMS active-off >> > > RGB >> > > Preferred timing >> > > Chroma Info: >> > > Red X: 0.635 >> > > Red Y: 0.635 >> > > Grn X: 0.330 >> > > Grn Y: 0.627 >> > > Blu X: 0.155 >> > > Blu Y: 0.046 >> > > Wht X: 0.313 >> > > Wht Y: 0.329 >> > > Range: >> > > Horizontal: 30 - 83 kHz >> > > Vertical: 56 - 75 Hz >> > > Max Dot Clock: 135 MHz >> > > Video modes: >> > > 720x400 @ 70Hz (28320 738 846 900 412 414 449 -H +V) >> > > 640x480 @ 60Hz (25175 656 752 800 490 492 525 -H -V) >> > > 640x480 @ 75Hz (31500 656 720 840 481 484 500 -H -V) >> > > 800x600 @ 60Hz (40000 840 968 1056 601 605 628 +H +V) >> > > 800x600 @ 75Hz (49500 816 896 1056 601 604 625 +H +V) >> > > 1024x768 @ 60Hz (65000 1048 1184 1344 771 777 806 -H -V) >> > > 1024x768 @ 75Hz (78750 1040 1136 1312 769 772 800 +H +V) >> > > 1280x1024 @ 75Hz (135000 1296 1440 1688 1025 1028 1066 +H +V= ) >> > > 1366x768 @ 60Hz (85500 1436 1579 1792 771 774 798 +H +V) >> > > Preferred mode: 1366x768 @ 60Hz >> > > Number of extension blocks: 0 >> > > udl0: Mode selected 1280x1024 @ 75Hz >> > > fbd0 on udl0 >> > > >> > > root@fbsd14a4:~ # usbconfig -d ugen0.2 dump_device_desc >> > > ugen0.2: at usbus0, cfg=3D0 md=3DHOST spd=3DF= ULL >> (12Mbps) >> > > pwr=3DON (500mA) >> > > >> > > bLength =3D 0x0012 >> > > bDescriptorType =3D 0x0001 >> > > bcdUSB =3D 0x0110 >> > > bDeviceClass =3D 0x0000 >> > > bDeviceSubClass =3D 0x0000 >> > > bDeviceProtocol =3D 0x0000 >> > > bMaxPacketSize0 =3D 0x0040 >> > > idVendor =3D 0x17e9 >> > > idProduct =3D 0x028f >> > > bcdDevice =3D 0x0001 >> > > iManufacturer =3D 0x0001 >> > > iProduct =3D 0x0002 >> > > iSerialNumber =3D 0x0003 <111018> >> > > bNumConfigurations =3D 0x0001 >> > > >> > > root@fbsd14a4:~ # sysctl -a | grep udl >> > > udl0 on uhub0 >> > > udl0: on >> usbus0 >> > > udl0: Mode selected 1280x1024 @ 75Hz >> > > fbd0 on udl0 >> > > device udl >> > > hw.usb.udl.fps: 25 >> > > hw.usb.udl.debug: 0 >> > > dev.fbd.0.%parent: udl0 >> > > dev.udl.0.mode: 17 >> > > dev.udl.0.mode_force: -1 >> > > dev.udl.0.chipid: 4 >> > > dev.udl.0.chipid_force: -1 >> > > dev.udl.0.%parent: uhub0 >> > > dev.udl.0.%pnpinfo: vendor=3D0x17e9 product=3D0x028f devclass=3D0x00 >> > > devsubclass=3D0x00 devproto=3D0x00 sernum=3D"111018" release=3D0x000= 1 >> mode=3Dhost >> > > intclass=3D0xff intsubclass=3D0x00 intprotocol=3D0x00 >> > > dev.udl.0.%location: bus=3D0 hubaddr=3D1 port=3D1 devaddr=3D2 interf= ace=3D0 >> > > ugen=3Dugen0.2 >> > > dev.udl.0.%driver: udl >> > > dev.udl.0.%desc: DisplayLink AN2440D3, class 0/0, rev 1.10/0.01, add= r >> 2 >> > > dev.udl.%parent: >> > > >> > > Lastly, I would also submit a patch for the udl(4) manual for update= . >> > > First, there's a need to include DL-195 in the description since thi= s >> model >> > > is the chipset of SIIG USB 2.0 DVI/VGA Pro which is working as teste= d. >> > > Second, the udl(4) driver must be accompanied with the videomode >> driver >> > > otherwise kernel compilation will fail and third, adding the SIIG US= B >> 2.0 >> > > DVI/VGA Pro device in the list. >> > > >> > > root@fbsd14a4:~ # diff -Nur udl-manual.orig udl-manual >> > > --- udl-manual.orig 2023-08-18 00:13:25.583021000 +0000 >> > > +++ udl-manual 2023-08-18 15:06:41.896163000 +0000 >> > > @@ -1,13 +1,14 @@ >> > > UDL(4) FreeBSD Kernel Interfaces Manual >> > > UDL(4) >> > > >> > > NAME >> > > - udl ? DisplayLink DL-120 / DL-160 USB display devices >> > > + udl ? DisplayLink DL-120 / DL-160 / DL-195 USB display devices >> > > >> > > SYNOPSIS >> > > - To compile this driver into the kernel, place the following >> line in >> > > your >> > > + To compile this driver into the kernel, place the following >> lines in >> > > your >> > > kernel configuration file: >> > > >> > > device udl >> > > + device videomode >> > > >> > > Alternatively, to load the driver as a module at boot time, >> place the >> > > following line in loader.conf(5): >> > > @@ -16,7 +17,7 @@ >> > > >> > > DESCRIPTION >> > > The udl driver supports USB display devices based on the >> DisplayLink >> > > - DL-120 / DL-160 graphic chip. >> > > + DL-120 / DL-160 / DL-195 graphic chip. >> > > >> > > HARDWARE >> > > The following devices should work: >> > > @@ -40,6 +41,7 @@ >> > > Unitek Y-2240 USB to DVI >> > > VideoHome NBdock1920 >> > > i-tec USB 2.0 Docking Station (USBDVIDOCK) >> > > + SIIG USB 2.0 DVI/VGA Pro >> > > >> > > Thanks, >> > > Archimedes >> > > >> > >> > Hi, >> > >> > By the way, should I post this patch to the Phabricator >> > https://reviews.freebsd.org for review? The other patch is related to >> the >> > manual, where to post it as well? >> > >> >> Posting the patches to Phabricator would be a good idea. It might get >> more attention that way. >> >> Since the manpage is also relevant to the driver I would recommend >> putting it in the Phabricator entry along with the USB driver patches. >> >> Once you've created the Phabricator entry you should post its number. >> >> -- >> Gary Jennejohn >> > > Hi Gary, > > Thanks for your response! I will post both the USB driver patches along > with its manpage in the Phabricator. I'll create a new diff and post its > number back here. > > Thanks, > Archimedes > Hi Gary, I already posted the patch here https://reviews.freebsd.org/D41798 however, submission requires reviewers. Any idea who should be the designated reviewers for this? Thanks, Archimedes --00000000000056985e0604ed9fc8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sat, Sep 9, 2023 at 6:23=E2=80=AFP= M Archimedes Gaviola <ar= chimedes.gaviola@gmail.com> wrote:


<= div class=3D"gmail_quote">
On Sat, Sep= 9, 2023 at 4:45=E2=80=AFPM Gary Jennejohn <garyj@gmx.de> wrote:
On Sat, 9 Sep 2023 13:25:02 +0800
Archimedes Gaviola <archimedes.gaviola@gmail.com> wrote:

> On Tue, Sep 5, 2023 at 11:12?PM Archimedes Gaviola <
> arch= imedes.gaviola@gmail.com> wrote:
>
> > Hi,
> >
> > I would like to submit some patches below for the SIIG USB 2.0 DV= I/VGA Pro
> > device support for the udl(4) video driver. You can see actual de= vice here
> > https://www.siig.com/usb-2-0-to-dvi-vga-p= ro.html. This has been tested on
> > both 14.0-ALPHA4 and 15.0-CURRENT in a compiled kernel and in the= loadable
> > module. Either way both are working. There are two files being pa= tched (1)
> > /usr/src/sys/dev/usb/usbdevs and (2) /usr/src/sys/dev/usb/video/u= dl.c.
> > These changes apply for both 14.0-ALPHA4 and 15.0-CURRENT.
> >
> > root@fbsd14a4:~ # uname -a
> > FreeBSD fbsd14a4 14.0-ALPHA4 FreeBSD 14.0-ALPHA4 amd64 1400097 #0=
> > stable/14-n265026-4c3f144478d4: Fri Sep=C2=A0 1 05:47:56 UTC 2023=
> > root@releng1.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GEN= ERIC
> > amd64
> >
> > root@fbsd15:~ # uname -a
> > FreeBSD fbsd15 15.0-CURRENT FreeBSD 15.0-CURRENT i386 1500000 #0<= br> > > main-n265091-e04c4b4a369d: Thu Aug 31 03:48:01 UTC 2023
> > root@releng3.nyi.freebsd.org:/usr/obj/usr/src/i386.i386/sys/GENER= IC i386
> >
> > root@fbsd14a4:~ # diff -Nur /usr/src/sys/dev/usb/usbdevs.orig
> > /usr/src/sys/dev/usb/usbdevs
> > --- /usr/src/sys/dev/usb/usbdevs.orig=C2=A0 =C2=A02023-09-03 04:1= 6:01.453679000 +0800
> > +++ /usr/src/sys/dev/usb/usbdevs=C2=A0 =C2=A0 =C2=A0 =C2=A0 2023-= 09-03 09:23:33.848897000 +0800
> > @@ -1808,6 +1808,7 @@
> >=C2=A0 product DISPLAYLINK M01061=C2=A0 =C2=A0 =C2=A00x01e2=C2=A0 = Lenovo DVI
> >=C2=A0 product DISPLAYLINK SWDVI=C2=A0 =C2=A0 =C2=A0 0x024c=C2=A0 = SUNWEIT DVI
> >=C2=A0 product DISPLAYLINK NBDOCK=C2=A0 =C2=A0 =C2=A00x0215=C2=A0 = VideoHome NBdock1920
> > +product DISPLAYLINK AN2440D3=C2=A0 =C2=A00x028f=C2=A0 SIIG USB 2= .0 DVI/VGA Pro
> >=C2=A0 product DISPLAYLINK LUM70=C2=A0 =C2=A0 =C2=A0 0x02a9=C2=A0 = Lilliput UM-70
> >=C2=A0 product DISPLAYLINK DVI_19=C2=A0 =C2=A0 =C2=A00x0360=C2=A0 = USB to DVI-19
> >=C2=A0 product DISPLAYLINK UM7X0=C2=A0 =C2=A0 =C2=A0 0x401a=C2=A0 = nanovision MiMo
> >
> > root@fbsd14a4:~ # diff -Nur /usr/src/sys/dev/usb/video/udl.c.orig=
> > /usr/src/sys/dev/usb/video/udl.c
> > --- /usr/src/sys/dev/usb/video/udl.c.orig=C2=A0 =C2=A0 =C2=A0 =C2= =A02023-09-03
> > 04:15:21.204875000 +0800
> > +++ /usr/src/sys/dev/usb/video/udl.c=C2=A0 =C2=A0 2023-09-03 09:2= 5:23.893228000 +0800
> > @@ -179,6 +179,7 @@
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{USB_VPI(USB_VENDOR_DISPLAYLINK,= USB_PRODUCT_DISPLAYLINK_LT1421,
> > DLUNK)},
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{USB_VPI(USB_VENDOR_DISPLAYLINK,= USB_PRODUCT_DISPLAYLINK_ITEC,
> > DL165)},
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{USB_VPI(USB_VENDOR_DISPLAYLINK,= USB_PRODUCT_DISPLAYLINK_DVI_19,
> > DL165)},
> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0{USB_VPI(USB_VENDOR_DISPLAYLINK, USB_= PRODUCT_DISPLAYLINK_AN2440D3,
> > DL195)},
> >
> > Some relevant info below upon detection of the device after patch= ed (only
> > 14.0-ALPHA4 is shown as 15.0-CURRENT is the same). Because the vi= deomode
> > driver is also a dependency to the udl(4) driver, it is also able= to detect
> > my Dell VGA monitor for available screen resolutions and video mo= des.
> >
> > root@fbsd14a4:~ # kldload udl
> > root@fbsd14a4:~ # kldstat
> > Id Refs Address=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 Size Name
> >=C2=A0 1=C2=A0 =C2=A010 0xffffffff80200000=C2=A0 1d339a8 kernel > >=C2=A0 2=C2=A0 =C2=A0 1 0xffffffff8261f000=C2=A0 =C2=A0 =C2=A03690= udl.ko
> >=C2=A0 3=C2=A0 =C2=A0 1 0xffffffff82623000=C2=A0 =C2=A0 =C2=A05028= videomode.ko
> >
> > root@fbsd14a4:~ # kldstat -v -n kernel | grep udl
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0107 = udl/fbd
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0282 = uhub/udl
> >
> > root@fbsd14a4:~ # dmesg
> > ugen0.2: <DisplayLink AN2440D3> at usbus0
> > udl0 on uhub0
> > udl0: <DisplayLink AN2440D3, class 0/0, rev 1.10/0.01, addr 2&= gt; on usbus0
> > Vendor: [DEL] Dell
> > Product: [2004] D1918H
> > Serial number: GC2RW07C8PHX
> > Manufactured 2019 Week 28
> > EDID Version 1.3
> > EDID Comment:
> > Video Input: 68
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Analog
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-0.7, 0.0V
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Separate syncs
> > Gamma: 2.20
> > Max Size: 41 cm x 23 cm
> > Features: 2a
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0DPMS active-off
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0RGB
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Preferred timing
> > Chroma Info:
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Red X: 0.635
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Red Y: 0.635
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Grn X: 0.330
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Grn Y: 0.627
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Blu X: 0.155
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Blu Y: 0.046
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Wht X: 0.313
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Wht Y: 0.329
> > Range:
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Horizontal: 30 - 83 kHz
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Vertical: 56 - 75 Hz
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Max Dot Clock: 135 MHz
> > Video modes:
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0720x400 @ 70Hz (28320 738 846 90= 0 412 414 449 -H +V)
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0640x480 @ 60Hz (25175 656 752 80= 0 490 492 525 -H -V)
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0640x480 @ 75Hz (31500 656 720 84= 0 481 484 500 -H -V)
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0800x600 @ 60Hz (40000 840 968 10= 56 601 605 628 +H +V)
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0800x600 @ 75Hz (49500 816 896 10= 56 601 604 625 +H +V)
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A01024x768 @ 60Hz (65000 1048 1184= 1344 771 777 806 -H -V)
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A01024x768 @ 75Hz (78750 1040 1136= 1312 769 772 800 +H +V)
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A01280x1024 @ 75Hz (135000 1296 14= 40 1688 1025 1028 1066 +H +V)
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A01366x768 @ 60Hz (85500 1436 1579= 1792 771 774 798 +H +V)
> > Preferred mode: 1366x768 @ 60Hz
> > Number of extension blocks: 0
> > udl0: Mode selected 1280x1024 @ 75Hz
> > fbd0 on udl0
> >
> > root@fbsd14a4:~ # usbconfig -d ugen0.2 dump_device_desc
> > ugen0.2: <DisplayLink AN2440D3> at usbus0, cfg=3D0 md=3DHOS= T spd=3DFULL (12Mbps)
> > pwr=3DON (500mA)
> >
> >=C2=A0 =C2=A0bLength =3D 0x0012
> >=C2=A0 =C2=A0bDescriptorType =3D 0x0001
> >=C2=A0 =C2=A0bcdUSB =3D 0x0110
> >=C2=A0 =C2=A0bDeviceClass =3D 0x0000=C2=A0 <Probed by interface= class>
> >=C2=A0 =C2=A0bDeviceSubClass =3D 0x0000
> >=C2=A0 =C2=A0bDeviceProtocol =3D 0x0000
> >=C2=A0 =C2=A0bMaxPacketSize0 =3D 0x0040
> >=C2=A0 =C2=A0idVendor =3D 0x17e9
> >=C2=A0 =C2=A0idProduct =3D 0x028f
> >=C2=A0 =C2=A0bcdDevice =3D 0x0001
> >=C2=A0 =C2=A0iManufacturer =3D 0x0001=C2=A0 <DisplayLink> > >=C2=A0 =C2=A0iProduct =3D 0x0002=C2=A0 <AN2440D3>
> >=C2=A0 =C2=A0iSerialNumber =3D 0x0003=C2=A0 <111018>
> >=C2=A0 =C2=A0bNumConfigurations =3D 0x0001
> >
> > root@fbsd14a4:~ # sysctl -a | grep udl
> > udl0 on uhub0
> > udl0: <DisplayLink AN2440D3, class 0/0, rev 1.10/0.01, addr 2&= gt; on usbus0
> > udl0: Mode selected 1280x1024 @ 75Hz
> > fbd0 on udl0
> > device=C2=A0 udl
> > hw.usb.udl.fps: 25
> > hw.usb.udl.debug: 0
> > dev.fbd.0.%parent: udl0
> > dev.udl.0.mode: 17
> > dev.udl.0.mode_force: -1
> > dev.udl.0.chipid: 4
> > dev.udl.0.chipid_force: -1
> > dev.udl.0.%parent: uhub0
> > dev.udl.0.%pnpinfo: vendor=3D0x17e9 product=3D0x028f devclass=3D0= x00
> > devsubclass=3D0x00 devproto=3D0x00 sernum=3D"111018" re= lease=3D0x0001 mode=3Dhost
> > intclass=3D0xff intsubclass=3D0x00 intprotocol=3D0x00
> > dev.udl.0.%location: bus=3D0 hubaddr=3D1 port=3D1 devaddr=3D2 int= erface=3D0
> > ugen=3Dugen0.2
> > dev.udl.0.%driver: udl
> > dev.udl.0.%desc: DisplayLink AN2440D3, class 0/0, rev 1.10/0.01, = addr 2
> > dev.udl.%parent:
> >
> > Lastly, I would also submit a patch for the udl(4) manual for upd= ate.
> > First, there's a need to include DL-195 in the description si= nce this model
> > is the chipset of SIIG USB 2.0 DVI/VGA Pro which is working as te= sted.
> > Second, the udl(4) driver must be accompanied with the videomode = driver
> > otherwise kernel compilation will fail and third, adding the SIIG= USB 2.0
> > DVI/VGA Pro device in the list.
> >
> > root@fbsd14a4:~ # diff -Nur udl-manual.orig udl-manual
> > --- udl-manual.orig=C2=A0 =C2=A0 =C2=A02023-08-18 00:13:25.583021= 000 +0000
> > +++ udl-manual=C2=A0 2023-08-18 15:06:41.896163000 +0000
> > @@ -1,13 +1,14 @@
> >=C2=A0 UDL(4)=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0FreeBSD Kernel Interfaces Manual
> > UDL(4)
> >
> >=C2=A0 NAME
> > -=C2=A0 =C2=A0 =C2=A0udl ? DisplayLink DL-120 / DL-160 USB displa= y devices
> > +=C2=A0 =C2=A0 =C2=A0udl ? DisplayLink DL-120 / DL-160 / DL-195 U= SB display devices
> >
> >=C2=A0 SYNOPSIS
> > -=C2=A0 =C2=A0 =C2=A0To compile this driver into the kernel, plac= e the following line in
> > your
> > +=C2=A0 =C2=A0 =C2=A0To compile this driver into the kernel, plac= e the following lines in
> > your
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0kernel configuration file:
> >
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0device udl
> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0device videomode
> >
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0Alternatively, to load the driver as a = module at boot time, place the
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0following line in loader.conf(5):
> > @@ -16,7 +17,7 @@
> >
> >=C2=A0 DESCRIPTION
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0The udl driver supports USB display dev= ices based on the DisplayLink
> > -=C2=A0 =C2=A0 =C2=A0DL-120 / DL-160 graphic chip.
> > +=C2=A0 =C2=A0 =C2=A0DL-120 / DL-160 / DL-195 graphic chip.
> >
> >=C2=A0 HARDWARE
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0The following devices should work:
> > @@ -40,6 +41,7 @@
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Unitek Y-2240 USB = to DVI
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0VideoHome NBdock19= 20
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0i-tec USB 2.0 Dock= ing Station (USBDVIDOCK)
> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0SIIG USB 2.0 DVI/VGA Pr= o
> >
> > Thanks,
> > Archimedes
> >
>
> Hi,
>
> By the way, should I post this patch to the Phabricator
> https://reviews.freebsd.org for review? The other patch is relat= ed to the
> manual, where to post it as well?
>

Posting the patches to Phabricator would be a good idea.=C2=A0 It might get=
more attention that way.

Since the manpage is also relevant to the driver I would recommend
putting it in the Phabricator entry along with the USB driver patches.

Once you've created the Phabricator entry you should post its number.
--
Gary Jennejohn

Hi Gary,

<= /div>
Thanks for your response! I will post both the USB driver patches= along with its manpage in the Phabricator. I'll create a new diff and = post its number back here.

Thanks,
A= rchimedes

Hi Gary,

I already posted the patch here=C2=A0https://reviews.freebsd.org/D41798 howe= ver, submission requires reviewers. Any idea who should be the designated r= eviewers for this?

Thanks,
Archimedes
--00000000000056985e0604ed9fc8--