From nobody Tue Nov 14 15:48:59 2023 X-Original-To: freebsd-usb@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SV9hC3ZbLz51MkK for ; Tue, 14 Nov 2023 15:48:59 +0000 (UTC) (envelope-from ronald@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SV9hB718Hz3g2T for ; Tue, 14 Nov 2023 15:48:58 +0000 (UTC) (envelope-from ronald@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699976939; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ohSlTw4B4/gXrmwbXNB+Y5d+FLQ162xi/SSCFdeI2ow=; b=muJ3LbFM+GIHV2m9fRVOt3yrZtl89ht1K9yJd7wAuSzSYa+DqCHA1eNiDBwhIbUUqBiOpi WC++zsuMZQW1ND5Yak0bOarQpXgkrDlILuPhEUS0XuojEQs8ZrDwwOn/FrR5Ncc3nffhMf 7TUc9CcctqN4BudFXgP6VwCIW7joDveHpuXvZQwaLToeL4PVic9wMKf9sBrnb5w8PL8BDZ Lc7Rw2GEd0s72E4EDXKfWDmxWA9dG6JlP0aR8Cu+uRFUZtANT3n+lN9e5yx18KTCjsHcgb NNi2Ib4qY/eEEhJcPEgacWlu43up8nhRTGysWH/5UsJal/wEsJBop1EH1wgSZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699976939; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ohSlTw4B4/gXrmwbXNB+Y5d+FLQ162xi/SSCFdeI2ow=; b=gYhCFvpQd9P7khvHKZRgY4k/RIcNNiy1Af9NiOynpZcE8bPi0suJvfNn+5mXqM0exI/BT6 FGwe12bAJL1USEtk72pY6LIN8YYMxKfqVb21fk80ZvOhe8dkp+hFjPMzlIwthPBCQKRrK0 ip1JMcN6LrmEQOtYWX+clJYLd31JbYUkGWeOoWAwF6V085nKepyh2wl2oQTRsW17CF6s2y ahPACit17nRuGGajAUynnjx66dxy0AG6WTY4xsrQ0mEYkaDpeWVxdRdvTfde5qt2ZjR7Ma WRgypLIQgKJEMNhhmqTKZj5IJzqMs2r15BbPx/JxPu4pBphw216zzWKxBzkbDQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699976939; a=rsa-sha256; cv=none; b=jf0hyjKZFCeWEVel6GhJmJxmWhR5GItrLb6B4j5l0qnIdFRyfqpYJe+QSo8SuAOwFa2gfv oVpEhkPrNBxZr8IuZpROzXjd733MYaZG3VSyYK8wQguhGfWAJuGJLjHBpzHM2+ZhAd3slU FzvilSNyxM3mjcxSj6B3WbVDpDDqch6+Ygh+omhc4WnpoJ0mCjfgyilt1yVdUWql0XSJYd 0BCpBHlssq00eirHG8hd6yGVl/E9T9Mp2q2XA1Dn0X87Ky2aSSpKm57+HuJoo07+NgsgZe ysWnPfUq2nu9MM2ypgFBUZ0xVZl/kWbWwR4lzYc3CR9ryLbWoepB6WF2R/Z7Dw== Received: from [IPV6:2001:1c00:2709:2010:74a9:924b:9b61:cfca] (2001-1c00-2709-2010-74a9-924b-9b61-cfca.cable.dynamic.v6.ziggo.nl [IPv6:2001:1c00:2709:2010:74a9:924b:9b61:cfca]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: ronald/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SV9hB4jDXz142v for ; Tue, 14 Nov 2023 15:48:58 +0000 (UTC) (envelope-from ronald@FreeBSD.org) Content-Type: multipart/alternative; boundary="------------iq7gWjYYCBFg7h5jOJsaAqJ1" Message-ID: <73ee423c-be5f-458b-ab95-89264afd89b3@FreeBSD.org> Date: Tue, 14 Nov 2023 16:48:59 +0100 List-Id: FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-usb List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-usb@freebsd.org X-BeenThere: freebsd-usb@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Ronald Klop Subject: Fwd: Re: reviewers for if_smsc change? References: Content-Language: en-US To: freebsd-usb@freebsd.org In-Reply-To: This is a multi-part message in MIME format. --------------iq7gWjYYCBFg7h5jOJsaAqJ1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 SGksDQoNCg0KSSBoYXZlIHNtYWxsIGZlYXR1cmUgZm9yIGEgVVNCIG5ldHdvcmsgZHJpdmVy LiBJbiB0aGUgcmV2aWV3IGl0IGlzIG1lbnRpb25lZCB0aGF0IGl0IHdvdWxkIGhlbHAgaWYg c29tZWJvZHkgZmFtaWxpYXIgd2l0aCB0aGUgVVNCIHN0YWNrIHdvdWxkIHRha2UgYSBsb29r Lg0KRG9lcyBhbnlib2R5IGhhdmUgdGhlIHRpbWUgZm9yIHRoaXM/DQoNClJlZ2FyZHMsDQpS b25hbGQuDQoNCipWYW46KiBNaWtlIEthcmVscyA8bWlrZUBrYXJlbHMubmV0Pg0KKkRhdHVt OiogZG9uZGVyZGFnLCA5IG5vdmVtYmVyIDIwMjMgMTM6MzQNCipBYW46KiBSb25hbGQgS2xv cCA8cm9uYWxkQEZyZWVCU0Qub3JnPg0KKkNDOiogZnJlZWJzZC1uZXRAZnJlZWJzZC5vcmcN CipPbmRlcndlcnA6KiBSZTogcmV2aWV3ZXJzIGZvciBpZl9zbXNjIGNoYW5nZT8NCg0KICAg IE9uIDkgTm92IDIwMjMsIGF0IDQ6MzAsIFJvbmFsZCBLbG9wIHdyb3RlOg0KDQogICAgID4g T24gMTEvNC8yMyAxNTozOSwgUm9uYWxkIEtsb3Agd3JvdGU6DQogICAgID4+IEhpLA0KICAg ICA+Pg0KICAgICA+PiBGb3IgaXNzdWUgMjc0MDkyIFsxXSBJJ20gbG9va2luZyBmb3IgcmV2 aWV3ZXJzLg0KICAgICA+Pg0KICAgICA+PiBBIHVzZXIgb24gdGhlIE1MIGhhZCBhbiBpc3N1 ZSB0aGF0IHRoZSBNQUMgYWRkcmVzcyB3YXMgbm90IGFzc2lnbmVkIG9uIHNvbWUgUmFzcGJl cnJ5IFBJIGNvbXB1dGUgbW9kdWxlcy4NCiAgICAgPj4gSSB0cmllZCBhbmQgc3VjY2VlZGVk IGluIHVzaW5nIHRoZSBNQUMgYWRkcmVzcyBwYXNzZWQgb24gZnJvbSB0aGUgZmlybXdhcmUg dG8gdGhlIGtlcm5lbC4NCiAgICAgPj4NCiAgICAgPj4gVGhlIHJldmlldyBpcyBpbjogaHR0 cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL0Q0MjQ2Mw0KICAgICA+Pg0KICAgICA+PiBJIGhh dmUgYSBwb3J0cyBjb21taXQgYml0IGlmIHBvc3NpYmxlIEkgd291bGQgbGlrZSBpdCB0byBj b21taXQgdGhpcyBteXNlbGYgYXMgZmlyc3Qgc3RlcHMgaW4gbW9yZSBpbiBkZXB0aCBGcmVl QlNEIGRldmVsb3BtZW50Lg0KICAgICA+Pg0KICAgICA+PiBSZWdhcmRzLA0KICAgICA+PiBS b25hbGQuDQogICAgID4+DQogICAgID4+DQogICAgID4+IFsxXSBodHRwczovL2J1Z3MuZnJl ZWJzZC5vcmcvYnVnemlsbGEvc2hvd19idWcuY2dpP2lkPTI3NDA5MiAoaWZfc21zYy5jIG5l ZWRzIHRvIHVzZSBldGhlcl9nZW5fYWRkciBpbnN0ZWFkIG9mIHJlYWRfcmFuZG9tIGZvciBt b3JlIHN0YWJsZSBNQUMgYWRkcmVzcykNCiAgICAgPj4NCiAgICAgPg0KICAgICA+DQogICAg ID4gSGksDQogICAgID4NCiAgICAgPiBJIGdvdCBzb21lIGNvbW1lbnRzIG9uIHRoZSBwaGFi cmljYXRvciByZXZpZXcgYW5kIHVwZGF0ZWQgdGhlIHBhdGNoIHdpdGggaXQuIEkgdGhpbmsg aXQgaXMgcHJldHR5IGNsZWFuIG5vdyBhbmQgaXQgaXMgdGVzdGVkIGFuZCB3b3Jrcy4NCiAg ICAgPiBIb3cgc2hvdWxkIEkgZ28gZnJvbSBoZXJlPw0KICAgICA+IENhbiBzb21lYm9keSBo ZWxwIG1lIGNvbW1pdCB0aGlzIChJIGFtIGEgcG9ydHMgY29tbWl0dGVyKSBvciBjb21taXQg dGhpcyBmb3IgbWU/DQogICAgID4gRG8gSSBuZWVkIG1vcmUgYXBwcm92YWwgYW5kIGlmIHll cywgaG93IGNhbiBJIGdldCB0aGF0Pw0KICAgICA+DQogICAgID4gUmVnYXJkcywNCiAgICAg PiBSb25hbGQuDQoNCiAgICBUaGUgY2hhbmdlIGxvb2tzIGdvb2QgdG8gbWUgbm93LiDCoEkg dGhpbmsgaXQgd291bGQgYmUgZ29vZCBpZiBzb21lb25lIHdobw0KICAgIHdvcmtzIG9uIFVT QiBsb29rZWQgYXQgaXQgdG9vLiDCoEkgYW0gd2lsbGluZyB0byBhcHByb3ZlIHRoZSBjaGFu Z2U7IEkgdGhpbmsNCiAgICB5b3UgY2FuIGNvbW1pdCBpdCB3aXRoIGFwcHJvdmFsLg0KDQog ICAgIMKgwqDCoMKgwqDCoMKgwqBNaWtlDQogICAgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQoNCg0K --------------iq7gWjYYCBFg7h5jOJsaAqJ1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi,


I have small feature for a USB network driver. In the review it is mentioned that it would help if somebody familiar with the USB stack would take a look.
Does anybody have the time for this?

Regards,
Ronald.

 

Van: Mike Karels <mike@karels.net>
Datum: donderdag, 9 november 2023 13:34
Aan: Ronald Klop <ronald@FreeBSD.org>
CC: freebsd-net@freebsd.org
Onderwerp: Re: reviewers for if_smsc change?

On 9 Nov 2023, at 4:30, Ronald Klop wrote:

> On 11/4/23 15:39, Ronald Klop wrote:
>> Hi,
>>
>> For issue 274092 [1] I'm looking for reviewers.
>>
>> A user on the ML had an issue that the MAC address was not assigned on some Raspberry PI compute modules.
>> I tried and succeeded in using the MAC address passed on from the firmware to the kernel.
>>
>> The review is in: https://reviews.freebsd.org/D42463
>>
>> I have a ports commit bit if possible I would like it to commit this myself as first steps in more in depth FreeBSD development.
>>
>> Regards,
>> Ronald.
>>
>>
>> [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274092 (if_smsc.c needs to use ether_gen_addr instead of read_random for more stable MAC address)
>>
>
>
> Hi,
>
> I got some comments on the phabricator review and updated the patch with it. I think it is pretty clean now and it is tested and works.
> How should I go from here?
> Can somebody help me commit this (I am a ports committer) or commit this for me?
> Do I need more approval and if yes, how can I get that?
>
> Regards,
> Ronald.

The change looks good to me now.  I think it would be good if someone who
works on USB looked at it too.  I am willing to approve the change; I think
you can commit it with approval.

        Mike

  --------------iq7gWjYYCBFg7h5jOJsaAqJ1--