From nobody Sat Jun 01 01:39:44 2024 X-Original-To: toolchain@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VrjN01tGpz5Ls4v for ; Sat, 01 Jun 2024 01:39:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VrjMz6Sbsz429M for ; Sat, 1 Jun 2024 01:39:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1717205983; a=rsa-sha256; cv=none; b=eipCqcah1/Wsr6BEofOAucTWMh7ZAmr7NexvTwYXy912R2xe0fEHMKNVYDvRS2jYny0HGL Iz7KyFuAgFveTA5brYOcRRt8h5ZI8tdnPtB9jDyhtquJDRe6otP9hkvw5WVrdpqJkELLMn vVNthKDXtla5OaBF0ad6NCFvBxUAbKCPiTjcOruqM9QvDjYceeiOdngN/DqRY/ECBUq81j P6cyEDo8HYoVv1vZ7Th8Q0Cy+NwqKyApuHihV/N35Kstsn8MBRMFx6asof6OXG4ZgzRYRq U6T/5DMgkgpmT37fBMfTYra00KlZELpIWtyUXMY2A/8SgMQJwa/FY9FLTnLj+w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1717205983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hIpmdIITPEMFIrXP10yNrv0dG7tzgwfjoUT61KRMl/M=; b=mb7csQnq2MzzyuoiVnagpJzEFJWTDGEDVE/Ny5ZTBL6obFBZKwt1d4QqSGXhUAYz+Cmy8f ET6Z1ayiMsE/erKbLeqEzsTYWL2/0UDOhRiFWXnAa9sbD0YUG3Ab61lKMinDmo5nxszDRh G+IBT/Se/gtyWjRrTT48MQpR2ZCzwPhqb3+V1kg7NhSVcXf5ltyKBr+2pd7PFQMMQsZ43+ SI7Z23tZoR4X/82uTQQJaSyAdCfRi0RCbaq1lI7zAFF5sTxNWO71CMCYqXT3L1fwI/Ae0f 6SoHq0xlcDu1P+6AdCLYiz4LfOLJZ6FFZjyP6Zox4AQtWRPJOTlMjNN+/84WQw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VrjMz648fznqV for ; Sat, 1 Jun 2024 01:39:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4511dhsV052991 for ; Sat, 1 Jun 2024 01:39:43 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4511dhW3052989 for toolchain@FreeBSD.org; Sat, 1 Jun 2024 01:39:43 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: toolchain@FreeBSD.org Subject: [Bug 279443] LIBCPP assertions are enabled in optimized builds when -DNDEBUG is given to clang Date: Sat, 01 Jun 2024 01:39:44 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: misc X-Bugzilla-Version: 14.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: marklmi26-fbsd@yahoo.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: toolchain@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Maintenance of FreeBSD s integrated toolchain List-Archive: https://lists.freebsd.org/archives/freebsd-toolchain List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-toolchain@freebsd.org Sender: owner-freebsd-toolchain@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D279443 --- Comment #5 from Mark Millard --- (In reply to Yuri Victorovich from comment #4) FYI: for NDEBUG vs. _LIBCPP_HARDENING_MODE # grep -r "NDEBUG" /usr/include/c++/v1/ | more /usr/include/c++/v1/module.modulemap: // 's use of NDEBUG requires textual inclusion. Nothing in the standards say that the C++ standard library has to ever use assert from . NDEBUG is only defined relative to and its assert use, not for any other context. _LIBCPP_ASSERT_VALID_ELEMENT_ACCESS does not tra= ce back to a use of assert in the libc++ code. # grep -r "cassert" /usr/include/c++/v1/ | more /usr/include/c++/v1/cassert: cassert synopsis /usr/include/c++/v1/__std_clang_module:#include /usr/include/c++/v1/module.modulemap:module std_cassert [system] { /usr/include/c++/v1/module.modulemap: // 's use of NDEBUG requires textual inclusion. /usr/include/c++/v1/module.modulemap: textual header "cassert" libc++ does not use or its assert(. . .), which is completely standard compliant. There is a separate libc++ specific mechanism that does not involve assert = or NDEBUG : alternate values for _LIBCPP_HARDENING_MODE /usr/include/c++/v1/__config indicates: // The library provides the macro `_LIBCPP_HARDENING_MODE` which can be set= to one of the following values: // // - `_LIBCPP_HARDENING_MODE_NONE`; // - `_LIBCPP_HARDENING_MODE_FAST`; // - `_LIBCPP_HARDENING_MODE_EXTENSIVE`; // - `_LIBCPP_HARDENING_MODE_DEBUG`. // // These values have the following effects: // // - `_LIBCPP_HARDENING_MODE_NONE` -- sets the hardening mode to "none" whi= ch disables all runtime hardening checks; //=20 // - `_LIBCPP_HARDENING_MODE_FAST` -- sets that hardening mode to "fast". T= he fast mode enables security-critical checks // that can be done with relatively little runtime overhead in constant t= ime; // // - `_LIBCPP_HARDENING_MODE_EXTENSIVE` -- sets the hardening mode to "extensive". The extensive mode is a superset of // the fast mode that additionally enables checks that are relatively che= ap and prevent common types of logic errors // but are not necessarily security-critical; // // - `_LIBCPP_HARDENING_MODE_DEBUG` -- sets the hardening mode to "debug". = The debug mode is a superset of the extensive // mode and enables all checks available in the library, including intern= al assertions. Checks that are part of the // debug mode can be very expensive and thus the debug mode is intended t= o be used for testing, not in production. --=20 You are receiving this mail because: You are the assignee for the bug.=