From nobody Sun Dec 31 16:49:56 2023 X-Original-To: threads@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T34pr6lbzz5666l for ; Sun, 31 Dec 2023 16:49:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T34pr53gGz4dN1 for ; Sun, 31 Dec 2023 16:49:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704041396; a=rsa-sha256; cv=none; b=vzMiGng1VkyZACAHR7+PzGvNnhY3jWtQMlE4EBb9f0I9vxGftApJpJHjrFAGDIsWHReeDY /Rc3BATOIhYcKzhKx2a8hE1PsgFYujeXt6wWSiTHmfq0paHTUB/0hX9aC+UcWnThO84G4S 5lyBt0jibu1pDjEVPxetVv9vBa0zZql9lA+zGwnYpDYVjDx3zF1K7+RAMNxysHnBQcFgUZ MN/AibFmHTomAYYzaFudhYX3JeZYAe+qydo66/+wknhPed+Hqhi2q5DdQHeKgwtxbsI5I3 GYSroiSAiwGv6GmzjazBqH+9r9S8K9kthTHCj3QatD69hwiAetW5H7stJ4RRMw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704041396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oRTD4PTxpUKDIwdhfgdMQtRLZE4/Z0vgSPCDgQeSt9A=; b=pKXfRt+xmwwXq4wsZ0fOpZEKdkcVNjv4JyHJvBDwRbyUWyDBelLgguryDXtnSHQwQCUPxy ghWwu/CejSpRpL4QElJMX2dl5exOpuKxR6/Jqiwxj2K65YHBmtXaNPrlEa7h680iTN2SJh HTJ4BTlhLxj4aZXSlrqXykYckPdW+2m5KOZD3kgCcF+0lTuB4XUQs4V36aQNwmkepa08wl 2ivA+eBfIx2dOfqe+trKHf9jN/BAoi6qWt9zTQti6rb+pwmIQwcm7DFPMVDaVkt6mE3F9T 33pgratNGl1790PouVe+FrJxPhtCGqZBGBQyQ5OACmlDYiUNErDRbCi8Wf07OA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T34pr46bszj7w for ; Sun, 31 Dec 2023 16:49:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3BVGnu0E066694 for ; Sun, 31 Dec 2023 16:49:56 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3BVGnuYv066693 for threads@FreeBSD.org; Sun, 31 Dec 2023 16:49:56 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: threads@FreeBSD.org Subject: [Bug 270661] taskqgroup_cpu_create does taskqueue_thread_enqueue not gtaskqueue_thread_enqueue Date: Sun, 31 Dec 2023 16:49:56 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: threads@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Threading List-Archive: https://lists.freebsd.org/archives/freebsd-threads List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-threads@freebsd.org X-BeenThere: freebsd-threads@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270661 --- Comment #2 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3De1f336704d308679d4178fd5063dba854= b22a07b commit e1f336704d308679d4178fd5063dba854b22a07b Author: Mark Johnston AuthorDate: 2023-12-31 16:36:12 +0000 Commit: Mark Johnston CommitDate: 2023-12-31 16:49:08 +0000 gtaskqueue: Fix a typo This is a no-op in practice since gtaskqueue_thread_enqueue() and taskqueue_thread_enqueue() are identical, and while _gtaskqueue_create() compares the enqueue callback pointer with gtaskqueue_thread_enqueue(), the result has no effect since TQ_FLAGS_UNLOCKED_ENQUEUE was copied directly from subr_taskqueue.c and is unused in the gtaskqueue code. Fix it anyway since it's a bug. More generally we really need to consolidate subr_taskqueue.c and subr_gtaskqueue.c. PR: 270661 MFC after: 1 week sys/kern/subr_gtaskqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=