From nobody Sat Mar 11 00:37:41 2023 X-Original-To: testing@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PYPCB0mCZz3wvFk for ; Sat, 11 Mar 2023 00:37:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PYPC96gBnz3CWY for ; Sat, 11 Mar 2023 00:37:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678495061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ANFtmYE9AMgDUkao4Lvx8P1VhgX+csmR3in/AN5LcEY=; b=USVhq7f+qkvm0IP1AUBZal46KlUNeaXkmBuxZi5nzQgCDYcLJMHMNnuOggHBncBFHuDByV 7towPwY1VxIvLWKsf/l6n1ShDNGoDzGsMKcUCNrUCzL92BW8PCTeTeiC5Qf49Ag4sOc34M BLcGCKWYixeh42BrcUBJ18F3IRildJp/D9eT9M6Wpf0hzm3bavDOZZVE8esJ8Jy7ckEmai N8JCf95Hmp8iDTxIYrCMOcK+u1GdLx0ut7Eww7vhpNlrPGlhLEf+KFvb3KVnl+1pgfvgw5 4niLOtoA6aui4S/rRdiEMux5/grN13pZiYOsthYZutUetwX9GGEXpBz2w8DQbQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1678495061; a=rsa-sha256; cv=none; b=hJ4DUmIn3JfxQ2mli0KezWQBuqiBf1sp/h+tBe2TAKqHHeghDIBHYnB71pFVZRcGJt5O1W 3dgoauUkoXPfRWszpFx6yHOW6qLOLnXcooD9fjPPRCs0jdKynlimI4YYe6aeQHYDuoxSXt AMCSnLr45vc4VzzGFH3uuAfNHv4ejuPtiVa9etug6z7ESXXE4zVeqV4xwAgKNk1AMww13/ MbSCJKEmOJ1CZkVLaq9ZmlXbXNNAw+aovDskbivdM0CbnjfEY1mhNhGjMCENmWbMlTPkxv Rz7MLrfnTCMKegfX0R/id1PNBCDoIv/hfd+nyXVy8HYsHnr0u36pAJ1UmcsBgQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PYPC95jYmz18QV for ; Sat, 11 Mar 2023 00:37:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 32B0bfeR081257 for ; Sat, 11 Mar 2023 00:37:41 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 32B0bfdN081256 for testing@FreeBSD.org; Sat, 11 Mar 2023 00:37:41 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: testing@FreeBSD.org Subject: [Bug 260547] sys.netmap.ctrl-api-test.main fails in CI Date: Sat, 11 Mar 2023 00:37:41 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: tests X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: testing@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Testing List-Archive: https://lists.freebsd.org/archives/freebsd-testing List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-testing@freebsd.org X-BeenThere: freebsd-testing@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260547 Mark Johnston changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |markj@FreeBSD.org, | |vmaffione@FreeBSD.org Status|New |Open --- Comment #2 from Mark Johnston --- I hit a different test failure in ctrl-api-test. The problem is in the "infinite options" test. Since commit 253b2ec199b831cacc022b58cb38c3e3c29c1a8f, nmreq_copyin() does = some extra validation of the option linked list, but that appears to break the t= est and prevents an infinite loop only by accident. In particular, if multiple options have the same req type, the loop just sk= ips to the next option. But after the first iteration, opt->nro_next will be a kernel pointer not a user point, and then the subsequent copyin() fails bec= ause netmap is trying to copyin from a kernel address. This causes the test to = fail since the ioctl returns EFAULT instead of EMSGSIZE. If not for that bug, I think there would be an infinite loop. There is a second bug there in that "error" is set in some of those error cases, but the next iteration can set "error" back to 0. If I disable the infinite_options test, everything else passes for me. So = it'd be nice to fix the kernel and re-enable the netmap tests in CI. --=20 You are receiving this mail because: You are the assignee for the bug.=