From nobody Sun Sep 29 10:20:46 2024 X-Original-To: tcltk@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XGgFq12Ljz5XSr6 for ; Sun, 29 Sep 2024 10:20:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XGgFp5xc3z4Hq0 for ; Sun, 29 Sep 2024 10:20:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727605246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Obm6cxb5239U9lqveWGklc9y2soSrkZ09TPO7U3L+IU=; b=ooz71TrRArQBjhJT7Isa06+CkPhe67FnqLQtSRSodxQWkTUIExHcmaDtT5N/yS/8fFS4Z5 YygL+dql1nzQKJcN2xZv6YJK7tPJihoQJQzcSy1twHknweE3uKR7jSJgTEAdOv48V9Vhwd iRyI/TqubOEr0LdAdi7unAFkiu/xN5tT+4FwSrKkoD6tYQS+M15YKLGGW5qIu8csIfi2NS byS+hD2L+a8dJc+uDb2+Vgedj6h3c+Dnl3BIK7BizcVFeHduWkExxyPzXx2k/3jjFArbbj TfSDjnGJ8rATD3ErlYtVFs2VMtnWwXTTPqEpMD5J5w/1DnOQsUQReFmEqMQw1A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727605246; a=rsa-sha256; cv=none; b=uqQr0eeB+hg+MQHX3LeQprrcMy2rD3IlLENC4Kbu/oDMoaRjb87C2UYHxtpaI7JYgiM/up 63yFELLaF4/SxJsrZd7n4oKr94XibJ+OTW8JFEHllpIsc4B5ojsX2zq4ieHV6GTnPOk6++ 6UQhm5HVR/WuGOnBTy3hhpnxee5QhVk64+FbSWn286iSGBmOp+NJkZBrW+E9BZVUZdeWQO WVxxB59X/O7nk6nIs66RsK9QWideIhxJKvhvWaRbmQqegc8SctVOthUjQle5YRsw3jUBqn 3gVg09rLrkneaVK1LIAZG86IJuKP0vWPXZbXhvQ6ONYfwHkgc3/OwrggHvO8lA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XGgFp5RNwz14gQ for ; Sun, 29 Sep 2024 10:20:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 48TAKkZ0095921 for ; Sun, 29 Sep 2024 10:20:46 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 48TAKk9k095920 for tcltk@FreeBSD.org; Sun, 29 Sep 2024 10:20:46 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: tcltk@FreeBSD.org Subject: [Bug 281756] lang/tcl90: Update to 9.0.0 release Date: Sun, 29 Sep 2024 10:20:46 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: diizzy@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tcltk@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: FreeBSD-specific Tcl/Tk discussions List-Archive: https://lists.freebsd.org/archives/freebsd-tcltk List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-tcltk@freebsd.org Sender: owner-freebsd-tcltk@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D281756 --- Comment #5 from Daniel Engberg --- (In reply to Pietro Cerutti from comment #4) We can refer DISTVERSION_R and _RS to as MAJOR/MINOR/PATCH (version) in some way which some ports uses although that leads to slightly quirky abbreviati= ons at times but more commonly used.=20 I would also argue that the first section of the port Makefile should be ea= sily readable, ie not (unintentionally) obfuscate version and package metadata. Most changes are actually fixes, BUILD_DEPENDS (missing) WRKSRC + WRKSRC_SUBDIR is the correct way of defining a WRKSRC subdir (See Porters Handbok) First instance INSTALL_TARGET+=3D should be INSTALL_TARGET=3D as it's not d= efined earlier (see Mk/bsd.port.mk) GNU_CONFIGURE_MANPREFIX is unnecessary/obsolete as of commit 8f80d6dde15c23f550d7f2201299c04e49d91ecc MAKE_ENV is unused USES=3D pathfix doesn't match anything and it's patched in post-patch secti= on OPTIONS section doesn't follow recommended layout, see "Example 43. Simple = Use of OPTIONS" "Example 45. Practical Use of OPTIONS" for example in Porters Handbook and a bit akwardly placed Might be something else I've forgot... Given that the Makefile isn't long and the new version is actually shorter = it's easier to compare both side by side. Unless you have a fix I think we should hold off until atleast Tier 1 platf= orms passes unit tests with or without DTRACE enabled and report failures upstream/try to figure out what's makes it fail. Best regards, Daniel --=20 You are receiving this mail because: You are the assignee for the bug.=