From nobody Tue Jun 14 20:06:37 2022 X-Original-To: tcltk@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id CD02F83A660 for ; Tue, 14 Jun 2022 20:06:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LMzwY45mnz4X1F for ; Tue, 14 Jun 2022 20:06:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 6D89A110C0 for ; Tue, 14 Jun 2022 20:06:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 25EK6b8p017626 for ; Tue, 14 Jun 2022 20:06:37 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 25EK6bF2017625 for tcltk@FreeBSD.org; Tue, 14 Jun 2022 20:06:37 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: tcltk@FreeBSD.org Subject: maintainer-feedback requested: [Bug 264671] lang/expect: Installed binaries should not be stripped WITH_DEBUG=yes Date: Tue, 14 Jun 2022 20:06:37 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tcltk@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: FreeBSD-specific Tcl/Tk discussions List-Archive: https://lists.freebsd.org/archives/freebsd-tcltk List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-tcltk@freebsd.org X-BeenThere: freebsd-tcltk@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1655237197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=INJRVh6/DpKqQOrScnFuwKyA7eBDVB9CtNHX7i94l/w=; b=Su1UvHotoFhKSRubzC+uOUGq2mplanYWckiun5VXHUrK4Uo8r2Ezgl9DJasSJioeIvdgA+ 3NabjpnmbrCpnZNk/CtLfhPh+vkyQPkQ9QUkRFn+kDW+n5pf+bo0r7zfyiEn3g5bH1IwT3 GiCb7LeFwtN3Opd2QUo1n5UyJF8YYUcbDvkam6KXkihc5L92qmyqDrS6QRMYpmqnDXTnI1 5oSPs4Po499SYsuh1BCNGlQG2RlD9jzcFCq+9CrdupyNDzjb0zpJZ3z8mhzpxCNVh3FZ8t 7HCNHSWECY6eXGsyKkR3fv18we0JZDugVmiq/b/kF8ftzdvzgP6XAgLHquuxJg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1655237197; a=rsa-sha256; cv=none; b=tcfEfnae0WCNAvoJasGCprvMHlH1Ow/TiljgxlmVLHRqJUrNNrLDnXJUURttskuP3nrRRK nM2s6lPXxFhHiNKdYBt/V2lDj5hJdjIPoao3pTYvqkJfc9MtKRYRVZeH+5rtkns90taE65 Iom/kB6qxtHxa7Wtr9qv6ZJcu+DA4BIG+1aq8jojE3Rc/1hGfG/MTNu0oh67jNL34VYDOk CZ7R2vSOlbJTbsNemZtvOftpTG7ltMZoUl76WKWBTfma0jElIhkjiWeZURIanHcrl9kyQO M7KiAOW0r4KrLpED5SeFGuIcxtTiRchqKRh7JVT/8rcR9DiL2x2qKPAituDo6g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N Bugzilla Automation has asked freebsd-tcltk (Nobody) for maintainer-feedback: Bug 264671: lang/expect: Installed binaries should not be stripped WITH_DEBUG=3Dyes https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D264671 --- Description --- Today I had to single step through expect and I found out that binaries get stripped on install despite WITH_DEBUG=3Dyes. Here's how I solved it: # diff -u Makefile /tmp/Makefile.new --- Makefile 2022-02-09 17:21:32.000000000 +0000 +++ /tmp/Makefile.new 2022-06-14 20:00:30.450493000 +0000 @@ -22,6 +22,7 @@ SUB_FILES+=3D pkg-message SUB_LIST+=3D MANPREFIX=3D${MANPREFIX} TEST_TARGET=3D test +MAKE_ENV+=3D STRIPPROG=3D${STRIP_CMD} post-install: ${LN} -sf ${DISTNAME}/lib${DISTNAME}.so \