From nobody Wed Feb 09 13:27:25 2022 X-Original-To: tcltk@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 765DF19B4408 for ; Wed, 9 Feb 2022 13:27:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Jv0zd1Lz0z4Ywd for ; Wed, 9 Feb 2022 13:27:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0A4576109 for ; Wed, 9 Feb 2022 13:27:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 219DROjD078669 for ; Wed, 9 Feb 2022 13:27:24 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 219DROvq078668 for tcltk@FreeBSD.org; Wed, 9 Feb 2022 13:27:24 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: tcltk@FreeBSD.org Subject: maintainer-feedback requested: [Bug 261829] lang/expect: fix build with only lang/tcl87 installed Date: Wed, 09 Feb 2022 13:27:25 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tcltk@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: FreeBSD-specific Tcl/Tk discussions List-Archive: https://lists.freebsd.org/archives/freebsd-tcltk List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-tcltk@freebsd.org X-BeenThere: freebsd-tcltk@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1644413245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/s88R4rZwkVGkhPft2G61N4pOMN7An80Jg0Lh8sGeDo=; b=eKFKaQrLrgvi4XHSZjTUjyPg/hNZQP3YuTs3GeghrJh6KLeA4UoH6RDZlDGRLoFMdTztd2 jS8shaeETjohyJyTPiFcSktXyuyXjTBPvH4bdjQGAlYNxAxraRy06f+TW33rmA95H4Ud7z HUTtG215DoUsEgaNwfMDzyny7VzwHq2jdCSJq5WW7/is9WhyHpdTmk4/t5I8VS4jHsVHfM Z1HxHbIrraTzh3eHL833ys92mJE0oF/ifBdLL6pN8ifKxQkzIuoA4bAx6PLabTOedoUKTq ZSaNm0kc7tqYRt/G7E7Msxr6P3+Mtahf4Fh9vf4UM3PX8It73o6N2LLBTHCCaQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1644413245; a=rsa-sha256; cv=none; b=EBhhJlT9oj/awMqkwlDm1/mThayeokVCk/uM7NXZVjcrFCRovzmLC5aJueXINHaUCN+Myq Jti6AnqGT/QcCn3hf6JB0/SoSp31pduUVegCwBceLciHL0iPNRYL07zfNcZM4rqE1Sfm6I m69mrp6Kc3M8u8WZCU21cFcDApuUVklYG+pkc4q5CXj+pEFZ5slB+HgEYkmpKp+b9OwJxk lclOHrqf+KJHVZ/21iR6irBD+iIkkmQBI3OXu0wHPGzzbKTze2NPOAPYqwWtITqmlYE9Fb tENHNdM8Qp7WVuBxtmvyogZnBRY2LbwGN3T7ettbMA6/y6v3OD9GVT28C5L9Pg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N Bugzilla Automation has asked freebsd-tcltk (Nobody) for maintainer-feedback: Bug 261829: lang/expect: fix build with only lang/tcl87 installed https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261829 --- Description --- If you have DEFAULT_VERSIONS+=3Dtcltk=3D8.7 in your make.conf, and therefor= e only have lang/tcl87 installed, lang/expect does not compile, complaining about = an bad identifier "CONST84". With the older lang/tcl86 installed, this is defined in /usr/local/include/tcl8.6/tcl.h: #ifdef USE_NON_CONST # ifdef USE_COMPAT_CONST # error define at most one of USE_NON_CONST and USE_COMPAT_CONST # endif # define CONST84 # define CONST84_RETURN #else # ifdef USE_COMPAT_CONST # define CONST84 # define CONST84_RETURN const # else # define CONST84 const # define CONST84_RETURN const # endif #endif #ifndef CONST86 # define CONST86 CONST84 #endif Since we are now in the next millennium, we can assume const always works, = and replace the CONST84 macro with just CONST.