[Bug 283112] Cache files packed into the FreeBSD14.2 release ISO file

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283112

            Bug ID: 283112
           Summary: Cache files packed into the FreeBSD14.2 release ISO
                    file
           Product: Base System
           Version: 14.2-RELEASE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: standards
          Assignee: standards@FreeBSD.org
          Reporter: yanhui.he@broadcom.com

Created attachment 255613
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=255613&action=edit
freebsd_14.2_rc1_newfiles

Hi,

pycdlib is used on our test to automatic install FreeBSD 14.2. We hit the issue
that we cannot use it from FreeBSD 14.2 RC1, including the released FreeBSD
14.2 Release ISO Images. pycdlib is the same one for below FreeBSD 14.2 BETA3
and release.

Like we use the below code to open FreeBSD 14.2 BETA3 64bit ISO Image.
******test_beta3_iso.py******
#!/usr/bin/env python

import pycdlib
iso = pycdlib.PyCdlib(always_consistent=True)
src_iso = "FreeBSD-14.2-BETA3-amd64-dvd1.iso"
iso.open(src_iso)
iso.close()
******test_beta3_iso.py******

Test FreeBSD 14.2 BETA3 ISO, and no errors
$ python3 test_beta3_iso.py

******test_release_iso.py******
#!/usr/bin/env python

import pycdlib
iso = pycdlib.PyCdlib(always_consistent=True)
src_iso = "FreeBSD-14.2-RELEASE-amd64-dvd1.iso"
iso.open(src_iso)
iso.close()
******test_release_iso.py******


Test RELEASE ISO, got exceptions

$ python3 test_release_iso.py
Traceback (most recent call last):
  File "/tmp/test_iso.py", line 8, in <module>
    iso.open(src_iso)
  File "/home/qiz/.local/lib/python3.10/site-packages/pycdlib/pycdlib.py", line
4123, in open
    self._open_fp(fp)
  File "/home/qiz/.local/lib/python3.10/site-packages/pycdlib/pycdlib.py", line
2310, in _open_fp
    ic_level, lastbyte = self._walk_directories(self.pvd, extent_to_ptr,
  File "/home/qiz/.local/lib/python3.10/site-packages/pycdlib/pycdlib.py", line
1151, in _walk_directories
    new_record.parent.track_child(new_record,
  File "/home/qiz/.local/lib/python3.10/site-packages/pycdlib/dr.py", line 838,
in track_child
    self._add_child(child, logical_block_size, allow_duplicate, False)
  File "/home/qiz/.local/lib/python3.10/site-packages/pycdlib/dr.py", line 747,
in _add_child
    raise pycdlibexception.PyCdlibInvalidInput('Failed adding duplicate name to
parent')
pycdlib.pycdlibexception.PyCdlibInvalidInput: Failed adding duplicate name to
parent


By comparing BETA3 with RC1/RELEASE ISO, there are some new files added from
RC1 (see attachement freebsd_14.2_rc1_newfiles.txt). 

The most suspicious files are below cache files. 
./var/cache/pkg/wifi-firmware-iwlwifi-kmod-22000-20241017_1~7ad9338d54.pkg
./var/cache/pkg/wifi-firmware-iwlwifi-kmod-7000-20241017_1~f04ac7a71d.pkg
./var/cache/pkg/wifi-firmware-iwlwifi-kmod-8000-20241017_1~d771c14b9f.pkg
./var/cache/pkg/wifi-firmware-iwlwifi-kmod-9000-20241017_1~1dd55a85fd.pkg
./var/cache/pkg/wifi-firmware-iwlwifi-kmod-ax210-20241017_1~43eea6bfa4.pkg
./var/cache/pkg/wifi-firmware-iwlwifi-kmod-bz-20241017_1~7f6e1c6d44.pkg
./var/cache/pkg/wifi-firmware-kmod-release-20241017~b0e3d437a2.pkg
./var/cache/pkg/wifi-firmware-rtw88-kmod-rtw8703b-20241017_1~25b73e7198.pkg
./var/cache/pkg/wifi-firmware-rtw88-kmod-rtw8723d-20241017_1~cbb2d43e86.pkg
./var/cache/pkg/wifi-firmware-rtw88-kmod-rtw8821c-20241017_1~0d1aa10a4d.pkg
./var/cache/pkg/wifi-firmware-rtw88-kmod-rtw8822b-20241017_1~fd58884de1.pkg
./var/cache/pkg/wifi-firmware-rtw88-kmod-rtw8822c-20241017_1~3599bbf662.pkg
./var/cache/pkg/wifi-firmware-rtw89-kmod-rtw8851b-20241017_1~f20c3d0609.pkg
./var/cache/pkg/wifi-firmware-rtw89-kmod-rtw8852a-20241017_1~c87c5db9f3.pkg
./var/cache/pkg/wifi-firmware-rtw89-kmod-rtw8852b-20241017_1~c6b2db8a10.pkg
./var/cache/pkg/wifi-firmware-rtw89-kmod-rtw8852c-20241017_1~967b9c7bf3.pkg
./var/cache/pkg/wifi-firmware-rtw89-kmod-rtw8922a-20241017_1~83ff2fd377.pkg


Shall these cache files be packed into the release ISO file?

Thanks!
Yanhui

-- 
You are receiving this mail because:
You are the assignee for the bug.