[Bug 172276] POSIX: {get,set}groups gidsetsize is u_int not int
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 07 Aug 2021 00:08:10 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=172276 Ed Maste <emaste@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Open |Closed --- Comment #2 from Ed Maste <emaste@freebsd.org> --- Fixed by: commit 4bc2174a1b489c36195ccc8cfc15e0775b817c69 Author: Moritz Buhl <gh@moritzbuhl.de> Date: Tue Jul 9 17:03:37 2019 +0200 kern: fail getgroup and setgroup with negative int Found using https://github.com/NetBSD/src/blob/trunk/tests/lib/libc/sys/t_getgroups.c getgroups/setgroups want an int and therefore casting it to u_int resulted in `getgroups(-1, ...)` not returning -1 / errno = EINVAL. imp@ updated syscall.master and made changes markj@ suggested PR: 189941 Tested by: imp@ Reviewed by: markj@ Pull Request: https://github.com/freebsd/freebsd-src/pull/407 Differential Revision: https://reviews.freebsd.org/D30617 commit 9f3d1a98dd17b9f02912aecab328fd0315d8ef35 Author: Warner Losh <imp@FreeBSD.org> Date: Wed Jun 2 12:06:13 2021 -0600 regen after tweaks to getgroups and setgroups Sponsored by: Netflix -- You are receiving this mail because: You are the assignee for the bug.