From nobody Thu Jan 02 10:15:39 2025 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YP2fC1KCdz5j1pC for ; Thu, 02 Jan 2025 10:15:47 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YP2fC0VDmz41rQ; Thu, 2 Jan 2025 10:15:47 +0000 (UTC) (envelope-from zlei@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735812947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wAiOtSlX2W3WvRKc56fsj51ViEreavT10p2GlLPhFXw=; b=xWOBmMhZp3xW3+yipLbRlHOy3krDhyM8fWG1MfLZVzS/Kv25HJ9Vw/WmESrdLzrK0Ccgxu rQ/GRMYfT9B2aLOT6cKbCTzrY8O8A3b824YuQJ1UGNd3e3t8kx9b23lN4QaGTZEpbf7PD1 7QvKrdRPCH1xoFS8054JKU3UnWudZDVQFl388KCNLVfs5jv+/7DbCSbse3jBLAiqDnHv34 bwLQIvc84zkWZrjNMo5NjXbYBZc6j/PlUoRpEPngGXeG7sLVuxxu8WcScxmCg8ShVlbOP+ t0ajHmjBrxizzMfTuw7ncpGGJ8nf6wElJoLpWKIkx1OR5hhOKvymMwsV4GqR/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735812947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wAiOtSlX2W3WvRKc56fsj51ViEreavT10p2GlLPhFXw=; b=c/JJBCak76N0AKHJgK3HGZRnCQjIzSDHJZ+Fuqv4A4tE720bVXtXdhJt1eIS+PxVR7k580 N3vkKt7K8m/+SMk+bBUAQEDpo8kphPzTtzIjHHKnI9XxJVg2duHWm0qfrgjChshiRunjxy 9t6ptNrA0aL0Hlkd9AZRmGJQqMUJuRu6i42qOgGOqJ1JXRCvWdPjdC2oIJ7/lCJloeBZpN iBjUbahZTbT0vvCemhvedyLro+ZVDaJ14i4bao7MqorsV+youqzsrtux/9a6fFZePitZWd eOlLsPM8d8NWlpOChWVosjInBSTZ4QerzPJqVaNFPAYrfCGgqv+JxaS5pK25oA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1735812947; a=rsa-sha256; cv=none; b=ViaSN8/YBM1iv/b8WhTuvD62QVGrVFiG1VJg8WwEyVJH/chHQwkpWBNbdygfJYk84iIxjk ghEln3Ci6FGXFx14lOr1F97G7tEYrv0vrvLFAgPUd7hdTwCM7aOqfJjHbvqg9EqDCpCxJI eJDPD8VEByxrTQC/IRxaq9IwVHQ3lNtBNRn6I/4FzK9WOLxwa+nsSGrU+y/POOb0UG7UcB wwuyZJwJnJXoGfc6v3UsZW+E1i/fK+C7ouH+q31gG6xJ9QiGS0MT0w7lZ07U9nwqGvdSR0 gDZ+KrbluIrYtdsxKlI4fTP5ISX+q8jmlxnXHIwVMQXld4dm0bc3z6aoCkh4fg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from smtpclient.apple (unknown [45.32.91.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: zlei/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4YP2f95whzzhrb; Thu, 02 Jan 2025 10:15:45 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Content-Type: text/plain; charset=utf-8 List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-stable@freebsd.org Sender: owner-freebsd-stable@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.10\)) Subject: Re: Should kernel modules be executable? From: Zhenlei Huang In-Reply-To: <8634i1r3f9.fsf@ltc.des.dev> Date: Thu, 2 Jan 2025 18:15:39 +0800 Cc: Miroslav Lachman <000.fbsd@quip.cz>, FreeBSD-STABLE Mailing List Content-Transfer-Encoding: quoted-printable Message-Id: <1CF31C37-9177-4267-8387-2E5089DDC2F9@FreeBSD.org> References: <5120eb91-86c1-4c60-8d73-cbc46689669a@quip.cz> <10B8CED2-104F-4047-AED0-2B270CECB258@FreeBSD.org> <8634i1r3f9.fsf@ltc.des.dev> To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= X-Mailer: Apple Mail (2.3696.120.41.1.10) > On Jan 2, 2025, at 5:05 PM, Dag-Erling Sm=C3=B8rgrav = wrote: >=20 > Zhenlei Huang writes: >> Miroslav Lachman <000.fbsd@quip.cz> writes: >>> Previously there were about 25 files with permission r-xr-xr-x and >>> 871 with other permissions (mainly -r--r--r--). >>> But on the FreeBSD 14.2 (upgraded by freebsd-update), there are 809 >>> files with r-xr-xr-x permission and only 66 with other permissions >>> (63 with r--r--r--) >> Yes, indeed. The permission of kernel modules was changed from 555 to >> KMODMODE ( NOBINMODE, 444 ). See https://reviews.freebsd.org/D42768 >> for more context. >=20 > And yet the observed change is the opposite. >=20 > Looking at a 14.2 kernel tarball, the modules are not executable, but = on > a 14.2 system updated from an earlier release using freebsd-update, = they > are. I also observed this. `freebsd-upgrade IDS` reported the issue and I = manually fixed the *wrong* permissions. >=20 > DES > --=20 > Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org