From nobody Mon Feb 10 12:14:45 2025 X-Original-To: stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ys3RX5h5gz5npCD for ; Mon, 10 Feb 2025 12:14:48 +0000 (UTC) (envelope-from david@catwhisker.org) Received: from mx.catwhisker.org (mx.catwhisker.org [107.204.234.170]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ys3RW2Flvz46XN; Mon, 10 Feb 2025 12:14:47 +0000 (UTC) (envelope-from david@catwhisker.org) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of david@catwhisker.org designates 107.204.234.170 as permitted sender) smtp.mailfrom=david@catwhisker.org; dmarc=none Received: from albert.catwhisker.org (localhost [127.0.0.1]) by albert.catwhisker.org (8.18.1/8.18.1) with ESMTP id 51ACEjBP014723; Mon, 10 Feb 2025 12:14:45 GMT (envelope-from david@albert.catwhisker.org) Received: (from david@localhost) by albert.catwhisker.org (8.18.1/8.18.1/Submit) id 51ACEjBI014722; Mon, 10 Feb 2025 04:14:45 -0800 (PST) (envelope-from david) Date: Mon, 10 Feb 2025 04:14:45 -0800 From: David Wolfskill To: stable@freebsd.org Subject: Something omitted in an MFC? Message-ID: Reply-To: stable@freebsd.org Mail-Followup-To: stable@freebsd.org List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-stable@freebsd.org Sender: owner-freebsd-stable@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bFHWv4C7BdyJ/jNP" Content-Disposition: inline X-Spamd-Result: default: False [0.83 / 15.00]; REPLYTO_EQ_TO_ADDR(5.00)[]; SIGNED_PGP(-2.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-0.997]; NEURAL_HAM_SHORT(-0.78)[-0.778]; R_SPF_ALLOW(-0.20)[+ip4:107.204.234.170]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; RCVD_TLS_LAST(0.00)[]; MISSING_XM_UA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; DMARC_NA(0.00)[catwhisker.org]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; FREEFALL_USER(0.00)[david]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; ASN(0.00)[asn:7018, ipnet:107.192.0.0/12, country:US]; TO_DN_NONE(0.00)[]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[stable@freebsd.org]; MID_RHS_MATCH_FROMTLD(0.00)[]; HAS_REPLYTO(0.00)[stable@freebsd.org] X-Spamd-Bar: / X-Rspamd-Queue-Id: 4Ys3RW2Flvz46XN --bFHWv4C7BdyJ/jNP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable TL;DR: I thought it was just that stable/14's sys/sys/libkern.h had grown a need for an #include but merely adding that just generated another error, so I thought I should leave that part to folks who actually have more clue about this stuff than I do. :-} Daily update of stable/14 failed today; this was from: freebeast(14.2-S)[5] uname -aUK FreeBSD freebeast.catwhisker.org 14.2-STABLE FreeBSD 14.2-STABLE #102 stabl= e/14-n270345-9938f6408934: Sat Feb 8 11:53:14 UTC 2025 root@freebeast.= catwhisker.org:/common/S1/obj/usr/src/amd64.amd64/sys/GENERIC amd64 1402501= 1402501 after updating sources to stable/14-n270354-16b7da6f7abe. =2E.. make[4]: stopped in /usr/src/stand/libsa32 =2EERROR_TARGET=3D'zfs_zstd.o' =2EERROR_META_FILE=3D'/common/S1/obj/usr/src/amd64.amd64/stand/libsa32/zfs_= zstd.o.meta' =2EMAKE.LEVEL=3D'4' =2E... Checking the meta file, I see: =2E.. TARGET zfs_zstd.o -- command output -- In file included from /usr/src/sys/contrib/openzfs/module/zstd/zfs_zstd.c:4= 3: In file included from /usr/src/sys/contrib/openzfs/include/os/freebsd/spl/s= ys/sysmacros.h:34: In file included from /usr/src/sys/contrib/openzfs/include/os/freebsd/spl/s= ys/systm.h:35: In file included from /usr/src/sys/contrib/openzfs/include/os/freebsd/spl/s= ys/string.h:32: /usr/src/sys/sys/libkern.h:196:2: error: call to undeclared function 'MPASS= '; ISO C99 and later do not support implicit function declarations [-Werror= ,-Wimplicit-function-declaration] 196 | MPASS(n !=3D 0); | ^ /usr/src/sys/sys/libkern.h:204:2: error: call to undeclared function 'MPASS= '; ISO C99 and later do not support implicit function declarations [-Werror= ,-Wimplicit-function-declaration] 204 | MPASS(n !=3D 0); | ^ /usr/src/sys/sys/libkern.h:212:2: error: call to undeclared function 'MPASS= '; ISO C99 and later do not support implicit function declarations [-Werror= ,-Wimplicit-function-declaration] 212 | MPASS(n !=3D 0); | ^ 3 errors generated. *** Error code 1 =2E... Checking a git diff, MPASS is now in some new code added to sys/sys/libkern.h in stable/14-n270350-4ed1837853b1, which MFCs main-n270548-b0056b31e900. And that's about as far as I got before inserting that '#include