Re: git log - how to find out latest stable/14 breakage

On 2024-01-20 15:10, Mike Karels wrote:
> On 20 Jan 2024, at 6:47, Harry Schmalzbauer wrote:
> 
>> Hello,
>>
>> suddenly, there are
>> lib/libifconfig/libifconfig_sfp_tables.tpl.c
>>   create mode 100644 lib/libifconfig/libifconfig_sfp_tables.tpl.h
>>   create mode 100644 lib/libifconfig/libifconfig_sfp_tables_internal.tpl.h
>>
>> while lib/libifconfig/libifconfig_sfp.h
>> still reads
>> #include <libifconfig_sfp_tables.h>
>>
>> (note (new) the .tpl.h suffix).
>>
>> Neither on CLI with 'git log' nor via cgit I can figure out when/what commit changed that filenames.
> 
> If you do "git grep tpl.h", you will find that lib/libifconfig/Makefile has rules
> for generating the .h files from .tpl.h files.  Note, the generated files end up
> in the obj directory (/usr/obj/.../lib/libifconfig).  The filenames did not change.

Hello Mike,

thanks, I was not aware that there's "git grep"... but found the 
Makefile .tpl.h target meanwhile.
Will need to investigate why the .tpl.h files live in /usr/src here...


> If you want, you could do "git blame lib/libifconfig/Makefile" to find out when

"git blame" is new to me too... sounds like a very important and helpful 
command, thanks!


> those lines last changed.  Or you could do a "git diff" using the hash of the last
> version that worked for you.
> 
> What problem are you actually having?  I just did a buildworld on stable/14 and
> had no problems; the .h files are in the obj directory as they should be.
I didn't run make for the clean target - wanted to save some time since 
I already had bootstrap-compiled llvm17 (1400505).  ifconfig stopped due 
to missing (non-tpl).h file... #Include line didn't match src file 
names, so I incorrectly assumed a filename change. My awful git skills 
led to the experience that I never want to trust what my 'git' commands 
tell me... My fault.  I need to learn learning new tools without such a 
strong bias - I know that disliking it make things only worse.


>> How can you all manage your daily jobs with git?!?!  For me as a part-time RCS user, git is a huge regression.  Never had anything to lookup/read twice with subversion or cvs in the past, but never found out how I'm supposed to use git.  I'm looking up usage again and again and again... is it I'm getting old probably :-(
> 
> I admit that git is rather more baroque than earlier VCS systems.  I am by no
> means a power user, but I get by.  And I'm probably older than you :).
> You could try a web search for "git primer" or something like that.

Without Warner's "git primer" I'd have abandoned dealing with src/ ;-) 
I really appreciate this extra piece of aid FreeBSD people provide!!!

Locally I continue using subversion, where the tiny part of it's 
capabilities I need/use supports my goals, whereas 'git' always felt 
like it only complicates things for me.  Neither in the past, nor 
nowadays, where people always carry internet gateways/VPN tunnel 
endpoints in their pockets, I ever understood the benefit of a 
distributed VCS over a centralized.  I for myself always prefer it to be 
centralized for any aspect, independent of the tool (git vs. cvs) 
developers need to utilize, but that's another topic...

About to compile stable/14 with a clean obj tree, which will turn out if 
my OBJDIR adjustments are the culprit.

Thanks,
-harry