Re: Build fail: stable/14-n266695-52d7bd8c4268 -> stable/14-n266773-25bd87539704

From: Dimitry Andric <dim_at_FreeBSD.org>
Date: Sun, 18 Feb 2024 13:04:27 UTC 
On 18 Feb 2024, at 13:10, David Wolfskill <david@catwhisker.org> wrote:
> 
> 
> First one of these I've seen in a long time.  This is amd64, using
> META_MODE:
> 
> ...
> Building /common/S1/obj/usr/src/amd64.amd64/lib/libc/tests/db/Kyuafile
> Building /common/S1/obj/usr/src/amd64.amd64/lib/libc/tests/hash/h_hash
> Building /common/S1/obj/usr/src/amd64.amd64/lib/libc/tests/hash/sha2_test.debug
> *** [zfsd_main.o] Error code 1

The actual error was cut off:

  In file included from /usr/src/sys/contrib/openzfs/lib/libspl/include/unistd.h:27:
  /common/S1/obj/usr/src/amd64.amd64/tmp/usr/include/unistd.h:507:6: error: declaration of 'execvpe' has a different language linkage
    507 | int      execvpe(const char *, char * const *, char * const *);
        |          ^
  /usr/src/sys/contrib/openzfs/lib/libspl/include/os/freebsd/sys/param.h:60:12: note: previous declaration is here
     60 | extern int execvpe(const char *name, char * const argv[], char * const envp[]);
        |            ^

Kostik fixed this just now, with:

https://cgit.freebsd.org/src/commit/?id=bda0c0dc87c54b611d96b6d0dc1947819ffec083

-Dimitry