From nobody Mon Sep 18 11:22:04 2023 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rq2Sl5qNzz4t2Gh; Mon, 18 Sep 2023 11:22:15 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Received: from www121.sakura.ne.jp (www121.sakura.ne.jp [153.125.133.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rq2Sl1TQ7z3fJV; Mon, 18 Sep 2023 11:22:15 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Authentication-Results: mx1.freebsd.org; none Received: from kalamity.joker.local (123-1-88-210.area1b.commufa.jp [123.1.88.210]) (authenticated bits=0) by www121.sakura.ne.jp (8.16.1/8.16.1/[SAKURA-WEB]/20201212) with ESMTPA id 38IBM4Td005456; Mon, 18 Sep 2023 20:22:04 +0900 (JST) (envelope-from junchoon@dec.sakura.ne.jp) Date: Mon, 18 Sep 2023 20:22:04 +0900 From: Tomoaki AOKI To: Martin Matuska Cc: Alexander Motin , freebsd-current@freebsd.org, freebsd-stable@freebsd.org Subject: Re: vfs.zfs.bclone_enabled (was: FreeBSD 14.0-BETA2 Now Available) Message-Id: <20230918202204.28e21a011a0a98e3fcda9f3a@dec.sakura.ne.jp> In-Reply-To: <8e4e4000-4680-0550-6772-32a6a3101761@FreeBSD.org> References: <20230916002831.GU52318@FreeBSD.org> <02c53c2e-127b-33b4-e13d-f6f6589dd5fe@gmail.com> <7a6692de-f096-637d-fe48-d5fb93e54f8b@FreeBSD.org> <8e4e4000-4680-0550-6772-32a6a3101761@FreeBSD.org> Organization: Junchoon corps X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:7684, ipnet:153.125.128.0/18, country:JP] X-Rspamd-Queue-Id: 4Rq2Sl1TQ7z3fJV (Intentionally dropped @gmail.com recipients, as gmail refuses to accept emaif from my email domain, unfortunately.) Really OK? I cannot find block_cloning in array *features_for_read[] of stand/libsa/zfs/zfsimpl.c, which possibly mean boot codes (including loader) cannot boot from Root-on-ZFS pool having block_cloning active. Not sure adding '"com.fudosecurity:block_cloning",' here is sufficient or not. Possibly more works are needed. IMHO, all default-enabled features should be safe for booting. Implement features with disalded, impement boot codes to support them, then finally enable them by default should be the only valid route. [1] https://cgit.freebsd.org/src/tree/stand/libsa/zfs/zfsimpl.c On Mon, 18 Sep 2023 07:31:46 +0200 Martin Matuska wrote: > I vote for enabling block cloning on main :-) > > mm > > On 16. 9. 2023 19:14, Alexander Motin wrote: > > On 16.09.2023 01:25, Graham Perrin wrote: > >> On 16/09/2023 01:28, Glen Barber wrote: > >>> o A fix for the ZFS block_cloning feature has been implemented. > >> > >> Thanks > >> > >> I see > >> , > >> with > >> > >> in stable/14. > >> > >> As vfs.zfs.bclone_enabled is still 0 (at least, with 15.0-CURRENT > >> n265350-72d97e1dd9cc): should we assume that additional fixes, not > >> necessarily in time for 14.0-RELEASE, will be required before > >> vfs.zfs.bclone_enabled can default to 1? > > > > I am not aware of any block cloning issues now.  All this thread about > > bclone_enabled actually started after I asked why it is still > > disabled. Thanks to Mark Millard for spotting this issue I could fix, > > but now we are back at the point of re-enabling it again.  Since the > > tunable does not even exist anywhere outside of FreeBSD base tree, I'd > > propose to give this code another try here too.  I see no point to > > have it disabled at least in main unless somebody needs time to run > > some specific tests first. -- Tomoaki AOKI