From nobody Sat Sep 16 17:14:09 2023 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RnyNd4xp8z4sflS; Sat, 16 Sep 2023 17:14:57 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com [IPv6:2607:f8b0:4864:20::1136]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RnyNc44Jbz3Gqd; Sat, 16 Sep 2023 17:14:56 +0000 (UTC) (envelope-from mavbsd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-59c0d002081so16054567b3.2; Sat, 16 Sep 2023 10:14:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694884495; x=1695489295; darn=freebsd.org; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id:sender :from:to:cc:subject:date:message-id:reply-to; bh=fQ9bOO3jPkXaUBACxHDOo6s968XDMr7hg5qMZ69kCA0=; b=GDFkTQsCPaymiOaZbQ8iFZBcBCEX7rNbNxIWr262srnHJU56+igse7+y9T5QuBVzoI lslEbaVjM9ea4IZKDxKEd0WxD41LvMP5W4zozEVqGj+AXiMlZNc8BfqM2R/EY7gWXZ40 /xrnjY7YboCQpJ5/ihA9A04r3ThA3hrZPSXrQgPIltqkj1Uy1IuC5K+L5EirPOZmM/e6 6G6fiOBTDroMMyePZXrpVMrgrwgMbIUGOwVwkKDlSDWsCAj2vt4RxKOTzo4ZvZXzSUpm DwNmsaM7SQSH9O8aW2HnFyzToyPcqLkdHOw1CtEWQRGx6NtbhT9Ir1DAVIvefg3rMyz/ lnJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694884495; x=1695489295; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fQ9bOO3jPkXaUBACxHDOo6s968XDMr7hg5qMZ69kCA0=; b=gkiTbWyX8p2PybPBEYaluwVaKRoicVVe1tTahDY9jaqBKXhNksU7GU43lsnPLQf9lI lvb9JErNy03yOefv3En8/nx95HO5GCBHn5VMfYlcZOCKvtzjMYWXRNOCYWtGHPu1qemu dzJJoaF5ga5BEo5DvpJq8QAqDyIKnkCp/f4dsKo/INLm3bXhssGHQfxis56Qw5xvxV9j U5Nxw13OLmY50vB9t150+5cfFLbWwi3WloI0S5G87ljZbv9DRhjeU2SqnH2JQf+w0s8Y YUNIGQVhKTu1nWHSXhhdc1RR0PPb2EZp1LX+0E2O3hdPND6Dc96aGpsh3GNC+tXlCMkq OYXQ== X-Gm-Message-State: AOJu0Yx5OhptaAIOWxNejHGDEpODIi1DbflSrzysSRqQMGjem7ax6B1+ mpRrFXXoL5M25nE+ZYqJVxBCeXvEjkp9dQ== X-Google-Smtp-Source: AGHT+IHlPL+HL399ksotIWmpMUfyt9pRagypKE8rVzmOAPKeTYCRr/kXzvsyM7j8tfKn/bIr08BTWQ== X-Received: by 2002:a0d:c806:0:b0:595:9770:6914 with SMTP id k6-20020a0dc806000000b0059597706914mr5284315ywd.35.1694884495366; Sat, 16 Sep 2023 10:14:55 -0700 (PDT) Received: from [10.230.45.5] ([38.32.73.2]) by smtp.gmail.com with ESMTPSA id d185-20020a0ddbc2000000b0058419c57c66sm1490803ywe.4.2023.09.16.10.14.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 Sep 2023 10:14:54 -0700 (PDT) Message-ID: <7a6692de-f096-637d-fe48-d5fb93e54f8b@FreeBSD.org> Date: Sat, 16 Sep 2023 13:14:09 -0400 List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Graham Perrin , freebsd-current@freebsd.org Cc: freebsd-stable@freebsd.org References: <20230916002831.GU52318@FreeBSD.org> <02c53c2e-127b-33b4-e13d-f6f6589dd5fe@gmail.com> From: Alexander Motin Subject: Re: vfs.zfs.bclone_enabled (was: FreeBSD 14.0-BETA2 Now Available) In-Reply-To: <02c53c2e-127b-33b4-e13d-f6f6589dd5fe@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4RnyNc44Jbz3Gqd On 16.09.2023 01:25, Graham Perrin wrote: > On 16/09/2023 01:28, Glen Barber wrote: >> o A fix for the ZFS block_cloning feature has been implemented. > > Thanks > > I see > , with in stable/14. > > As vfs.zfs.bclone_enabled is still 0 (at least, with 15.0-CURRENT > n265350-72d97e1dd9cc): should we assume that additional fixes, not > necessarily in time for 14.0-RELEASE, will be required before > vfs.zfs.bclone_enabled can default to 1? I am not aware of any block cloning issues now. All this thread about bclone_enabled actually started after I asked why it is still disabled. Thanks to Mark Millard for spotting this issue I could fix, but now we are back at the point of re-enabling it again. Since the tunable does not even exist anywhere outside of FreeBSD base tree, I'd propose to give this code another try here too. I see no point to have it disabled at least in main unless somebody needs time to run some specific tests first. -- Alexander Motin